New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693187 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

GetApp returns nullptr in ArcAppListPrefs::GetAppIdsNoArcEnabledCheck

Project Member Reported by victorhsieh@chromium.org, Feb 16 2017

Issue description

Inside the loop of ArcAppListPrefs::GetAppIdsNoArcEnabledCheck, if you add GetApp(app_id.key()), it actually returns nullptr unexpectedly.
 

Comment 1 by khmel@chromium.org, Feb 21 2017

Status: Started (was: Assigned)

Comment 2 by khmel@chromium.org, Feb 21 2017

Cc: victorhsieh@chromium.org
Status: WontFix (was: Started)
Checked the code and it works as expected.

Correct check in GetAppIdsNoArcEnabledCheck should be 
DCHECK((GetApp(app_id.key())) || (!IsArcEnabled() && !default_apps_.HasApp(app_id.key())));

GetAppIdsNoArcEnabledCheck lists all apps, but GetApp checks into consideration if ARC is currently available. 

I tested and all cases when GetApp returns nullptr is for the case when Arc is not enabled and app is not default app.


Sign in to add a comment