Interesting.

riajiang@: you have looked at events lately. Any ideas?

Interesting.. It's not that they don't work at all - some of them work, but they do the wrong thing. For example F1/back opens up a Help page in the browser, F5/overview does a page refresh, and F6/brightness down seems to work as a TAB. I wonder if accelerator handling for function keys is messed up in some ways. Adding thanhph@ as well who looked at accelerators semi recently.

Seems like a 30 min browsing blocker, so adding mustash-1.

I will take a look at this issue.

I suspect we need to fix event-rewriting (i.e. the code living in //chrome/browser/chromeos/events/) for this to work.

I see. I think we don't use any event rewriters in //services/ui. Probably we should add them in mus or ash processes.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64dcd3803c8e5370075b14c880d4c7f6f4a4d41f

commit 64dcd3803c8e5370075b14c880d4c7f6f4a4d41f
Author: penghuang <penghuang@chromium.org>
Date: Fri Mar 10 15:46:23 2017

Do not use ash in chromeos::EventRewriter.

In CL https://codereview.chromium.org/2724913002/, we will move
chromeos::EventRewriter to //ui/chromeos/events. So it can not use
ash. This CL make StickyKeysController implement ui::EventRewriter,
and let chromeos::EventRewriter use the ui::EventRewriter interface
instead StickyKeysController.

BUG= 693180 

Review-Url: https://codereview.chromium.org/2731283004
Cr-Commit-Position: refs/heads/master@{#456067}

[modify] https://crrev.com/64dcd3803c8e5370075b14c880d4c7f6f4a4d41f/ash/sticky_keys/sticky_keys_controller.cc
[modify] https://crrev.com/64dcd3803c8e5370075b14c880d4c7f6f4a4d41f/ash/sticky_keys/sticky_keys_controller.h
[modify] https://crrev.com/64dcd3803c8e5370075b14c880d4c7f6f4a4d41f/ash/sticky_keys/sticky_keys_unittest.cc
[modify] https://crrev.com/64dcd3803c8e5370075b14c880d4c7f6f4a4d41f/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/64dcd3803c8e5370075b14c880d4c7f6f4a4d41f/chrome/browser/chromeos/events/event_rewriter.cc
[modify] https://crrev.com/64dcd3803c8e5370075b14c880d4c7f6f4a4d41f/chrome/browser/chromeos/events/event_rewriter.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5df28289ab75276db7941bb8c5c76705ac1ef8f

commit e5df28289ab75276db7941bb8c5c76705ac1ef8f
Author: penghuang <penghuang@chromium.org>
Date: Thu Mar 16 22:54:36 2017

Move chromeos::EventRewriter to //ui/chromeos/events

chromeos::EventRewriter is responsible for converting F1~F12 to media
function keys. Those conversion is not working in mus+ash. This CL moves
chromeos::EventRewriter to //ui/chromeos/events from
//chrome/browser/chromeos/events. So it can be used by mus as well.

BUG= 693180 

Review-Url: https://codereview.chromium.org/2724913002
Cr-Commit-Position: refs/heads/master@{#457592}

[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[add] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/chromeos/events/event_rewriter_delegate_impl.cc
[add] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/chromeos/events/event_rewriter_delegate_impl.h
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/chromeos/events/keyboard_driven_event_rewriter.cc
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/common/pref_names.cc
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/chrome/common/pref_names.h
[modify] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/remoting/client/normalizing_input_filter_cros.cc
[add] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/ui/chromeos/events/BUILD.gn
[rename] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/ui/chromeos/events/event_rewriter_chromeos.cc
[rename] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/ui/chromeos/events/event_rewriter_chromeos.h
[add] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/ui/chromeos/events/pref_names.cc
[add] https://crrev.com/e5df28289ab75276db7941bb8c5c76705ac1ef8f/ui/chromeos/events/pref_names.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d

commit 17134c6c3b7ef0d87c09c6148340ee98b05e8b0d
Author: penghuang <penghuang@chromium.org>
Date: Thu Mar 23 00:01:07 2017

mustash: Use ui::chromeos::EventRewriter in mus

Use ui::chromeos::EventRewriter in mus for Chrome OS build.
It will convert F1~12 keys to media function keys.

BUG= 693180 

Review-Url: https://codereview.chromium.org/2712963003
Cr-Commit-Position: refs/heads/master@{#458938}

[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ash/accelerators/key_hold_detector.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ash/drag_drop/drag_drop_controller_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ash/host/ash_window_tree_host_platform.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ash/host/ash_window_tree_host_unified.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ash/host/ash_window_tree_host_x11.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/chrome/browser/chromeos/accessibility/spoken_feedback_event_rewriter.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/chrome/browser/chromeos/input_method/input_method_engine.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/chrome/browser/ui/views/first_run_bubble_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/content/browser/accessibility/touch_accessibility_aura_browsertest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/content/browser/web_contents/web_contents_view_aura_browsertest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/BUILD.gn
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/cursor_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/display.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/display.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/display_manager.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/display_manager.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/display_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/platform_display.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/platform_display_default.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/platform_display_default.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/platform_display_delegate.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/test_utils.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/test_utils.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/window_server_test_impl.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/services/ui/ws/window_tree_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/gestures/gesture_recognizer_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/mus/window_tree_host_mus.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/test/aura_test_base.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/test/aura_test_helper.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/test/ui_controls_factory_ozone.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/window_targeter.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/window_tree_host.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/window_tree_host.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/aura/window_tree_host_x11.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/BUILD.gn
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/event_processor.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/event_rewriter.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/event_rewriter_unittest.cc
[add] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/event_sink.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/event_source.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/event_source.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/test/event_generator.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/test/events_test_utils.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/events/test/events_test_utils.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/keyboard/keyboard_util.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/message_center/views/notification_view_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/test/event_generator_delegate_mac.mm
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/test/widget_test.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/test/widget_test_aura.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/test/widget_test_mac.mm
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/widget/native_widget_aura_unittest.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/widget/widget.cc
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/widget/widget.h
[modify] https://crrev.com/17134c6c3b7ef0d87c09c6148340ee98b05e8b0d/ui/views/widget/widget_interactive_uitest.cc

 Issue 678824  has been merged into this issue.