New issue
Advanced search Search tips

Issue 693179 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Media Recorder: ensure "error" is the last event to be fired

Project Member Reported by mcasas@chromium.org, Feb 16 2017

Issue description

See https://github.com/w3c/mediacapture-record/issues/52.

Essentially make sure that "error" is the last event
fired after any "dataavailable"s and "stop".

This was deemed a bugfix and hence doesn't need a ITI/ITS.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/786184e85335e590fd0dd3b31d267f524633a90b

commit 786184e85335e590fd0dd3b31d267f524633a90b
Author: mcasas <mcasas@chromium.org>
Date: Mon Feb 20 05:28:16 2017

MediaRecorder: make sure ondataavailable+onstop events are fired before onerror

This CL makes sure that "error" is the last event to be fired, after
any "dataavailable" and "stop" events have been received, which
was brought up in [1];

A typical situation triggering an error condition is if the amount
of tracks of the MediaStream being recorded changes.  Checking
for this amount of tracks is moved to the renderer/
implementation so all the errors are now sent via onError(), which
forces the recording to stop().

Added a new Layout Test for it (using <canvas>.captureStream() ISO
getUserMedia() which makes it more upstream-able).

[1] https://github.com/w3c/mediacapture-record/issues/52

BUG= 693179 

Review-Url: https://codereview.chromium.org/2697703003
Cr-Commit-Position: refs/heads/master@{#451561}

[modify] https://crrev.com/786184e85335e590fd0dd3b31d267f524633a90b/content/renderer/media/recorder/media_recorder_handler.cc
[modify] https://crrev.com/786184e85335e590fd0dd3b31d267f524633a90b/content/renderer/media/recorder/media_recorder_handler.h
[add] https://crrev.com/786184e85335e590fd0dd3b31d267f524633a90b/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-error.html
[modify] https://crrev.com/786184e85335e590fd0dd3b31d267f524633a90b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/786184e85335e590fd0dd3b31d267f524633a90b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h

Comment 2 by mcasas@chromium.org, Feb 21 2017

Status: Fixed (was: Started)

Sign in to add a comment