MD Settings: Content Settings -> Notifications long text breaking out |
||||
Issue descriptionChrome Version: 58.0.3015.0 (Developer Build) OS: All What steps will reproduce the problem? (1) Go to MD Settings -> Content Settings -> Notifications (2) Observe when a long url is present, it extends past the container What is the expected result? - Ellipsis or break-word What happens instead? - long text extends past container
,
Mar 2 2017
,
Mar 2 2017
,
Mar 2 2017
Issue 694144 has been merged into this issue.
,
Mar 2 2017
Proposal: How about attaching a "word-break: break-word;" CSS rule at the list-item residing at [1] (see screenshot for end result). We already use this approach in other similar cases, for example at [2] [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_settings/site_list.html?l=67 [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html?l=28
,
Mar 2 2017
Just to make it clear, I am proposing breaking word instead of eliding the text, as suggested by comment#3.
,
Mar 2 2017
#5, sounds fine as an enhancement. I plan to add the elision to start with, but that can be changed later if desired. When considering #3 please remember that there may be a secondary line of text in addition to this primary line of text too. This could get to several lines of text (in theory). So it's not a slam-dunk clear way to go, imo. (Thanks for the example of how to do it, Tom/Alan decide to go that way).
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d4b75bd9a3d6cbda44aa98df49b7d7eb0a39896 commit 7d4b75bd9a3d6cbda44aa98df49b7d7eb0a39896 Author: dschuyler <dschuyler@chromium.org> Date: Thu Mar 02 19:17:21 2017 [MD settings] edlide content exceptions This CL will add ellipses to content settings exceptions that are too long to display. BUG= 693176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2721333007 Cr-Commit-Position: refs/heads/master@{#454330} [modify] https://crrev.com/7d4b75bd9a3d6cbda44aa98df49b7d7eb0a39896/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/7d4b75bd9a3d6cbda44aa98df49b7d7eb0a39896/chrome/browser/resources/settings/site_settings/site_list.html
,
Mar 10 2017
I asked about the elide vs wrapping in a meeting with tbuckley@, bettes@, and dbeam@ and solution chosen is: use elide as long as there is some way for the user to get (or see) the full string. There are two ways to get the full url string: 1. edit the url (all parts of the string can be edited). 2. click on the elided string and select all (ctrl+a or cmd+a) and then copy; the whole url will be copied to the clipboard. Afaik, the choice is an aesthetic one. If there's something being overlooked that makes one choice or the other then this should be reconsidered.
,
Mar 10 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tbuck...@chromium.org
, Feb 17 2017Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)