New issue
Advanced search Search tips

Issue 693166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

muted, autoplay videos triggered IntersectionObserver warning

Reported by mrobe...@twilio.com, Feb 16 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3014.0 Safari/537.36

Please try out the attached reproduction test (index.html).

Roughly,

1. Create a video element.
2. Set its autoplay and muted attributes to true.
3. Set its srcObject attribute to a MediaStream (e.g. the result of getUserMedia({ video: true }))
4. Do not attach the video element it to the DOM.

What is the expected behavior?
Nothing is printed to the console.

What went wrong?
A warning is printed to the console:

> IntersectionObserver.observe(target): target element is not a descendant of root.

Did this work before? N/A 

Chrome version: 56.0.2924.87  Channel: stable
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0

This behavior occurs in Chrome 56 (stable), although I cannot trigger it in Chrome 57 (beta) or Chrome 58 (canary).

 
index.html
2.2 KB View Download
see issue 654079

Comment 2 by ajha@chromium.org, Feb 20 2017

Labels: Needs-Triage-M56
Cc: rbasuvula@chromium.org
Labels: -Needs-Triage-M56 hasbisect-per-revision M-57 OS-Linux OS-Windows
Owner: szager@chromium.org
Status: Assigned (was: Unconfirmed)
Tested in chrome stable #56.0.2924.87 on Mac 10.11.6 and able to reproduce the issue. Not able to reproduce the issue in canary #58.0.3019.0 ,dev #58.0.3013.3 and beta #57.0.2987.54. So providing the reverse bisect details.

Below are the Bisect Details:

Bisect Info:
=============
Good Build: 57.0.2951.0 (Revision- 438385)
Bad Build: 57.0.2950.0 (Revision- 438011)


Bisect URL:
=========== 
You are probably looking for a change made after 438054 (known good), but no later than 438055 (first known bad).

CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/f07ac3c6704c3db574549ebc2f2e9880dcbf66b7..3520351e84d8d16b06d3f09a109f1296ec620c23


From the CL above, assigning the issue to the concern owner. Probably this change could have fixed the issue.

@ szager : 
------------------
Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.

Review-Url:https://codereview.chromium.org/2553343004

Note: Able to reproduce the issue in Win 10.0 and Ubuntu 14.04 displaying different error "DevicesNotFoundError".
Components: -Blink Blink>Layout
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ba8baa98a274d2bb9aef1d95bdb237255f09ba8

commit 6ba8baa98a274d2bb9aef1d95bdb237255f09ba8
Author: szager <szager@chromium.org>
Date: Wed Feb 22 17:34:48 2017

[IntersectionObserver] Get rid of spurious console warning.

This previously may have been useful console warning to alert
developers when they called observe() on a target without adding it to
the DOM tree.  However, now that observe() always results in an
initial notification, this console warning becomes more noisy than
useful.

BUG= 693166 
R=mlamouri@chromium.org,ojan@chromium.org

Review-Url: https://codereview.chromium.org/2708243002
Cr-Commit-Position: refs/heads/master@{#452109}

[delete] https://crrev.com/79daaa960f6d76d857f71233553db0ee8a30f9e1/third_party/WebKit/LayoutTests/intersection-observer/containing-block-warning-expected.txt
[delete] https://crrev.com/79daaa960f6d76d857f71233553db0ee8a30f9e1/third_party/WebKit/LayoutTests/intersection-observer/containing-block-warning.html
[modify] https://crrev.com/6ba8baa98a274d2bb9aef1d95bdb237255f09ba8/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

Status: Fixed (was: Assigned)
This is fixed in tip of tree and will appear in branch 58.

Sign in to add a comment