it's time.
@kozy: do you think you could dedupe stacks before we do that?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4112b4cc46cbc283a72d79087acb83f24fb4af58 commit 4112b4cc46cbc283a72d79087acb83f24fb4af58 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon Apr 24 20:40:40 2017 [DevTools] enable async stacks by default - increased async stack trace depth limit to 32 (currently we can do any number here without increasing running time or memory consumption but then we need better UX for stack traces), - added disable async stack traces settings to the settings list under Debugger category, - changed limit for tests and rebased all tests with new async stacks. Summary of backend improvements: - async stacks has predictible peak memory usage - ~20 Mbytes, - change of running time of setTimeout, setInterval, requestAnimation with and without async stacks is almost unobservable, - promises are only twice slower. More numbers: https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag BUG= chromium:693164 , v8:6189 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2828863002 Cr-Commit-Position: refs/heads/master@{#466749} [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/lazy-addeventlisteners-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-image.html [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-assert-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-log-eval-syntax-error-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-message-from-inline-with-url-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-trace-arguments-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-trace-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-trace-in-eval-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-in-worker-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/exception-objects-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/console/function-name-in-console-message-stack-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check.html [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-pause-on-exception-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-promises-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-blackbox-by-source-code-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-jquery-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-sourcemap-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-mute-exception-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-pause-on-exception-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-pause-on-promise-rejection-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-across-timeouts-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-out-across-timeouts-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-out-custom-element-callbacks-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-out-event-listener-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-across-timeouts-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-through-promises-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-empty-event-listener-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/copy-stack-trace-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/copy-stack-trace.html [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/Source/devtools/front_end/sdk/module.json [modify] https://crrev.com/4112b4cc46cbc283a72d79087acb83f24fb4af58/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
Comment 1 Deleted