Fix VR Shell cursor rendering to work better with floor |
||
Issue descriptionThe addition of the reference floor complicates our current approach. After some discussion, we'll simplify to: - Get rid of content quad plane special-casing in native rendering code. - Have UI create invisible, hittable element behind content quad, to simulate the plane. - Have native limit the cursor distance to a bounding sphere, even if the laser intersects an element. - Have Javascript control the bounding sphere radius. - Make sure head-locked targets are hittable.
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e28e50ecc0bc4077c879abc2d06957de0918e75e commit e28e50ecc0bc4077c879abc2d06957de0918e75e Author: cjgrant <cjgrant@chromium.org> Date: Tue Feb 21 18:25:31 2017 Change how the VR reticle distance is determined. - Eliminate special-casing of UI elements on the native side. - Use an invisible, hittable quad as the plane behind content. - Only UI element hit points within a bounding sphere are allowed. - Let the UI set the radius of the bounding sphere. BUG= 693154 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2698623007 Cr-Commit-Position: refs/heads/master@{#451802} [modify] https://crrev.com/e28e50ecc0bc4077c879abc2d06957de0918e75e/chrome/browser/android/vr_shell/ui_elements.cc [modify] https://crrev.com/e28e50ecc0bc4077c879abc2d06957de0918e75e/chrome/browser/android/vr_shell/ui_scene.cc [modify] https://crrev.com/e28e50ecc0bc4077c879abc2d06957de0918e75e/chrome/browser/android/vr_shell/ui_scene.h [modify] https://crrev.com/e28e50ecc0bc4077c879abc2d06957de0918e75e/chrome/browser/android/vr_shell/ui_scene_unittest.cc [modify] https://crrev.com/e28e50ecc0bc4077c879abc2d06957de0918e75e/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/e28e50ecc0bc4077c879abc2d06957de0918e75e/chrome/browser/resources/vr_shell/vr_shell_ui.js [modify] https://crrev.com/e28e50ecc0bc4077c879abc2d06957de0918e75e/chrome/browser/resources/vr_shell/vr_shell_ui_api.js [modify] https://crrev.com/e28e50ecc0bc4077c879abc2d06957de0918e75e/chrome/browser/resources/vr_shell/vr_shell_ui_scene.js
,
Feb 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ddorwin@chromium.org
, Feb 16 2017