New issue
Advanced search Search tips

Issue 693150 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 707006



Sign in to add a comment

[WPT Export] wpt-export fails inside git crrev-parse on Mac

Project Member Reported by foolip@chromium.org, Feb 16 2017

Issue description

$ ./Tools/Scripts/wpt-export --gh-user=chromium-wpt-export-bot --gh-token=$TOKEN
WPT checkout exists at /tmp/wpt, fetching latest
Traceback (most recent call last):
  File "./Tools/Scripts/wpt-export", line 68, in <module>
    main()
  File "./Tools/Scripts/wpt-export", line 64, in main
    test_exporter.run()
  File "/Users/foolip/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 38, in run
    self.export_first_exportable_commit()
  File "/Users/foolip/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 65, in export_first_exportable_commit
    wpt_commit, chromium_commit = self.local_wpt.most_recent_chromium_commit()
  File "/Users/foolip/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py", line 61, in most_recent_chromium_commit
    chromium_commit = ChromiumCommit(self.host, position=position)
  File "/Users/foolip/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py", line 35, in __init__
    assert len(sha) == 40, 'Expected SHA-1 hash, got {}'.format(sha)
AssertionError: Expected SHA-1 hash, got usage: git rev-list [OPTION] <commit-id>... [ -- paths... ]

The problem is inside git crrev-parse, and can be reproduced with:

$ git crrev-parse 'refs/heads/master@{#450889}'

The $remote_ref variable gets the value refs\/remotes\/origin/master with extra backslashes, so presumably there's something fun about escaping working differently in macOS's old bash going on.
 
Blocking: 707006
Blocking: -657117
Components: Blink>Infra>Ecosystem
Cc: jeffcarp@chromium.org
Owner: ----
Status: Available (was: Assigned)
Status: Fixed (was: Available)
The issue in git-crrev-parse has been fixed recently: https://chromium-review.googlesource.com/c/572052

I also verified it worked correctly on my Mac with stock Bash 3.2.57.


Note: depot_tools should be automatically updated with `gclient sync`.

Sign in to add a comment