Remove fno-omit-frame-pointer |
|||
Issue descriptionCurrently, compiler wrapper appends fno-omit-frame-pointer so that stack traces can be obtained. However, stack traces are already broken on arm. x86 (Haswell and later) has another way of getting stack traces (LBR callstacks) for kernel versions >= 3.18 and 4.4.
,
Jul 24 2017
Update: Plan to land this sometime soon for ARM32 after moving to a newer llvm version.
,
Aug 7 2017
Will add this to toolchain team daily testing.
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/84fb3dc584d61fa188513188bf92a711939abfd4 commit 84fb3dc584d61fa188513188bf92a711939abfd4 Author: Manoj Gupta <manojgupta@google.com> Date: Fri Sep 15 23:59:23 2017 sysroot_wrapper: Do not force frame pointers on ARM32. CWP needs frame pointers to be able to get statck traces with profile. However, stack traces are broken on ARM32. Therefore, drop forcing frame pointers on ARM32. Chrome is already built without frame pointers on ARM32 so the impact of this CL is extremely limited. BUG= chromium:693137 TEST=Daily toolchain team testing. Change-Id: Ie7c0c994340e54d5586be4f53ec52d3c654b0d75 Reviewed-on: https://chromium-review.googlesource.com/452727 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org> [modify] https://crrev.com/84fb3dc584d61fa188513188bf92a711939abfd4/sys-devel/gcc/files/sysroot_wrapper.hardened.body [rename] https://crrev.com/84fb3dc584d61fa188513188bf92a711939abfd4/sys-devel/gcc/gcc-4.9.2-r164.ebuild
,
Sep 19 2017
Removed from ARM32. Other archs till need it. |
|||
►
Sign in to add a comment |
|||
Comment 1 by manojgupta@chromium.org
, Mar 6 2017