New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 693100 link

Starred by 2 users
Status: Fixed
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebGL animations do not call HTMLCanvasElement->didDraw at every frame

Project Member Reported by junov@chromium.org, Feb 16 2017 
Added trace instrumentation in a local build to track calls to didDraw, and realized it is only called on the first frame.  It seem we are forgetting to reset m_markedCanvasDirty in WebGLRenderingContextBase.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02b0b43a38dfc706a751f8983972e56ef6b81ccb

commit 02b0b43a38dfc706a751f8983972e56ef6b81ccb
Author: junov <junov@chromium.org>
Date: Wed Feb 22 21:58:57 2017

Fix missing finalizeFrame barriers in WebGL animations

BUG= 693100 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2699713005
Cr-Commit-Position: refs/heads/master@{#452223}

[modify] https://crrev.com/02b0b43a38dfc706a751f8983972e56ef6b81ccb/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element.html
[modify] https://crrev.com/02b0b43a38dfc706a751f8983972e56ef6b81ccb/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/02b0b43a38dfc706a751f8983972e56ef6b81ccb/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/02b0b43a38dfc706a751f8983972e56ef6b81ccb/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/02b0b43a38dfc706a751f8983972e56ef6b81ccb/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/02b0b43a38dfc706a751f8983972e56ef6b81ccb/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp
[modify] https://crrev.com/02b0b43a38dfc706a751f8983972e56ef6b81ccb/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/02b0b43a38dfc706a751f8983972e56ef6b81ccb/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Comment 2 by junov@chromium.org, Feb 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment