Use ANGLE's GL backend on Windows for white-listed drivers |
|||||||||||||||
Issue descriptionANGLE's GL backend can be much faster than the D3D backends but may be less stable on many drivers. Try using it by default on specific white-listed drivers that are tested on Chrome's GPU FYI waterfall. Try NVIDIA first and possibly Intel next if the same performance benefits are seen. ⛆ |
|
|
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73601885cf6022ea45eae4eb2468ac6d0d7a39d2 commit 73601885cf6022ea45eae4eb2468ac6d0d7a39d2 Author: geofflang <geofflang@chromium.org> Date: Tue Feb 21 22:15:48 2017 Test WebGL2 on ANGLE's GL backed on Windows/NVIDIA. TBR=zmo@chromium.org BUG=693090 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2701523005 Cr-Commit-Position: refs/heads/master@{#451851} [modify] https://crrev.com/73601885cf6022ea45eae4eb2468ac6d0d7a39d2/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/73601885cf6022ea45eae4eb2468ac6d0d7a39d2/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/73601885cf6022ea45eae4eb2468ac6d0d7a39d2/testing/buildbot/chromium.gpu.fyi.json
,
Feb 22 2017
,
Feb 22 2017
,
Feb 22 2017
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d0947b6ff35a8b033a38ce689cd6fb121c31f88 commit 8d0947b6ff35a8b033a38ce689cd6fb121c31f88 Author: yizhou.jiang <yizhou.jiang@intel.com> Date: Fri Apr 28 18:28:44 2017 Roll WebGL f7157c2..2395287 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/f7157c2..2395287 BUG=693090,712096 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2844363004 Cr-Commit-Position: refs/heads/master@{#468067} [modify] https://crrev.com/8d0947b6ff35a8b033a38ce689cd6fb121c31f88/DEPS [modify] https://crrev.com/8d0947b6ff35a8b033a38ce689cd6fb121c31f88/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/8d0947b6ff35a8b033a38ce689cd6fb121c31f88/content/test/gpu/gpu_tests/webgl_conformance_revision.txt
,
May 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df78633101a43642053c681b8530c88bf7032e06 commit df78633101a43642053c681b8530c88bf7032e06 Author: yizhou.jiang <yizhou.jiang@intel.com> Date: Sun May 14 17:33:05 2017 Roll WebGL 73b300f..6517159 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/73b300f..6517159 BUG=693090,712096 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2874933003 Cr-Commit-Position: refs/heads/master@{#471635} [modify] https://crrev.com/df78633101a43642053c681b8530c88bf7032e06/DEPS [modify] https://crrev.com/df78633101a43642053c681b8530c88bf7032e06/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/df78633101a43642053c681b8530c88bf7032e06/content/test/gpu/gpu_tests/webgl_conformance_revision.txt
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ac9902a04fadaa7e3f307cee39659578e53fe18 commit 1ac9902a04fadaa7e3f307cee39659578e53fe18 Author: zmo <zmo@chromium.org> Date: Fri Jun 09 04:56:41 2017 Update WebGL2 conformance test expectations for Win bots BUG= 491419 , 614418 ,662644, 676848 ,680754,693090,705865, 709484 TEST=GPU FYI bots TBR=kbr@chromium.org,kainino@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2927233002 Cr-Commit-Position: refs/heads/master@{#478203} [modify] https://crrev.com/1ac9902a04fadaa7e3f307cee39659578e53fe18/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Dec 12 2017
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/3cd48fff96c13921860bd4f311bfb5370462d047 commit 3cd48fff96c13921860bd4f311bfb5370462d047 Author: Geoff Lang <geofflang@chromium.org> Date: Mon Mar 26 21:35:17 2018 Implement robust resource initialization for OpenGL. BUG= angleproject:2107 BUG=angleproject:2407 BUG=angleproject:2408 BUG=693090 Change-Id: I6444f80f9703d6341f2ec67518050adc88f71d96 Reviewed-on: https://chromium-review.googlesource.com/678482 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/ContextGL.cpp [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/renderergl_utils.h [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/BlitGL.h [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/SurfaceGL.cpp [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/tests/gl_tests/RobustResourceInitTest.cpp [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/renderergl_utils.cpp [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/RenderbufferGL.cpp [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.cpp [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/BlitGL.cpp [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/TextureGL.cpp [modify] https://crrev.com/3cd48fff96c13921860bd4f311bfb5370462d047/src/libANGLE/renderer/gl/RenderbufferGL.h
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c849d31db87f160aed138c694ea614bf6d5f1d9 commit 5c849d31db87f160aed138c694ea614bf6d5f1d9 Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Mar 27 03:28:55 2018 Roll src/third_party/angle/ 822a84b19..84fdc62c6 (8 commits) https://chromium.googlesource.com/angle/angle.git/+log/822a84b1959f..84fdc62c6160 $ git log 822a84b19..84fdc62c6 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 jiawei.shao Fix a compile error when ANGLE_D3D9EX == ANGLE_DISABLED 2017-10-03 geofflang Implement robust resource initialization for OpenGL. 2018-03-20 oetuaho Clean up checkCanBeLValue 2018-01-27 kbr Update stencil validation rules for WebGL 2018-03-19 oetuaho Rely on hash to check for some mangled name matches 2018-03-23 oetuaho Clarify aliasing rules in CHROMIUM_bind_uniform_location 2018-03-26 geofflang Check result of D3D11 map operation in Blit11::copyAndConvert. 2018-03-22 oetuaho Move ReplaceVariable to tree_util directory Created with: roll-dep src/third_party/angle BUG=chromium:693090, chromium:806557 , chromium:823856 , chromium:825503 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: Ib864a0492b29de58564d5522977c11d6623dad4a Reviewed-on: https://chromium-review.googlesource.com/981675 Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545968} [modify] https://crrev.com/5c849d31db87f160aed138c694ea614bf6d5f1d9/DEPS
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4c2abf1649f33f8d757cbe4b1e1013176edb999 commit b4c2abf1649f33f8d757cbe4b1e1013176edb999 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Mar 27 19:35:09 2018 Allow GPU rasterization on ANGLE's GL backend on Windows. The previous rules assumed D3D and checked for shader model versions which are not valid when running on ANGLE's GL backend. Because ANGLE's GL backend will only be whitelisted on certain drivers that are known to support GPU rasterization, always allow GPU rasterization on top of GL. BUG=693090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I95f9eb4376fd9edf7fd7914523a0cb65459ca26b Reviewed-on: https://chromium-review.googlesource.com/981110 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#546206} [modify] https://crrev.com/b4c2abf1649f33f8d757cbe4b1e1013176edb999/gpu/config/software_rendering_list.json
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/13e31bb030ec34ef8be9a24ace8e8d3079ebb8d8 commit 13e31bb030ec34ef8be9a24ace8e8d3079ebb8d8 Author: Geoff Lang <geofflang@chromium.org> Date: Wed Mar 28 16:54:26 2018 GL: Check framebuffer completeness before running blit shaders. Cube map destination textures may not be complete until all faces have been initialized. BUG=693090 Change-Id: I19816c9def3b9663491397cded5d24ca808a3f78 Reviewed-on: https://chromium-review.googlesource.com/982393 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/13e31bb030ec34ef8be9a24ace8e8d3079ebb8d8/src/libANGLE/renderer/gl/BlitGL.cpp [modify] https://crrev.com/13e31bb030ec34ef8be9a24ace8e8d3079ebb8d8/src/libANGLE/renderer/gl/BlitGL.h [modify] https://crrev.com/13e31bb030ec34ef8be9a24ace8e8d3079ebb8d8/src/libANGLE/renderer/gl/TextureGL.cpp
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e15e0551a3a478aaae56bb6ae384496cbd9f36c3 commit e15e0551a3a478aaae56bb6ae384496cbd9f36c3 Author: Geoff Lang <geofflang@chromium.org> Date: Wed Mar 28 17:25:38 2018 Update WebGL expectations for ANGLE's OpenGL backend. BUG=693090 TBR=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic637916dee8c1869ee15c3d589b99fd379367d8c Reviewed-on: https://chromium-review.googlesource.com/984294 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#546533} [modify] https://crrev.com/e15e0551a3a478aaae56bb6ae384496cbd9f36c3/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec0fe70383874453ccb756bf83c7cdfba670682f commit ec0fe70383874453ccb756bf83c7cdfba670682f Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Mar 28 20:24:40 2018 Roll src/third_party/angle/ c7575da54..13e31bb03 (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/c7575da546a4..13e31bb030ec $ git log c7575da54..13e31bb03 --date=short --no-merges --format='%ad %ae %s' 2018-03-27 geofflang GL: Check framebuffer completeness before running blit shaders. 2018-03-23 oetuaho Remove createAssign: only called once 2018-03-28 geofflang Skip RobustResourceInitTestES3.MaskedStencilClearBuffer on Intel Mac. Created with: roll-dep src/third_party/angle BUG=chromium:693090 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I32a05df35abdabf71f8b844ca777acd7290ad7a2 Reviewed-on: https://chromium-review.googlesource.com/984389 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546583} [modify] https://crrev.com/ec0fe70383874453ccb756bf83c7cdfba670682f/DEPS
,
Apr 12 2018
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/e24032a2c40b92fe14d458899cd472819ff6f0b9 commit e24032a2c40b92fe14d458899cd472819ff6f0b9 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Apr 19 12:49:49 2018 The 'format' of unsized SRGB internal formats should be SRGB too. EXT_sRGB requires calling TexImage with SRGB as the 'format' parameter. This was causing issues when we would take an InternalFormat struct representing an unsized sRGB format and be unable to use it's format member to make GL calls without transforming it. BUG=693090 Change-Id: I8b9baf2591a998a0088e5275f42ffc568e37100d Reviewed-on: https://chromium-review.googlesource.com/984965 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> [modify] https://crrev.com/e24032a2c40b92fe14d458899cd472819ff6f0b9/src/libANGLE/formatutils.cpp [modify] https://crrev.com/e24032a2c40b92fe14d458899cd472819ff6f0b9/src/libANGLE/validationES2.cpp [modify] https://crrev.com/e24032a2c40b92fe14d458899cd472819ff6f0b9/src/tests/gl_tests/SRGBTextureTest.cpp
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b1dbf84528be1171b32d727ff24a3b93d4ace37 commit 7b1dbf84528be1171b32d727ff24a3b93d4ace37 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Apr 19 18:10:05 2018 Run the WebGL2 conformance GL tests against the passthrough cmd decoder. ANGLE's GL backend will likely only be released in conjuction with the passthrough command decoder. TBR=kbr@chromium.org BUG=693090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I92df6a32eae8a8266454ab6312c2a3b56c2cf9e4 Reviewed-on: https://chromium-review.googlesource.com/984372 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#552084} [modify] https://crrev.com/7b1dbf84528be1171b32d727ff24a3b93d4ace37/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/7b1dbf84528be1171b32d727ff24a3b93d4ace37/testing/buildbot/chromium.gpu.fyi.json
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7be7a2e71fb9299b70c7694ee6fdd7992276b26 commit a7be7a2e71fb9299b70c7694ee6fdd7992276b26 Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 19 21:57:31 2018 Roll src/third_party/angle/ 1d97a4d03..025aafdfc (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/1d97a4d0363d..025aafdfc4af $ git log 1d97a4d03..025aafdfc --date=short --no-merges --format='%ad %ae %s' 2017-10-30 geofflang Make EGL image extensions enableable. 2017-11-07 geofflang Make EXT_texture_storage enableable. 2018-03-28 geofflang The 'format' of unsized SRGB internal formats should be SRGB too. Created with: roll-dep src/third_party/angle BUG=chromium:693090 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Id036eb947993a00093291ad5dfa30663529e3471 Reviewed-on: https://chromium-review.googlesource.com/1020149 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552176} [modify] https://crrev.com/a7be7a2e71fb9299b70c7694ee6fdd7992276b26/DEPS
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d223f8bf342614d9831f5c8534ddfa438d373dcb commit d223f8bf342614d9831f5c8534ddfa438d373dcb Author: Geoff Lang <geofflang@chromium.org> Date: Fri Apr 20 12:27:22 2018 Add a feature to use ANGLE's OpenGL backend by default. BUG=693090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic5cd3b8d96669c988e9d9198be8954a4f2d38b8b Reviewed-on: https://chromium-review.googlesource.com/963832 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552310} [modify] https://crrev.com/d223f8bf342614d9831f5c8534ddfa438d373dcb/ui/gl/gl_surface_egl.cc [modify] https://crrev.com/d223f8bf342614d9831f5c8534ddfa438d373dcb/ui/gl/gl_switches.cc [modify] https://crrev.com/d223f8bf342614d9831f5c8534ddfa438d373dcb/ui/gl/gl_switches.h
,
Apr 20 2018
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/006891910a08f646d6d5f45842a557e6087ed9fe commit 006891910a08f646d6d5f45842a557e6087ed9fe Author: Geoff Lang <geofflang@chromium.org> Date: Mon Apr 23 13:35:09 2018 GL: Fix the CPU readback path of CopyTextureCHROMIUM. 1. BlitGL's resources were not being intialized. 2. The format/type information was not enough to know if the destination texture was SRGB. BUG=693090 Change-Id: I3fc277a175772d3b6acace1810cb43f4a9bdc473 Reviewed-on: https://chromium-review.googlesource.com/982642 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/006891910a08f646d6d5f45842a557e6087ed9fe/src/libANGLE/renderer/gl/TextureGL.h [modify] https://crrev.com/006891910a08f646d6d5f45842a557e6087ed9fe/src/tests/gl_tests/CopyTextureTest.cpp [modify] https://crrev.com/006891910a08f646d6d5f45842a557e6087ed9fe/src/libANGLE/renderer/gl/BlitGL.cpp [modify] https://crrev.com/006891910a08f646d6d5f45842a557e6087ed9fe/src/libANGLE/renderer/gl/TextureGL.cpp
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc974db9edaffe924df641622d502be870e8dd0d commit dc974db9edaffe924df641622d502be870e8dd0d Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Apr 23 16:49:44 2018 Roll src/third_party/angle/ c6a0618fb..af2b33be5 (6 commits) https://chromium.googlesource.com/angle/angle.git/+log/c6a0618fb02a..af2b33be5a3a $ git log c6a0618fb..af2b33be5 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 jiawei.shao Use ShaderMap in ProgramD3D - Part I 2018-04-23 oetuaho Add documentation for writing AST transformations 2018-03-27 geofflang GL: Fix the CPU readback path of CopyTextureCHROMIUM. 2018-04-23 lucferron Vulkan: Lift suppressions because of vulkan validation layer regression 2018-04-18 jiawei.shao ES31: Add validation on geometry shader interface blocks matching 2018-04-19 lucferron Vulkan: Implement Texture wrap modes and non-mipmapped filtering modes Created with: roll-dep src/third_party/angle BUG=chromium:693090 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Id6d4968910d4b6d7ec1f601b950fb3dd8cf02ff0 Reviewed-on: https://chromium-review.googlesource.com/1023982 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552728} [modify] https://crrev.com/dc974db9edaffe924df641622d502be870e8dd0d/DEPS
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c3aa25a7664109b0b7ddc886b470b8f1fe4e36 commit d4c3aa25a7664109b0b7ddc886b470b8f1fe4e36 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Apr 24 20:37:02 2018 Update WebGL2 expectations for ANGLE GL + Passthrough. BUG=693090 TBR=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I722b61b1c7276e6957b39c9d141224fd48db8498 Reviewed-on: https://chromium-review.googlesource.com/1024472 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#553257} [modify] https://crrev.com/d4c3aa25a7664109b0b7ddc886b470b8f1fe4e36/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c4ab88955205c8280a7ebaf2606df644047bce5 commit 1c4ab88955205c8280a7ebaf2606df644047bce5 Author: Geoff Lang <geofflang@chromium.org> Date: Wed Apr 25 16:14:34 2018 Resupress some WebGL2 tests on ANGLE GL + Passthrough. BUG=693090 TBR=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I882da7cb607592a58d9a022f5af656cb45278c2a Reviewed-on: https://chromium-review.googlesource.com/1028171 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#553592} [modify] https://crrev.com/1c4ab88955205c8280a7ebaf2606df644047bce5/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Apr 26 2018
Geoff: the shadercommonfunction test is still flaky: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/907
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f7f351eaca2ed4571e48a8cc36ff57432935ec9 commit 3f7f351eaca2ed4571e48a8cc36ff57432935ec9 Author: Geoff Lang <geofflang@chromium.org> Date: Fri Apr 27 14:30:13 2018 Resuppress some WebGL2 tests on ANGLE GL + Passthrough. deqp/functional/gles3/shadercommonfunction.html fails fairly often on the Win10 FYI Release (NVIDIA) bot. BUG=693090 TBR=zmo@chromium.org NOTRY=true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3e6c02124ffd69d432bbcf9bf911501cfc6d9f5e Reviewed-on: https://chromium-review.googlesource.com/1032759 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#554385} [modify] https://crrev.com/3f7f351eaca2ed4571e48a8cc36ff57432935ec9/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
May 14 2018
,
Jun 13 2018
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1241aea53e75dab24b82f20e705fd290c5d445ea commit 1241aea53e75dab24b82f20e705fd290c5d445ea Author: Olli Etuaho <oetuaho@nvidia.com> Date: Thu Aug 09 07:49:15 2018 Get NVIDIA driver version from NVML on 64-bit Windows NVML provides a more reliable way to query for the NVIDIA driver version. It also provides a query for NVIDIA CUDA compute capability which corresponds to the GPU generation. This is a good value to use for filtering GPUs based on hardware properties. We now query NVML for driver version and CUDA compute capability in case an NVIDIA GPU is encountered on Windows. NVML is loaded dynamically from %ProgramW6432%/NVIDIA Corporation/NVSMI/nvml.dll. In recent drivers the library is only shipped as a 64-bit binary, so it won't load in case the 32-bit build of Chromium is used. As a fallback, the actual NVIDIA driver version is parsed from the driver version in the Windows registry. This best-effort parsing should work for most versions, though every single version may not conform to the expected format. NVML has been present in NVIDIA drivers since version 270 published in 2011. Some functionality in NVML is exclusive to professional Quadro or Tesla GPUs, but basic functionality like the queries used here are available across NVIDIA GPU brands. BUG=693090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I31b44021e00426fcfb2b850fea5d63c114c4569c Reviewed-on: https://chromium-review.googlesource.com/1108199 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Cr-Commit-Position: refs/heads/master@{#581820} [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/content/browser/gpu/gpu_internals_ui.cc [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/DEPS [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/config/BUILD.gn [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/config/gpu_driver_bug_list.json [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/config/gpu_info.cc [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/config/gpu_info.h [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/config/gpu_info_collector_win.cc [add] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/config/nvml_info.cc [add] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/config/nvml_info.h [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/config/software_rendering_list.json [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/ipc/common/gpu_info.mojom [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/ipc/common/gpu_info_struct_traits.cc [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/gpu/ipc/common/gpu_info_struct_traits.h [add] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/third_party/nvml/LICENSE [add] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/third_party/nvml/OWNERS [add] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/third_party/nvml/README.chromium [add] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/third_party/nvml/nvml.h [modify] https://crrev.com/1241aea53e75dab24b82f20e705fd290c5d445ea/tools/checklicenses/checklicenses.py
,
Aug 10
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47fecb1157b2be1c690e427674b8428113c45475 commit 47fecb1157b2be1c690e427674b8428113c45475 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Aug 10 20:16:23 2018 Temporarily disable GPU info collection using NVML. There are many crashes seen on Chrome Canary inside nvml.dll, so until a pattern can be found and a workaround proposed, stop calling into it. Bug: 693090, 873095 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0204273fb88ba8b61799916d98c843f0068ccadc Tbr: zmo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1171376 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#582307} [modify] https://crrev.com/47fecb1157b2be1c690e427674b8428113c45475/gpu/config/nvml_info.cc
,
Aug 13
Given the reliability issues with the NVML DLL, I think future versions of this should load it into a utility process rather than browser process. Please consider reverting https://chromium-review.googlesource.com/1108199 entirely, and moving the code into utility.
,
Aug 14
Calling into the NVML DLL also resulted in a 80ms startup performance regression in the GPU process, much of which appears to be due to communicating with the device driver. See attached flame graph image or (Google-internal link) https://uma.googleplex.com/p/chrome/callstacks?sid=1985c638e04adb4fe551fa588e08fa6b
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b597d40b6e8a61b207101fa6fb2163067bf2a4b5 commit b597d40b6e8a61b207101fa6fb2163067bf2a4b5 Author: Geoff Lang <geofflang@chromium.org> Date: Fri Aug 17 17:15:44 2018 Broaden some WebGL2 expectations for ANGLE/OpenGL. TBR=kbr@chromium.org BUG=693090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia1e99a3f928db453808fc9b1cba80feb6d4ac383 Reviewed-on: https://chromium-review.googlesource.com/1179819 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#584109} [modify] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1223211928259cb19ccd383b6b28f0a4e2126b1d commit 1223211928259cb19ccd383b6b28f0a4e2126b1d Author: Olli Etuaho <oetuaho@nvidia.com> Date: Fri Sep 07 10:15:29 2018 Add ANGLE backend flag to about:flags The flag is only available on Windows and offers choices to use the OpenGL, D3D9 or D3D11 backend. TEST=manual test on Windows BUG=chromium:693090 Change-Id: Ia9ce5d58a0658af513b070e564014398f35a243e Reviewed-on: https://chromium-review.googlesource.com/1202203 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589480} [modify] https://crrev.com/1223211928259cb19ccd383b6b28f0a4e2126b1d/chrome/browser/about_flags.cc [modify] https://crrev.com/1223211928259cb19ccd383b6b28f0a4e2126b1d/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/1223211928259cb19ccd383b6b28f0a4e2126b1d/chrome/browser/flag_descriptions.h [modify] https://crrev.com/1223211928259cb19ccd383b6b28f0a4e2126b1d/tools/metrics/histograms/enums.xml
,
Oct 9
|
||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by geoffl...@chromium.org
, Feb 21 2017