New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693075 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 240576



Sign in to add a comment

Fullscreen mode sets window.scrollY = 0

Reported by lo...@yandex-team.ru, Feb 16 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.53 YaBrowser/17.3.0.1118 Yowser/2.5 Safari/537.36

Example URL:
See attached html

Steps to reproduce the problem:
1. Open attached html
2. Click play
3. Click toggle fullscreen

What is the expected behavior?
Video play smoothly

What went wrong?
Alert "BUG!"

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 56.0.2924.53  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0

It works fine in Firefox and IE/Edge.

 
bug.html
538 bytes View Download
Labels: Needs-Triage-M56

Comment 2 by hdodda@chromium.org, Feb 17 2017

Cc: hdodda@chromium.org
Labels: -Needs-Triage-M56 M-58 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Tested on windows 7 , mac os 10.12.2 and ubuntu 14.04 on chrome canary M58 #58.0.3015.0/3014.0 , chrome stable M56 #56.0.2924.87 and issue is reproduced.

Attached screencast for reference.

Issue is seen from M40 #40.0.2172.0 and is a non-regression issue.

Marking it as untraiged , for further inputs.

Thanks!
Components: -Blink Blink>Fullscreen

Comment 4 by e...@chromium.org, Feb 21 2017

Owner: foolip@chromium.org
Status: Available (was: Untriaged)

Comment 5 by foolip@chromium.org, Feb 23 2017

Blockedon: 240576
Labels: Hotlist-Interop
This, like so much else wrong with fullscreen, would be helped by fixing  issue 240576 . There's currently code in FullscreenController::didEnterFullscreen() which resets the page scale factor, scroll position, and viewport offset when entering fullscreen and code to restore it when exiting fullscreen.

Because <dialog> works even when the page is scrolled, I believe that once Fullscreen uses top layer, at least the scroll position bits could be removed. Therefore marked as blocked.

Adding Hotlist-Interop because "It works fine in Firefox and IE/Edge."
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 7 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by e...@chromium.org, Mar 7 2018

Cc: foolip@chromium.org
Owner: ----
Status: Available (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0de9638b5d008eb11b206187bf90a70bbf23857a

commit 0de9638b5d008eb11b206187bf90a70bbf23857a
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Aug 29 15:08:54 2018

Avoid scrolling when entering fullscreen

When entering fullscreen we shouldn't need to set scroll to 0,0. This
fixes fullscreening an element that has scroll offset.

BUG= 693075 , 684920 

Change-Id: I2acf27eb2641731d580865d38e1a1495f6aee7de
Reviewed-on: https://chromium-review.googlesource.com/1191664
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587120}
[add] https://crrev.com/0de9638b5d008eb11b206187bf90a70bbf23857a/third_party/WebKit/LayoutTests/external/wpt/fullscreen/rendering/fullscreen-root-block-scroll-manual.html
[modify] https://crrev.com/0de9638b5d008eb11b206187bf90a70bbf23857a/third_party/blink/renderer/core/frame/fullscreen_controller.cc

Owner: dtapu...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment