New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693065 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 669453



Sign in to add a comment

Test mark placement and variations

Project Member Reported by drott@chromium.org, Feb 16 2017

Issue description

As a TODO from  issue 674879 , we should add an automated test which checks for correct mark placement. Requires figuring out how to create a test font for this case.
 

Comment 1 by drott@chromium.org, Apr 28 2017

Cc: sascha@google.com behdad@chromium.org
Labels: -Pri-3 OS-All Pri-2
CL up https://codereview.chromium.org/2850743002

Project Member

Comment 2 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7

commit 0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7
Author: drott <drott@chromium.org>
Date: Mon May 01 03:44:53 2017

Test Variations GPOS mark to base placement

Add a reftest using an additional axis VM2B in the variabletest_box
font. The VM2B axis shifts the mark anchor to the left, leading to the
combining mark below box shifting right when the axis parameter is
adjusted from 0 to 1000. As the reference in the ref test, the font now
contains two additional glyphs N and O, which have fixed base anchors at
the middle and right position. A rendering of the M character showing
"m2b pos", followed by COMBINING SQUARE BELOW with VM2B 0, 500, 1000
applied must thus be equal to renderings of the N and O glyph with no
VM2B variation values applied.

BUG= 693065 
R=behdad, kojii

Review-Url: https://codereview.chromium.org/2850743002
Cr-Commit-Position: refs/heads/master@{#468276}

[add] https://crrev.com/0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7/third_party/WebKit/LayoutTests/fast/text/variable-fonts/variable-gpos-m2b-expected.html
[add] https://crrev.com/0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7/third_party/WebKit/LayoutTests/fast/text/variable-fonts/variable-gpos-m2b.html
[modify] https://crrev.com/0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7/third_party/WebKit/LayoutTests/http/tests/resources/variabletest_box.ttf

Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e84a36378d78316e10dd54398977d8f85a040a92

commit e84a36378d78316e10dd54398977d8f85a040a92
Author: suzyh <suzyh@chromium.org>
Date: Tue May 02 02:24:59 2017

Add failure expectation for variable-gpos-m2b.html

LayoutTests/fast/text/variable-fonts/variable-gpos-m2b.html
is failing on Mac.

TBR=drott@chromium.org
BUG= 693065 

Review-Url: https://codereview.chromium.org/2855803002
Cr-Commit-Position: refs/heads/master@{#468538}

[modify] https://crrev.com/e84a36378d78316e10dd54398977d8f85a040a92/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by drott@chromium.org, May 2 2017

Thank you for marking this and sending the link, suzyh@. I'll try to address this.

Comment 7 by drott@chromium.org, May 2 2017

Cc: drott@chromium.org
 Issue 717039  has been merged into this issue.

Comment 8 by drott@chromium.org, May 9 2017

Status: Fixed (was: Assigned)
Fixed in https://codereview.chromium.org/2858573002

Sign in to add a comment