Test mark placement and variations |
|
Issue descriptionAs a TODO from issue 674879 , we should add an automated test which checks for correct mark placement. Requires figuring out how to create a test font for this case.
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7 commit 0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7 Author: drott <drott@chromium.org> Date: Mon May 01 03:44:53 2017 Test Variations GPOS mark to base placement Add a reftest using an additional axis VM2B in the variabletest_box font. The VM2B axis shifts the mark anchor to the left, leading to the combining mark below box shifting right when the axis parameter is adjusted from 0 to 1000. As the reference in the ref test, the font now contains two additional glyphs N and O, which have fixed base anchors at the middle and right position. A rendering of the M character showing "m2b pos", followed by COMBINING SQUARE BELOW with VM2B 0, 500, 1000 applied must thus be equal to renderings of the N and O glyph with no VM2B variation values applied. BUG= 693065 R=behdad, kojii Review-Url: https://codereview.chromium.org/2850743002 Cr-Commit-Position: refs/heads/master@{#468276} [add] https://crrev.com/0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7/third_party/WebKit/LayoutTests/fast/text/variable-fonts/variable-gpos-m2b-expected.html [add] https://crrev.com/0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7/third_party/WebKit/LayoutTests/fast/text/variable-fonts/variable-gpos-m2b.html [modify] https://crrev.com/0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7/third_party/WebKit/LayoutTests/http/tests/resources/variabletest_box.ttf
,
May 2 2017
Sheriff here. This test appears to be failing on Mac 10.10 and 10.9: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ftext%2Fvariable-fonts%2Fvariable-gpos-m2b.html&testType=webkit_tests Adding failure expectation in https://codereview.chromium.org/2855803002
,
May 2 2017
Recent failure on Mac 10.9: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/45697 Direct link to diff in layout test results from the above: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9/45697/layout-test-results/fast/text/variable-fonts/variable-gpos-m2b-diffs.html
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e84a36378d78316e10dd54398977d8f85a040a92 commit e84a36378d78316e10dd54398977d8f85a040a92 Author: suzyh <suzyh@chromium.org> Date: Tue May 02 02:24:59 2017 Add failure expectation for variable-gpos-m2b.html LayoutTests/fast/text/variable-fonts/variable-gpos-m2b.html is failing on Mac. TBR=drott@chromium.org BUG= 693065 Review-Url: https://codereview.chromium.org/2855803002 Cr-Commit-Position: refs/heads/master@{#468538} [modify] https://crrev.com/e84a36378d78316e10dd54398977d8f85a040a92/third_party/WebKit/LayoutTests/TestExpectations
,
May 2 2017
Thank you for marking this and sending the link, suzyh@. I'll try to address this.
,
May 2 2017
,
May 9 2017
|
|
►
Sign in to add a comment |
|
Comment 1 by drott@chromium.org
, Apr 28 2017Labels: -Pri-3 OS-All Pri-2