New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 693061 link

Starred by 3 users
Status: WontFix
Owner:
█ lpromero@chromium.org
No longer actively working on Chrom...
Closed: Apr 2017
Cc:
justincohen@chromium.org
thakis@chromium.org
sdefresne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Make llvm-profdata and llvm-cov tools available for the current clang version

Project Member Reported by lpromero@chromium.org, Feb 16 2017 
llvm-profdata and llvm-cov are LLVM tools for code coverage.
Locally, I have them accessible via Xcode and `xcrun llvm-profdata` and `xcrun llvm-cov`, but they are dependent on the version of clang used to build the instrumented binary.

Since we ship our own build of clang, which is always forward Xcode's, the Xcode tool can never read the coverage profraw file.

To that end, I would like to have a way to get to a build of llvm-profdata and llvm-cov for the revision of clang used in Chromium. How can we make this available?

Comment 1 by thakis@chromium.org, Feb 21 2017 

The general bar we use for putting things directly into the clang zip (is.gd/chromeclang) that everyone (devs and bots) downloads during runhooks is "~everyone uses stuff in there". This won't be true for llvm-profdata and llvm-cov.

Another approach we've used to roll out things is to have the package script upload binaries that aren't used as heavily, or that are still in rollout, into a separate zip (e.g. https://cs.chromium.org/chromium/src/tools/clang/scripts/package.py?q=package.py+package:%5Echromium$&dr&l=293) and then have a separate opt-in script that pulls those additional binaries. Maybe that could work here?

Comment 2 by lpromero@chromium.org, Feb 21 2017 

I think that second approach makes much sense. The script can then be an action in GN that runs only when a particular args is set, do I understand correctly?

Comment 3 by lpromero@chromium.org, Apr 20 2017

Status: WontFix (was: Assigned)
Actually, Xcode's versions seem to work (at least for the time being) with our clang. Documentation at https://codereview.chromium.org/2789433004/.
►

Sign in to add a comment