Unnecessary casts in AudioManagerDeleter::operator() |
||
Issue descriptionThe code currently does a const_cast (ewwww), and then a static_cast<AudioManagerMac*>. The const cast is not needed, since delete works on const pointers, and the static_cast is not needed either, since the destructor is virtual so the correct one will be called either way. This also means that tests currently invokes undefined behavior when using ScopedAudioManagerPtr with an mock/fake AudioManager.
,
Feb 16 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 16 2017