New issue
Advanced search Search tips
Starred by 17 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 2
Type: Feature

Blocked on:
issue 69301

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Elide tab titles based on unique portion

Project Member Reported by pkasting@chromium.org, Jan 11 2011

Issue description

When we elide tab titles we should try and preserve the first unique portion rather than just the beginning.

For example, given the following four tabs:

Foofoo abcdef
Barbar abcdef
Barbar ghijkl
Barfoo abcdef

We should probably elide to:

Foofoo...
...abcdef...
...ghijkl...
...foo abc...

A couple notes:
* When two titles are exactly the same, we should elide as we do now.
* As tabs get small the cost of an extra ellipsis on the front end gets large.  Thus we probably need to fix  bug 69301  first.
* We might want to check similarity "word-at-a-time" instead of character-at-a-time, e.g. "Issues list" and " Issue 5 " should perhaps be considered completely distinct as opposed to being considered as starting with the same five characters.
* We'll need to test to ensure that the combination of favicon and this new form of eliding is still identifiable.
 
Labels: OS-All
Labels: Fixit
Status: Available
Labels: Feature-TabStrip

Comment 4 by mad@chromium.org, Feb 23 2011

Status: Assigned
I'll take a stab at this one...

Even though some cases may use fading as specified in related (blocking?)  issue 69301 , it is stated in there that we will most likely still need eliding in some cases, and the code to choose where to elide might actually also be used for "where to fade" too...

Comment 5 by mad@chromium.org, Feb 25 2011

Here's a first attempt, hidden behind a command line flag...

I didn't add the flag in the about:flags page yet, since I would also like to fix  Issue 58892  next, and I will add the flag there then...

Comment 6 by mad@chromium.org, Feb 25 2011

Oops, forgot to put the link to the CL:
http://codereview.chromium.org/6579050

Comment 7 by sky@chromium.org, Feb 25 2011

Really? This seems completely wonky to have tab titles change based upon whats in the tab strip! Sadly Nicholas agrees with Peter, so ignore my comment.

Comment 8 by mad@chromium.org, Feb 25 2011

This is why I hide it behind an experiment flag, so that we can try it out first...

I actually like the idea, it's pretty useful when you have a bunch of tabs opened on different bugs, you get the see the bug numbers instead of the Issue... :-)

Comment 9 by a...@chromium.org, Feb 25 2011

"* We might want to check similarity "word-at-a-time" instead of character-at-a-time, e.g. "Issues list" and "  Issue 5  " should perhaps be considered completely distinct as opposed to being considered as starting with the same five characters."

That's the problem I have with the example:

"Foofoo abcdef
Barfoo abcdef

We should probably elide to:

Foofoo...
...foo abc..."

That's not necessarily a valid thing to do for non-English languages. Think Devanagari, Arabic, and anything else that has ligatures and complex layout. Chopping out characters to leave half-words is bad. Plus, what does it mean with CJK languages?

Your "word-at-a-time" suggestion is better, but should be implemented as "linguistic unit at a time" for whatever that means in the used language.
@9: Luckily, the patch in comment 6 implements a version of "word at a time" eliding.  I left a comment there that looking for whitespace is not as good for detecting this as using ICU, which should be able to find "linguistic units".

Comment 11 by mad@chromium.org, Feb 25 2011

Yep, working on CR comments right now, and found the RuleBasedBreakIterator, which should provide us with proper word break in other languages...

Thanks!

BYE
MAD

Comment 12 by mad@chromium.org, Mar 11 2011

Status: Fixed
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 11 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=77860

------------------------------------------------------------------------
r77860 | mad@chromium.org | Fri Mar 11 13:12:18 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/text/text_elider_unittest.cc?r1=77860&r2=77859&pathrev=77860
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/text/text_elider.h?r1=77860&r2=77859&pathrev=77860
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/base_tab_strip.cc?r1=77860&r2=77859&pathrev=77860
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/base_tab_strip.h?r1=77860&r2=77859&pathrev=77860
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=77860&r2=77859&pathrev=77860
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/text/text_elider.cc?r1=77860&r2=77859&pathrev=77860
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/title_prefix_matcher_unittest.cc?r1=77860&r2=77859&pathrev=77860
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/tab_renderer_data.h?r1=77860&r2=77859&pathrev=77860
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/title_prefix_matcher.h?r1=77860&r2=77859&pathrev=77860
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/base_tab.cc?r1=77860&r2=77859&pathrev=77860
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=77860&r2=77859&pathrev=77860
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/tab_renderer_data.cc?r1=77860&r2=77859&pathrev=77860
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/title_prefix_matcher.cc?r1=77860&r2=77859&pathrev=77860

Elides the beginning of tab titles that have common prefixes. 

BUG= 69304 
TEST=Make sure the tab titles are displayed as spec'd, and that there isn't any performance issues.
 
Review URL: http://codereview.chromium.org/6579050
------------------------------------------------------------------------

Comment 14 by sail@chromium.org, Mar 11 2011

This change means that we should probably update the fade on Mac OS X to fade on either side of the tab title.

Comment 15 by mad@chromium.org, Mar 11 2011

Ho... I forgot to mention that is fixed only for Windows, so I guess I
should re-open the bug...

I always forget that some platforms don't use views... Very annoying... :-/

BYE
MAD

Comment 16 by mad@chromium.org, Mar 11 2011

Status: Assigned
Actually, this is only fixed for views platforms... Will need to fix on other platforms too... somehow...

Labels: -OS-All OS-Chrome OS-Linux OS-Mac
Status: Started
Could you please provide a option to turn off this new feature in chrome://settings
or in about:flags? (even a startup switch is welcome)

Remembering entire title of webpage is (usually) harder than remembering several words
of the first part of title of webpage.
So occasionally I have to do mouseover on tab to see tooltip containing full title.

Comment 19 by mad@chromium.org, Mar 14 2011

My initial fix was hidden behind a flag but pkasting@ suggested I remove it
and have it always on...

Peter, should I bring back the flag, but make it enabled by default?

BYE
MAD
This shouldn't have a flag long-term, and I don't think it should have a flag short-term either.

Satoshi.Matsuzaki, please provide sample cases where the new behavior is worse than the old and we'll look at whether we can do something better.  That is precisely the sort of feedback we want, which we hoped to get by turning this on by default.
I'm not sure the "don't elide left if less than 10 characters space" behavior is right.  It may need a different (or no) threshold.  I need to play with it.

I wrote a comment on sail's codereview for fading tab titles that relates to cases with long common prefixes and short distinct suffixes; you should take a look.
@20:
This is the case that I want to turn off the eliding of tilte.
Please see attachment, Chrome 10.0.648.133 vs Chromium Build 78289.

1.Search "SQLite" at Google, and open some result links in new tab.
2.Open new NTP and search "Tcl/Tk" at Google. Open some result links in new tab.
3.Back to 1st tab. Select "MySQL" on the page, right-click, then search in Google.
4.In the newly-opened tab, open some search result links in new tab.
5.Try to pick up tabs which related to SQLite.

This sample case may be extreme, but I experience similar situation occasionally.
Eliding_sample.png
28.3 KB View Download
Labels: -Fixit bulkmove TaskForce-Fixit
When we elide tab titles we should try and preserve the first unique portion rather than just the beginning.

For example, given the following four tabs:

Foofoo abcdef
Barbar abcdef
Barbar ghijkl
Barfoo abcdef

We should probably elide to:

Foofoo...
...abcdef...
...ghijkl...
...foo abc...

A couple notes:
* When two titles are exactly the same, we should elide as we do now.
* As tabs get small the cost of an extra ellipsis on the front end gets large.  Thus we probably need to fix  bug 69301  first.
* We might want to check similarity "word-at-a-time" instead of character-at-a-time, e.g. "Issues list" and " Issue 5 " should perhaps be considered completely distinct as opposed to being considered as starting with the same five characters.
* We'll need to test to ensure that the combination of favicon and this new form of eliding is still identifiable.

Comment 24 by sail@google.com, Mar 19 2011

Mac UI changes out for review:
http://codereview.chromium.org/6688050/
One thing I notice about comment 22 and my own experience is that we sometimes interpret punctuation as a good eliding location when it isn't.  For example, "3.141" or "Tcl/Tk" would ideally be considered single terms, but right now we're willing to elide at the punctuation mark.

I don't know how to fix this.  Maybe there are some flag tweaks that can be made to ICU, or we can add logic like "don't elide at punctuation without whitespace" (but I'm not sure that's sane for all languages).

Comment 26 by sky@chromium.org, Mar 25 2011

This comes up a lot for code reviews, eg foo.cc and foo.h. I don't want foo elided.
Project Member

Comment 27 by bugdroid1@chromium.org, Mar 30 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=79798

------------------------------------------------------------------------
r79798 | sail@chromium.org | Tue Mar 29 23:39:36 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller.mm?r1=79798&r2=79797&pathrev=79798
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller.h?r1=79798&r2=79797&pathrev=79798
 M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=79798&r2=79797&pathrev=79798
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=79798&r2=79797&pathrev=79798

Mac: Elides the beginning of tab titles that have common prefixes

This is just the Mac version of mad's change. See:
http://codereview.chromium.org/6579050/

I'm updating GTM with my change to fade the beginning of the text field:
http://code.google.com/p/google-toolbox-for-mac/source/detail?r=437

BUG= 69304 
TEST=Still testing.
Review URL: http://codereview.chromium.org/6688050
------------------------------------------------------------------------

Comment 28 by mad@chromium.org, May 26 2011

Status: WontFix
Obsolete, we decided to back off on this feature... :-(

Comment 29 by tvan...@gmail.com, Jun 4 2011

Since this issue is already closed, I am not sure this is the right place to post this, but I don't think a new issue should be opened either.

Is there any specific reason why you decided to remove this feature ? Although I never saw much feedback about it, I found it really useful for the short time it was available on the dev channel. At least, it worked perfectly when opening several pages from a single website; maybe it shouldn't have worked over several domains (for instance opening several results from a google search page could prove confusing at times).

Whatever the reasons for the removal of the features are, I'm certain there are still a lot of scenarios where it was beneficial to the user.

Since the code is already written, is there any way this could be added back as a flag ? As far as I know, there is no way to mimic this behaviour using extensions (more control over the UI in the extension tools would be another solution, of course).
We removed it because the UI devs and leads generally agreed that there were too many downsides to justify this, despite it being effective in some scenarios.

This will not be re-added under a flag.
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 13 2012

Blockedon: -chromium:69301 chromium:69301
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Area-UI -Feature-TabStrip Cr-UI-Browser-TabStrip Cr-UI

Sign in to add a comment