New issue
Advanced search Search tips

Issue 693031 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

User should be able to dismiss the suggestions

Project Member Reported by gambard@chromium.org, Feb 16 2017

Issue description

The user should be able to dismiss the suggestions when long pressing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0bce4262751f95ad57a02065b15ba4c561922b6

commit d0bce4262751f95ad57a02065b15ba4c561922b6
Author: gambard <gambard@chromium.org>
Date: Tue Feb 21 15:50:38 2017

Add an ID to the ContentSuggestion

This CL adds an ID for the ContentSuggestion, allowing them to be uniquely
identified.

BUG= 693031 

Review-Url: https://codereview.chromium.org/2708623002
Cr-Commit-Position: refs/heads/master@{#451768}

[modify] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/ui/content_suggestions/content_suggestion.h
[modify] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/ui/content_suggestions/content_suggestion.mm
[add] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/ui/content_suggestions/content_suggestion_identifier.h
[add] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/ui/content_suggestions/content_suggestion_identifier.mm
[add] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/ui/content_suggestions/content_suggestion_identifier_unittest.mm
[modify] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h
[modify] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm
[modify] https://crrev.com/d0bce4262751f95ad57a02065b15ba4c561922b6/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

Status: Fixed (was: Assigned)
Please can you provide test steps to verify the issue, Thanks.
This feature is not launched yet, it will be part of the test plan.

Sign in to add a comment