New issue
Advanced search Search tips

Issue 693019 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16.3%-36.4% regression in v8.browsing_desktop_ignition at 449546:449582

Project Member Reported by rmcilroy@chromium.org, Feb 16 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 16 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: win_8_perf_bisect
  Benchmark    : v8.browsing_desktop_ignition
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:code_and_metadata_size_max/browse_media/browse_media_pinterest

Revision             Result                   N
chromium@449545      11691981 +- 2853958      21      good
chromium@449570      11813029 +- 3440030      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.pinterest v8.browsing_desktop_ignition

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987504734994025216

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5327021548240896


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Feb 17 2017

Cc: csharrison@chromium.org
Owner: csharrison@chromium.org

=== Auto-CCing suspected CL author csharrison@chromium.org ===

Hi csharrison@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : csharrison
  Commit : 59f21d4daf6f2476c0b9f6d598fff241e04fa2fe
  Date   : Fri Feb 10 05:45:12 2017
  Subject: Remove resource_loader.cc ScopedTrackers

Bisect Details
  Configuration: win_x64_perf_bisect
  Benchmark    : v8.browsing_desktop_ignition
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:code_and_metadata_size_max/browse_media/browse_media_pinterest
  Change       : 4.41% | 15382560.7619 -> 16061490.8571

Revision             Result                   N
chromium@449546      15382561 +- 4645203      21      good
chromium@449551      15376130 +- 2021623      9       good
chromium@449552      15748023 +- 2333604      14      good
chromium@449553      16375117 +- 1834919      14      bad       <--
chromium@449560      16079134 +- 2793906      21      bad
chromium@449582      16061491 +- 2244068      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.pinterest v8.browsing_desktop_ignition

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987495654817029472

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5338552931450880


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: ----
Cannot be that CL, it just removes ScopedTracker instrumentation.
It's possible that that CL indirectly caused this apparent regression - if it made the resource loader slightly faster then maybe we pull in slightly more JS for this site during the time it's measured and we end up with more memory used for JS code. If so this is just a benchmark issue and we should wont-fix. I'll bisect once more to check.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Feb 17 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: win_8_perf_bisect
  Benchmark    : v8.browsing_desktop_ignition
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:code_and_metadata_size_max/browse_media/browse_media_pinterest

Revision             Result                   N
chromium@449545      11535816 +- 5623289      21      good
chromium@449570      11535911 +- 5114293      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.pinterest v8.browsing_desktop_ignition

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987417820812255504

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5318239883624448


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Untriaged)
Do you think the ScopedTrackers really cause enough overhead to change things? I thought it's essentially 2 TimeTicks::Now()s and a histogram bump.

Thanks for re-running the bisect.
Yeah it's unlikely unless the ScopedTrackers were really fine grained.

Sign in to add a comment