Issue metadata
Sign in to add a comment
|
16.3%-36.4% regression in v8.browsing_desktop_ignition at 449546:449582 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 16 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8987504734994025216
,
Feb 16 2017
=== BISECT JOB RESULTS === NO Perf regression found Bisect Details Configuration: win_8_perf_bisect Benchmark : v8.browsing_desktop_ignition Metric : memory:chrome:renderer_processes:reported_by_chrome:v8:code_and_metadata_size_max/browse_media/browse_media_pinterest Revision Result N chromium@449545 11691981 +- 2853958 21 good chromium@449570 11813029 +- 3440030 21 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.pinterest v8.browsing_desktop_ignition Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8987504734994025216 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5327021548240896 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 16 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8987495654817029472
,
Feb 17 2017
=== Auto-CCing suspected CL author csharrison@chromium.org === Hi csharrison@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : csharrison Commit : 59f21d4daf6f2476c0b9f6d598fff241e04fa2fe Date : Fri Feb 10 05:45:12 2017 Subject: Remove resource_loader.cc ScopedTrackers Bisect Details Configuration: win_x64_perf_bisect Benchmark : v8.browsing_desktop_ignition Metric : memory:chrome:renderer_processes:reported_by_chrome:code_and_metadata_size_max/browse_media/browse_media_pinterest Change : 4.41% | 15382560.7619 -> 16061490.8571 Revision Result N chromium@449546 15382561 +- 4645203 21 good chromium@449551 15376130 +- 2021623 9 good chromium@449552 15748023 +- 2333604 14 good chromium@449553 16375117 +- 1834919 14 bad <-- chromium@449560 16079134 +- 2793906 21 bad chromium@449582 16061491 +- 2244068 14 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.pinterest v8.browsing_desktop_ignition Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8987495654817029472 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5338552931450880 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 17 2017
Cannot be that CL, it just removes ScopedTracker instrumentation.
,
Feb 17 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8987417820812255504
,
Feb 17 2017
It's possible that that CL indirectly caused this apparent regression - if it made the resource loader slightly faster then maybe we pull in slightly more JS for this site during the time it's measured and we end up with more memory used for JS code. If so this is just a benchmark issue and we should wont-fix. I'll bisect once more to check.
,
Feb 17 2017
=== BISECT JOB RESULTS === NO Perf regression found Bisect Details Configuration: win_8_perf_bisect Benchmark : v8.browsing_desktop_ignition Metric : memory:chrome:renderer_processes:reported_by_chrome:code_and_metadata_size_max/browse_media/browse_media_pinterest Revision Result N chromium@449545 11535816 +- 5623289 21 good chromium@449570 11535911 +- 5114293 21 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.pinterest v8.browsing_desktop_ignition Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8987417820812255504 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5318239883624448 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 17 2017
,
Feb 17 2017
Do you think the ScopedTrackers really cause enough overhead to change things? I thought it's essentially 2 TimeTicks::Now()s and a histogram bump. Thanks for re-running the bisect.
,
Feb 17 2017
Yeah it's unlikely unless the ScopedTrackers were really fine grained.
,
Apr 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982620161657944544
,
Apr 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982620045769146560 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rmcilroy@chromium.org
, Feb 16 2017