New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 693010 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::NinePieceImageGrid::NinePieceImageGrid

Project Member Reported by ClusterFuzz, Feb 16 2017

Issue description

Cc: msrchandra@chromium.org
Components: Blink>Paint
Labels: Test-Predator-Correct-CLs M-58
Owner: le...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: leviw
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/9dbe383187aae9b2017bec82d9d5e715b157933a
Time: Sat Jan 30 06:15:00 2016
File NinePieceImageGrid.cpp is changed in this cl (and is part of stack frame #0, "blink::NinePieceImageGrid::NinePieceImageGrid")
Minimum distance from crash line to modified line: 48. (file: NinePieceImageGrid.cpp, crashed on: 63, modified: 15).

@leviw -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by pdr@chromium.org, Feb 16 2017

Owner: pdr@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c78072f8bfee9cf61c42f3385d1ff9d7dab22a6

commit 9c78072f8bfee9cf61c42f3385d1ff9d7dab22a6
Author: pdr <pdr@chromium.org>
Date: Sat Feb 18 19:04:59 2017

Use saturated arithmetic in NinePieceImageGrid to avoid overflow

This is a simple patch to avoid unnecessary overflow when adding
widths together.

BUG= 693010 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2705653004
Cr-Commit-Position: refs/heads/master@{#451485}

[modify] https://crrev.com/9c78072f8bfee9cf61c42f3385d1ff9d7dab22a6/third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp

Project Member

Comment 4 by ClusterFuzz, Feb 19 2017

ClusterFuzz has detected this issue as fixed in range 451479:451487.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6306195158859776

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::NinePieceImageGrid::NinePieceImageGrid
  blink::NinePieceImagePainter::paint
  blink::BoxPainter::paintNinePieceImage
  
Sanitizer: undefined (UBSAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=372506:372545
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=451479:451487

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95G9HIfLqqSP7Bc4mgmfl87MzCfDp2IeZ7O-_d03XHMuzZHb8ZpB-eTSTn0EbBCBUjhOUGXCLOPsRo5qZws0-UfQZ2CypXqYF8pbBsr8G_wXD3k0loMU-bKV_mXrtzdgaxTEGb6_R_Bt2C6MFbGtu9vjnT5Ryeg0KivImRWiOtWclyRSVvK6fQfg1H0uO3CriFjnGaL7V3PUopa7X8toU2UxpUojkg9R3yCRcy2llViVRP32LGoQfxVC-eBELoeTzV-DXWc_UQ5OHgbFH-_24EW43fB8cQ-3OMVf7Csd-B8Dln2EYZgcIxrTGzQY7VMIl-PbkEjYbiyhZriAxfMJRDRjb_l-SxktRkY8n6YJ2rx5VKQACKgadhyfy2bfcYfWqoYTdU0ghdhWNwu_l_wUAFlJmzKjw?testcase_id=6306195158859776


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Feb 19 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6306195158859776 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment