New issue
Advanced search Search tips

Issue 693000 link

Starred by 2 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Jan 7
Cc:
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

DevToolsUpdatesBrowserWindow is flaky on Chrome OS.

Project Member Reported by perkj@chromium.org, Feb 16 2017 
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:125: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:129: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:134: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:139: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:140: Failure
Value of: contents_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:144: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:145: Failure
Value of: contents_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:150: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:154: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:159: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:164: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:165: Failure
Value of: contents_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:169: Failure
Value of: devtools_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
../../chrome/browser/ui/views/frame/browser_view_browsertest.cc:170: Failure
Value of: contents_web_view()->bounds()
  Actual: 0,0 1100x679
Expected: full_bounds
Which is: 0,0 1100x692
[  FAILED  ] BrowserViewTest.DevToolsUpdatesBrowserWindow, where TypeParam =  and GetParam() =  (1857 ms)



See https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/33738

And build #33733

Comment 1 by perkj@chromium.org, Feb 16 2017

Owner: dgozman@chromium.org
dgozman@chromium.org - Can you please take a look or find appropriate owner?

Comment 2 by perkj@chromium.org, Feb 16 2017

Labels: -Pri-2 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2857e9d1e613b6d375ca72cf0241bd73a4f19b08

commit 2857e9d1e613b6d375ca72cf0241bd73a4f19b08
Author: perkj <perkj@chromium.org>
Date: Thu Feb 16 12:47:16 2017

Diable flaky BrowserViewTest.DevToolsUpdatesBrowserWindow on Chrome OS.

BUG= 693000 
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2703583002
Cr-Commit-Position: refs/heads/master@{#450941}

[modify] https://crrev.com/2857e9d1e613b6d375ca72cf0241bd73a4f19b08/chrome/browser/ui/views/frame/browser_view_browsertest.cc

Comment 4 by dgozman@chromium.org, Feb 16 2017

Cc: dgozman@chromium.org
Owner: msw@chromium.org
Status: Assigned (was: Untriaged)
Could this be caused by https://chromium.googlesource.com/chromium/src/+/0bc6a07e9b04a8885f9e206f035e7c2e011b132c?
Looks most promising from the first failed build: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/33654.

Comment 5 by msw@chromium.org, Feb 16 2017 

Yeah, it's quite possible that my CL introduced the flakiness here; I don't see earlier flakes:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserViewTest.DevToolsUpdatesBrowserWindow
Thanks for the temporary disabling on Chrome OS; I'll take a look and get it re-enabled there asap.

Comment 6 by dgozman@chromium.org, Sep 21 2017

Components: -Platform>DevTools Tests>Flaky

Comment 7 by est...@chromium.org, Nov 13

Owner: est...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/612f89137b9da881d5870ed35401bfb6c517c734

commit 612f89137b9da881d5870ed35401bfb6c517c734
Author: Evan Stade <estade@chromium.org>
Date: Tue Nov 13 21:56:12 2018

Re-enable DevToolsUpdatesBrowserWindow browser test.

Passes 50x locally in both classic Ash and single process Mash.

Bug:  693000 
Change-Id: Ibc950f812b6195258609ca5ea1838331bf82aae3
Reviewed-on: https://chromium-review.googlesource.com/c/1334328
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607755}
[modify] https://crrev.com/612f89137b9da881d5870ed35401bfb6c517c734/chrome/browser/ui/views/frame/browser_view_browsertest.cc

Comment 9 by est...@chromium.org, Jan 7

Status: Fixed (was: Started)
►

Sign in to add a comment