New issue
Advanced search Search tips

Issue 692998 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 7
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 655916



Sign in to add a comment

Have core/loader/private directory

Project Member Reported by toyoshim@chromium.org, Feb 16 2017

Issue description

To store files that are only used in core/loader, create core/loader/private directory and move such files under the directory.
 
Blocking: 655916
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/525f8d9f0d3fee803152c190c7c3f965e1ca96f9

commit 525f8d9f0d3fee803152c190c7c3f965e1ca96f9
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Feb 16 13:10:14 2017

core/loader: remove unused MockThreadableLoader

This file is not used any more.

BUG= 692998 

Review-Url: https://codereview.chromium.org/2703533002
Cr-Commit-Position: refs/heads/master@{#450943}

[delete] https://crrev.com/c84a352c73d0597256e30ec9caee64c8fd23ed3d/third_party/WebKit/Source/core/loader/MockThreadableLoader.h

Owner: toyoshim@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2141637b7eff02a6f694848826463bcb7bf63a91

commit 2141637b7eff02a6f694848826463bcb7bf63a91
Author: toyoshim <toyoshim@chromium.org>
Date: Mon Feb 20 07:43:16 2017

core/loader: create private directory to store private classes

To store classes that should not be used outside core/loader, create
private directory and store such files under the directory.

This is not a well-known convention in chromium or blink, and does not
enforce it unlike DEPS rule.

BUG= 692998 

Review-Url: https://codereview.chromium.org/2700073002
Cr-Commit-Position: refs/heads/master@{#451577}

[modify] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/BUILD.gn
[modify] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/HttpEquiv.cpp
[modify] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[rename] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/private/CrossOriginPreflightResultCache.cpp
[rename] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/private/CrossOriginPreflightResultCache.h
[rename] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/private/FrameClientHintsPreferencesContext.cpp
[rename] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/private/FrameClientHintsPreferencesContext.h
[rename] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/private/PrerenderHandle.cpp
[rename] https://crrev.com/2141637b7eff02a6f694848826463bcb7bf63a91/third_party/WebKit/Source/core/loader/private/PrerenderHandle.h

Status: Archived (was: Started)

Sign in to add a comment