New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692995 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 524758



Sign in to add a comment

LayoutTests fail to run on Windows swarming bots

Project Member Reported by tansell@chromium.org, Feb 16 2017

Issue description


https://chromium-swarm.appspot.com/task?id=345f3f0c592f3b10&refresh=10&show_raw=1

------------------------------------------------------
Collecting tests ...
Parsing expectations ...
Found 58891 tests; running 48873, skipping 10018.
Checking build ...

Ruby is not installed; can't generate pretty patches.

No httpd found. Cannot run http tests.
For complete Windows build requirements, please see:

    https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md
Build check failed

------------------------------------------------------


 
On the local run we get;

--------------

02:17:57.958 7060 
02:17:57.963 7060 Ruby is not installed; can't generate pretty patches.
02:17:57.963 7060 
02:17:58.090 7060 "C:\Program Files\Debugging Tools For Windows (x64)\cdb.exe -version" took 0.12s
02:17:58.161 7060 "E:\b\c\b\WebKit_Win___RandomOrder\src\third_party\apache-win32\bin\httpd.exe -v" took 0.07s
02:17:58.161 7060 Checking system dependencies ...
02:17:58.869 7060 "E:\b\c\b\WebKit_Win___RandomOrder\src\out\Release\content_shell.exe --check-layout-test-sys-deps" took 0.71s
02:17:58.871 7060 all ports are available
02:17:58.871 7060 Starting CrashService server, cmd="['E:\\b\\c\\b\\WebKit_Win___RandomOrder\\src\\out\\Release\\content_shell_crash_service.exe', '--dumps-dir=E:\\b\\c\\b\\WebKit_Win___RandomOrder\\src\\out\\Release\\crash-dumps', '--no-window']"
02:17:58.892 7060 CrashService successfully started (pid = 6548)
02:17:58.893 7060 Starting WPTServe ...
02:17:58.902 7060 all ports are available

--------------
I'm guessing we should add src/third_party/apache-win32 to the deps of LayoutTests on Windows.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/820f7df12cfab494d649d7e99d3a060d6b4e7c91

commit 820f7df12cfab494d649d7e99d3a060d6b4e7c91
Author: tansell <tansell@chromium.org>
Date: Thu Feb 16 13:59:15 2017

Add //third_party/apache-win32 as LayoutTest dep.

Apache is needed for Webkit LayoutTests and doesn't come with Windows.
Needs to be used from //third_party/apache-win32

BUG= 692995 

Review-Url: https://codereview.chromium.org/2703543002
Cr-Commit-Position: refs/heads/master@{#450951}

[modify] https://crrev.com/820f7df12cfab494d649d7e99d3a060d6b4e7c91/BUILD.gn

Status: Fixed (was: Unconfirmed)
This is working now.

Sign in to add a comment