Currently this is implemented in Java using FaviconHelper. The implementation should move into c++ to add support for iOS.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10004604d31dfc0134b334d946f7f62550b2b6da commit 10004604d31dfc0134b334d946f7f62550b2b6da Author: jkrcal <jkrcal@chromium.org> Date: Wed Mar 29 07:44:28 2017 [Content suggestions] Add an interface to fetch favicons This CL is a first step towards fetching publishers favicons in c++, using the new API function of LargeIconService. The purpose of this CL is to divide follow-up tasks into smaller chunks. In follow-up CLs, I will: - implement the actual functionality in ContentSuggestionsService, - create a trial feature to experiment with the new code path, - use the code on the Java side. BUG= 692975 Review-Url: https://codereview.chromium.org/2781583002 Cr-Commit-Position: refs/heads/master@{#460320} [modify] https://crrev.com/10004604d31dfc0134b334d946f7f62550b2b6da/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/10004604d31dfc0134b334d946f7f62550b2b6da/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java [modify] https://crrev.com/10004604d31dfc0134b334d946f7f62550b2b6da/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/10004604d31dfc0134b334d946f7f62550b2b6da/chrome/browser/android/ntp/ntp_snippets_bridge.h [modify] https://crrev.com/10004604d31dfc0134b334d946f7f62550b2b6da/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java [modify] https://crrev.com/10004604d31dfc0134b334d946f7f62550b2b6da/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/10004604d31dfc0134b334d946f7f62550b2b6da/components/ntp_snippets/content_suggestions_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af528b15fa5c278f063d7fbc5450ff187b8afdfb commit af528b15fa5c278f063d7fbc5450ff187b8afdfb Author: jkrcal <jkrcal@chromium.org> Date: Mon Apr 03 13:00:11 2017 [Remote suggestions] Fetch favicon via ContentSuggestionsService This CL follows up on 2781583002 and implements java code (behind a feature) that fetches publisher's icons via content suggestions service. BUG= 692975 Review-Url: https://codereview.chromium.org/2790703003 Cr-Commit-Position: refs/heads/master@{#461412} [modify] https://crrev.com/af528b15fa5c278f063d7fbc5450ff187b8afdfb/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java [modify] https://crrev.com/af528b15fa5c278f063d7fbc5450ff187b8afdfb/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java [modify] https://crrev.com/af528b15fa5c278f063d7fbc5450ff187b8afdfb/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b7e71f19b573ed109fba77b10271798b0ac91bb commit 7b7e71f19b573ed109fba77b10271798b0ac91bb Author: jkrcal <jkrcal@chromium.org> Date: Thu Apr 06 13:12:40 2017 [Content suggestions] Implement fetching publishers' favicons This CL implements fetching publisher's favicons using LargeIconService (it follows-up on CL 2781583002 that has only added the API function). BUG= 692975 Review-Url: https://codereview.chromium.org/2790743003 Cr-Commit-Position: refs/heads/master@{#462444} [modify] https://crrev.com/7b7e71f19b573ed109fba77b10271798b0ac91bb/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/7b7e71f19b573ed109fba77b10271798b0ac91bb/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/7b7e71f19b573ed109fba77b10271798b0ac91bb/components/ntp_snippets/DEPS [modify] https://crrev.com/7b7e71f19b573ed109fba77b10271798b0ac91bb/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/7b7e71f19b573ed109fba77b10271798b0ac91bb/components/ntp_snippets/content_suggestions_service.h [modify] https://crrev.com/7b7e71f19b573ed109fba77b10271798b0ac91bb/components/ntp_snippets/content_suggestions_service_unittest.cc [modify] https://crrev.com/7b7e71f19b573ed109fba77b10271798b0ac91bb/ios/chrome/browser/ntp_snippets/BUILD.gn [modify] https://crrev.com/7b7e71f19b573ed109fba77b10271798b0ac91bb/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95acdc5a58015c3aefac2f05af19717ba104cae3 commit 95acdc5a58015c3aefac2f05af19717ba104cae3 Author: jkrcal <jkrcal@chromium.org> Date: Fri May 19 15:34:54 2017 [Content suggestions favicons] Let the clients rescale the gfx::Image This CL improves quality of icons by letting clients (Android / iOS) resize the icons to desired size. The icons look much crisper than when resized by LargeIconService (that uses a crappy resampling technique). The CL polishes the code a bit so that there is only 1 call site for LargeIconService::GetLargeIconImageOrFallbackStyle(). BUG= 692975 Review-Url: https://codereview.chromium.org/2891103002 Cr-Commit-Position: refs/heads/master@{#473199} [modify] https://crrev.com/95acdc5a58015c3aefac2f05af19717ba104cae3/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/95acdc5a58015c3aefac2f05af19717ba104cae3/components/ntp_snippets/content_suggestions_service.h
Comment 1 by jkrcal@chromium.org
, Mar 27 2017