Regression: Iron icon is not visible on searchEngines subpage after entering Long name
Reported by
dmascare...@etouch.net,
Feb 16 2017
|
|||||
Issue descriptionChrome Version:58.0.3014.0 (Official Build) 6a7a139970ad3232c1efa03508df28b8a4883f1a-refs/heads/master@{#450840} OS: Mac(10.11.6, 10.12.1, 10.12), Windows(7,8,8.1,10), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/searchEngines 2. Click on ‘Add’ button under Other search engine and enter Long name in ‘Search engine, fill other field also. 3. Click on ‘Add’ button of overlay and observe. Actual: Iron icon is not seen. Expected: Iron icon should be seen. This is regression issue, broken in ‘M 58’ and below is manual bisect: Good build:58.0.3013.0 Bad build: 58.0.3014.0
,
Feb 16 2017
Using the per-revision bisect providing the bisect results, Good build: 58.0.3013.0 (Revision: 450530). Bad build: 58.0.3014.0 (Revision: 450840). You are probably looking for a change made after 450799 (known good), but no later than 450800 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/c30cc0c6a478e9471680ab1218c2d2a649d6cb25..13ff49ec46586eb4aa206226dcf3bef5cf02d5b4 From the CL above, assigning the issue to the concern owner @dpapad:Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2693253002 Note:Able to reproduce the issue in Win 10.0,Mac 10.12.3 and Ubuntu 14.04 and able to reproduce in latest canary #58.0.3014.0
,
Feb 16 2017
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da266d3e1f853cac8c2a766bb9b2ebfa0e7eaca3 commit da266d3e1f853cac8c2a766bb9b2ebfa0e7eaca3 Author: dpapad <dpapad@chromium.org> Date: Thu Feb 16 22:29:08 2017 MD Settings: Search engines: Fix long name breaking behavior. BUG= 692956 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2698613005 Cr-Commit-Position: refs/heads/master@{#451121} [modify] https://crrev.com/da266d3e1f853cac8c2a766bb9b2ebfa0e7eaca3/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
,
Feb 16 2017
,
Feb 21 2017
Tested the issue on Windows-7, Mac 10.12.2 and Linux Ubuntu-14.04 using Chrome version 58.0.3018.0 as per the comment #0. Observed that the fix is working as expected. Attaching the screen cast for reference. Hence, adding the verified labels. Thanks. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dmascare...@etouch.net
, Feb 16 201791.1 KB
91.1 KB View Download