New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692941 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 692944
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.2%-21.5% regression in system_health.memory_mobile at 450310:450398

Project Member Reported by alexclarke@chromium.org, Feb 16 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=692941

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguPCl8QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2NvbowkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2IXx4wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguLDJ6woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2L6t-QsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2JnprwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguJmjrAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2JDJnAgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguITP7wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2PfApQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2LORogsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2O28rwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguKSTqgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguMT7pAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguJTutAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguPqKtQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2K3esgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2KvluQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2M_DrAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2Pf5owkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2Ln4ogkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2L7m8QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2PWprAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguNDBuAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2N-HsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguILLrAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2LWL8QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2N2GpgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguMK9pgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2I-boAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2K20vAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguPzOtgsM


Bot(s) for this bug's original alert(s):

android-nexus5X
android-nexus7v2
android-webview-nexus5X
android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 16 2017

Cc: yosin@chromium.org
Owner: yosin@chromium.org

=== Auto-CCing suspected CL author yosin@chromium.org ===

Hi yosin@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : yosin
  Commit : d892f9592860691ae9a782c12260c94ed6bd1a63
  Date   : Tue Feb 14 15:56:00 2017
  Subject: Make FrameSelection to hold non-canonicalized DOM positions

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:skia:effective_size_avg/load_tools/load_tools_docs
  Change       : 21.48% | 326760.0 -> 396952.0

Revision             Result             N
chromium@450356      326760 +- 0.0      6      good
chromium@450367      326760 +- 0.0      6      good
chromium@450369      326760 +- 0.0      6      good
chromium@450370      396952 +- 0.0      6      bad       <--
chromium@450372      396952 +- 0.0      6      bad
chromium@450377      396952 +- 0.0      6      bad
chromium@450398      396952 +- 0.0      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.docs system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987514859232087280

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5049557735440384


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 4 by yosin@chromium.org, Feb 16 2017

Mergedinto: 692944
Status: Duplicate (was: Untriaged)
http://crrev.com/450370 was reverted.
Then reland as http://crrev.com/450280 

 Issue 692944  is filed against 450280.
Labels: Performance-Memory
Labels: -Performance-Memory

Sign in to add a comment