New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692940 link

Starred by 4 users
Status: Fixed
Owner:
█ mcgreevy@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
█ tansell@chromium.org
machenb...@chromium.org
█ jparent@chromium.org
rmis...@chromium.org
█ mcgreevy@chromium.org
dpranke@chromium.org
estaab@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on:
issue 732677
issue 748420
Blocking:
issue 598990



Sign in to add a comment

Deploy `isolate exparchive` everywhere, remove `isolate batcharchive` and clean up any transitional stuff.

Project Member Reported by tansell@chromium.org, Feb 16 2017 
Steps;

 a) Make sure that exparchive is faster than batcharchive in all cases.
 b) Switch everyone over to exparchive
 c) Remove batcharchive from recipies
 d) Remove batcharchive from the isolate binary.
 e) Rename exparchive to archive.

Comment 1 by tansell@chromium.org, Feb 16 2017 

Chromium Perf have been moved off for Mac+Win builders. Still yet to move on Linux.

Other people currently using isolate are;

 * skia
 * v8

I've reached out to both teams.

Comment 2 by tansell@chromium.org, Feb 16 2017

Blocking: 598990

Comment 3 by tansell@chromium.org, Feb 16 2017

Labels: -Restrict-View-Google

Comment 4 by martiniss@chromium.org, Feb 16 2017 

Perf is only on exparchive for mac builders. The Win builder is only the fyi perfbot. 

https://chromium-review.googlesource.com/444084 switches everything on chromium.perf onto exparchive.

Comment 6 by tansell@chromium.org, Mar 10 2017

Status: Assigned (was: Untriaged)

Comment 7 by iannucci@chromium.org, May 15 2017

Components: -Infra>Platform>Recipes
Labels: Pri-2 Type-Task
Removing recipes component as this is not a change against the recipe platform, but rather the swarming recipe module. Assigning tentative priority as well.

Comment 8 by tansell@chromium.org, Jun 7 2017

Cc: jparent@chromium.org tansell@chromium.org estaab@chromium.org
Owner: mcgreevy@chromium.org
McGreevy is looking into this and has been adding logging about archive / batcharchive / exparchive.

Comment 9 by mcgreevy@chromium.org, Jun 7 2017 

Issue 727985 has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6477127e502255f62cfa126990e23122335760b9

commit 6477127e502255f62cfa126990e23122335760b9
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Fri Jun 09 05:20:20 2017

isolate: Add support for percentage experiments for exparchive.

In  https://crbug.com/689735  the perfbots where converted whole sale to
use exparchive instead of batcharchive. This significantly improve
performance.

However, we are worried that exparchive might not be faster in *all*
cases, so we want to run an experiment with a percentage of runs on a
builder using exparchive rather than batcharchive.

BUG= 689735 , 692940 , 598990 

Change-Id: Id00f35567edcdc83c77a38c8d0f86e3da1096519
Reviewed-on: https://chromium-review.googlesource.com/526874
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Michael McGreevy <mcgreevy@chromium.org>

[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build8.json
[modify] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.py
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build7.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build3.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build1.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build10.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build6.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build4.json
[modify] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/chromium_tests/api.py
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build9.json
[modify] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/api.py
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build2.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build5.json

Comment 11 by mcgreevy@chromium.org, Jun 13 2017

Blockedon: 732677
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/69a3565e74d2187c337aada58f63427dbf48603b

commit 69a3565e74d2187c337aada58f63427dbf48603b
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Thu Jun 15 05:52:30 2017

linux_chromium_rel_ng: Enable exparchive for 5% of builds.

In  https://crbug.com/689735  the perfbots where converted whole sale to
use exparchive instead of batcharchive. This significantly improve
performance.

However, we are worried that exparchive might not be faster in *all*
cases, so we want to run an experiment with a percentage of runs on a
builder using exparchive rather than batcharchive.

BUG= 689735 , 692940 , 598990 

Change-Id: I2cbead4bbcb0c4f68b1ba111284b1521ff5d72fd
Reviewed-on: https://chromium-review.googlesource.com/532767
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/69a3565e74d2187c337aada58f63427dbf48603b/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py
[modify] https://crrev.com/69a3565e74d2187c337aada58f63427dbf48603b/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py
[modify] https://crrev.com/69a3565e74d2187c337aada58f63427dbf48603b/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.py
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9e07fb4aca7a75d0eb88722e9adb16228c859cd8

commit 9e07fb4aca7a75d0eb88722e9adb16228c859cd8
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Tue Jun 20 20:32:46 2017

Log usage of batcharchive.

Bug:692940
Change-Id: I84ea4859336847205c75fa286dd1bd66659dffa7
Reviewed-on: https://chromium-review.googlesource.com/541184
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>

[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch___debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_wrong_results.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390x___sim.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim___debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc___sim___beta_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mipsel___sim___stable_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/linux_tests.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build3.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac___debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_compile_without_patch_fails.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_avx2_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_linux_chromium_clobber_deterministic_fail.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic__dbg_.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac_GC_Stress.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mips64el___sim___beta_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390___sim___beta_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic__dbg__fail.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_gc_stress_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc64___sim.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic_fail.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Random_Deopt_Fuzzer___debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN___concurrent_marking.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic_fail.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___gyp.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel_positional_extra_flags.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_linux_chromium_clobber_deterministic.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390x___sim___stable_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___verify_csa.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch___debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_minimal_pass_continues.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc64___sim___stable_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build8.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_fail.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc64___sim___beta_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_verify_csa_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build4.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg_gerrit.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipe_modules/isolate/tests/isolate_tests.expected/basic.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_gerrit.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build2.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_dbg.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch___debug.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic__dbg_.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390x___sim___beta_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build1.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc___sim.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mipsel___sim___beta_branch.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-batch-bmiss.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel_gerrit.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_deterministic.json
[modify] https://crrev.com/9e07fb4aca7a75d0eb88722e9adb16228c859cd8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json
[modify] https://crrev.com/9
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d87f0aac88f098fa4a90ba7c8ac103867a7c4762

commit d87f0aac88f098fa4a90ba7c8ac103867a7c4762
Author: Ryan Tseng <hinoka@chromium.org>
Date: Tue Jun 20 21:25:08 2017

Revert "Log usage of batcharchive."

This reverts commit 9e07fb4aca7a75d0eb88722e9adb16228c859cd8.

Reason for revert: Breaks V8

Bug: 735204

Original change's description:
> Log usage of batcharchive.
> 
> Bug:692940
> Change-Id: I84ea4859336847205c75fa286dd1bd66659dffa7
> Reviewed-on: https://chromium-review.googlesource.com/541184
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>

TBR=dpranke@chromium.org,mcgreevy@chromium.org

Change-Id: Iec8056274333f11920c1cc36614c223a01ec9d64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  692940 
Reviewed-on: https://chromium-review.googlesource.com/540833
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch___debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_wrong_results.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390x___sim.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim___debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc___sim___beta_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mipsel___sim___stable_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/linux_tests.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build3.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac___debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_compile_without_patch_fails.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_avx2_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_linux_chromium_clobber_deterministic_fail.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic__dbg_.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac_GC_Stress.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mips64el___sim___beta_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390___sim___beta_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic__dbg__fail.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_gc_stress_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc64___sim.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic_fail.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Random_Deopt_Fuzzer___debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN___concurrent_marking.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic_fail.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___gyp.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel_positional_extra_flags.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_linux_chromium_clobber_deterministic.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390x___sim___stable_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___verify_csa.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch___debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_minimal_pass_continues.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc64___sim___stable_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build8.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_fail.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc64___sim___beta_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_verify_csa_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build4.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg_gerrit.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipe_modules/isolate/tests/isolate_tests.expected/basic.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_gerrit.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build2.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_dbg.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch___debug.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic__dbg_.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390x___sim___beta_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build1.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc___sim.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mipsel___sim___beta_branch.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-batch-bmiss.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/d87f0aac88f098fa4a90ba7c8ac103867a7c4762/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json
[modify] https://crrev.com/d87f0a
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 27 2017

Labels: merge-merged-6.0
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/90313abb037f079c5884cc9843be7433195c625a

commit 90313abb037f079c5884cc9843be7433195c625a
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Jun 27 07:07:33 2017

Merged: Roll v8 isolate binaries to match the chromium versions.

Revision: 25f86761e6c1db913d90d8e2fe321731601bef0d

R=mcgreevy@chromium.org
BUG= chromium:692940 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: If4d14db9e6d086d97782b9ecb4f2086a061cc9db
Reviewed-on: https://chromium-review.googlesource.com/549895
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.0@{#41}
Cr-Branched-From: 97dbf624a5eeffb3a8df36d24cdb2a883137385f-refs/heads/6.0.286@{#1}
Cr-Branched-From: 12e6f1cb5cd9616da7b9d4a7655c088778a6d415-refs/heads/master@{#45439}
[modify] https://crrev.com/90313abb037f079c5884cc9843be7433195c625a/tools/luci-go/linux64/isolate.sha1
[modify] https://crrev.com/90313abb037f079c5884cc9843be7433195c625a/tools/luci-go/mac64/isolate.sha1
[modify] https://crrev.com/90313abb037f079c5884cc9843be7433195c625a/tools/luci-go/win64/isolate.exe.sha1
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 27 2017

Labels: merge-merged-5.9
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/14a88cb979fcf684f81ea88d723865ca139da4f1

commit 14a88cb979fcf684f81ea88d723865ca139da4f1
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Jun 27 07:08:52 2017

Merged: Roll v8 isolate binaries to match the chromium versions.

Revision: 25f86761e6c1db913d90d8e2fe321731601bef0d

R=mcgreevy@chromium.org
BUG= chromium:692940 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I6a6f03026bf2e3a0ffebe9342bb3d4d480611d52
Reviewed-on: https://chromium-review.googlesource.com/549316
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/5.9@{#81}
Cr-Branched-From: fe9bb7e6e251159852770160cfb21dad3cf03523-refs/heads/5.9.211@{#1}
Cr-Branched-From: 70ad23791a21c0dd7ecef8d4d8dd30ff6fc291f6-refs/heads/master@{#44591}
[modify] https://crrev.com/14a88cb979fcf684f81ea88d723865ca139da4f1/tools/luci-go/linux64/isolate.sha1
[modify] https://crrev.com/14a88cb979fcf684f81ea88d723865ca139da4f1/tools/luci-go/mac64/isolate.sha1
[modify] https://crrev.com/14a88cb979fcf684f81ea88d723865ca139da4f1/tools/luci-go/win64/isolate.exe.sha1
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/c73a01793deb23192570c36c44c1a3978d4eb0db

commit c73a01793deb23192570c36c44c1a3978d4eb0db
Author: mcgreevy <mcgreevy@chromium.org>
Date: Tue Jul 18 03:53:15 2017

isolate: clean up some path handling in directory walking code.

BUG= 692940 

Review-Url: https://codereview.chromium.org/2980233003

[modify] https://crrev.com/c73a01793deb23192570c36c44c1a3978d4eb0db/client/archiver/directory.go

Comment 24 by machenb...@chromium.org, Jul 25 2017

Blockedon: 748420
Project Member

Comment 32 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/29440f13003b1bf3464be6e4d65904e9ff7ad251

commit 29440f13003b1bf3464be6e4d65904e9ff7ad251
Author: mcgreevy <mcgreevy@chromium.org>
Date: Thu Jul 27 07:04:53 2017

isolate: Move json dumping back into exparchive main

We will use one UploadTracker per isolate in batch mode, and the dumped json
will be based on the digests of multiple isolates. Therefore, json dumping
should happen at a higher level.

BUG= 692940 

Review-Url: https://codereview.chromium.org/2985203002

[modify] https://crrev.com/29440f13003b1bf3464be6e4d65904e9ff7ad251/client/cmd/isolate/exp_archive.go
[modify] https://crrev.com/29440f13003b1bf3464be6e4d65904e9ff7ad251/client/cmd/isolate/upload_tracker.go
Project Member

Comment 34 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/7981ab04f53fb3eb949c32f8eafbc077c15d66d5

commit 7981ab04f53fb3eb949c32f8eafbc077c15d66d5
Author: mcgreevy <mcgreevy@chromium.org>
Date: Tue Aug 01 04:02:07 2017

isolate: Move partitioning code out of exparchive main.

This is mostly just moving code, but the new String method for partitionedDeps
produces slightly different output to the old code which was in
expArchiveRun.main.

BUG= 692940 

Review-Url: https://codereview.chromium.org/2991083002

[modify] https://crrev.com/7981ab04f53fb3eb949c32f8eafbc077c15d66d5/client/cmd/isolate/exp_archive.go
[add] https://crrev.com/7981ab04f53fb3eb949c32f8eafbc077c15d66d5/client/cmd/isolate/tarring_archiver.go
Project Member

Comment 35 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/300d5a6b74053bed93529c62119d09516c14b447

commit 300d5a6b74053bed93529c62119d09516c14b447
Author: mcgreevy <mcgreevy@chromium.org>
Date: Tue Aug 01 04:41:58 2017

isolate: manage lifetime of checker and uploader in main.

It makes sense for the uploader and checker to be Closed in the same block of
code that they are created in. This will also make it possible to share Checker
and Uploaders between TarringArchivers.

BUG= 692940 

Review-Url: https://codereview.chromium.org/2988133002

[modify] https://crrev.com/300d5a6b74053bed93529c62119d09516c14b447/client/cmd/isolate/exp_archive.go
[modify] https://crrev.com/300d5a6b74053bed93529c62119d09516c14b447/client/cmd/isolate/upload_tracker.go
Project Member

Comment 38 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/d50a161479a764ec478a729b7b76fddca4a9f01c

commit d50a161479a764ec478a729b7b76fddca4a9f01c
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Tue Aug 22 05:45:04 2017

isolate: move logging into doExpArchive and doArchive

This reduces the amount of code which is specific to archiveRun.main vs
expArchiveRun.main. This means that once archiveRun.main starts
optionally calling doExpArchive based on a flag, there won't be a lot of
code which varies between the two branches.

This also has the effect of making the exparchive output more closely
match the archive output, and removing the need to pass "quiet" and
"start" into doArchive.

Bug:  692940 
Change-Id: Ibaf4afe09ab8cf9775c90a93c502b641a8bf40cc
Reviewed-on: https://chromium-review.googlesource.com/625497
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>

[modify] https://crrev.com/d50a161479a764ec478a729b7b76fddca4a9f01c/client/cmd/isolate/archive.go
[modify] https://crrev.com/d50a161479a764ec478a729b7b76fddca4a9f01c/client/cmd/isolate/exp_archive.go
Project Member

Comment 39 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/11b262d0954b422a6e7442be125f44cb5b3e6b71

commit 11b262d0954b422a6e7442be125f44cb5b3e6b71
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Mon Aug 28 22:49:09 2017

isolate: unify archive and exp_archive

Bug:  692940 
Change-Id: Iea04f369082d3c6b64a7affa1318ca38a8b666df
Reviewed-on: https://chromium-review.googlesource.com/634767
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>

[modify] https://crrev.com/11b262d0954b422a6e7442be125f44cb5b3e6b71/client/cmd/isolate/archive.go
[modify] https://crrev.com/11b262d0954b422a6e7442be125f44cb5b3e6b71/client/cmd/isolate/exp_archive.go
Project Member

Comment 40 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/8a06a7db5133d4a9c34bd9bf18c97927044b4df9

commit 8a06a7db5133d4a9c34bd9bf18c97927044b4df9
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Mon Aug 28 23:48:17 2017

Move batch archive code that uses archiver.Archiver to its own function.

Also, reuse some of the common logging code from archive/exparchive.

Bug:  692940 
Change-Id: I601aa78fa7b1dc9cef4d9be15c540ee97c146a99
Reviewed-on: https://chromium-review.googlesource.com/637295
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>

[modify] https://crrev.com/8a06a7db5133d4a9c34bd9bf18c97927044b4df9/client/cmd/isolate/archive.go
[modify] https://crrev.com/8a06a7db5133d4a9c34bd9bf18c97927044b4df9/client/cmd/isolate/batch_archive.go
Project Member

Comment 41 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/206868637637a0aba228c374ff376d22bf928108

commit 206868637637a0aba228c374ff376d22bf928108
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Mon Aug 28 23:56:27 2017

Add exparchive-based batcharchive implementation.

Bug:  692940 
Change-Id: I755bb2aa05b2f8fcd351e5dac034cc73e607eab4
Reviewed-on: https://chromium-review.googlesource.com/637470
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>

[modify] https://crrev.com/206868637637a0aba228c374ff376d22bf928108/client/cmd/isolate/batch_archive.go
[modify] https://crrev.com/206868637637a0aba228c374ff376d22bf928108/client/cmd/isolate/tarring_archiver.go

Comment 42 by tansell@chromium.org, Sep 14 2017

Cc: dpranke@chromium.org machenb...@chromium.org rmis...@chromium.org
We need to reach out to v8 and skia people to make sure they roll their binaries and are not getting a performance regression. It would be good to get them to test with the --exparchive to see if they get speed ups too.

I've asked dpranke@ to reach out to rmistry@ & machenbach@ and make sure they are in the loop / understand what is happening.

Comment 43 by machenb...@chromium.org, Sep 15 2017 

What do we need to do exactly? Roll luci-go? To what? Then just pass a flag to batcharchive?
Project Member

Comment 44 by bugdroid1@chromium.org, Oct 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/161457e1b7fdc151e796990913116ca78a37a756

commit 161457e1b7fdc151e796990913116ca78a37a756
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Wed Oct 04 06:56:07 2017

Roll isolate binaries to pick up new exparchive code.

Corresponds to infra/infra@7148c056fc1d31bf1e31868d628314e4d8f04e92

Built here:
https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-precise-64/9239
- ccdea1387f9f26c2572bf5f2b8d24e8d66a69cf6
https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-win-64/9422
- ded0dc9247e06fa42b653cce43f461f243ebea8b
https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-mac-10.10-64/8542
- 71329e82d274b847525f2b6345cb9fb6ddd0fff3

Bug:  692940 ,  524758 
Change-Id: Iba6e61e7a878408582258dad6438dd1de1f6aae4
TBR: dpranke@chromium.org,mcgreevy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/696886
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506324}
[modify] https://crrev.com/161457e1b7fdc151e796990913116ca78a37a756/tools/luci-go/linux64/isolate.sha1
[modify] https://crrev.com/161457e1b7fdc151e796990913116ca78a37a756/tools/luci-go/mac64/isolate.sha1
[modify] https://crrev.com/161457e1b7fdc151e796990913116ca78a37a756/tools/luci-go/win64/isolate.exe.sha1

Comment 46 by machenb...@chromium.org, Oct 5 2017 

Re 42: Where do we (V8) need to pass --exparchive?
Project Member

Comment 47 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/efd9e01aa5b966208fc4fa9e00c586788f487c43

commit efd9e01aa5b966208fc4fa9e00c586788f487c43
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Mon Oct 09 02:02:58 2017

isolate: Change the "always use exparchive" experiment.

The 10% experiment will now use exparchive via the batcharchive mode
rather than running every one separately.

TBR=dpranke@chromium.org,mcgreevy@chromium.org
BUG= 524758 , 692940 , 748420 

Change-Id: Idc39056ebce617dd7a74009bcf3567321d49b74b
Reviewed-on: https://chromium-review.googlesource.com/706737
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>

[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/examples/full.expected/always-use-exparchive.json
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/examples/full.py
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.py
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/README.recipes.md
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build10.json
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/api.py
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build5.json
Project Member

Comment 48 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e

commit 2fc0c38b744d771e51748db5c4da78a9bc8b7b7e
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Tue Dec 19 08:28:54 2017

isolate: use "archive --exparchive" instead of "exparchive"

Passing the --exparchive flag to the archive subcommand has the same
effect as running the exparchive subcommand.  Switching to
"archive --exparchive" will enable us to delete the exparchive subcommand
from the isolate binary.

Bug:  692940 
Change-Id: I8a9df3d843d198776be97a312d575768318b99c2
Reviewed-on: https://chromium-review.googlesource.com/832290
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>

[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/always-use-exparchive.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_that_fails.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build1.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build10.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-batch-emiss.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build8.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-batch-bmiss.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_win.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-batch.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-miss.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build7.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-multi.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_linux.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build6.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build3.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/README.recipes.md
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build4.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-multi-miss.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build2.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build9.json
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/api.py
[modify] https://crrev.com/2fc0c38b744d771e51748db5c4da78a9bc8b7b7e/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build5.json
Project Member

Comment 50 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/629227beadf6f353994d9dee19cac8e0904d86c8

commit 629227beadf6f353994d9dee19cac8e0904d86c8
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Tue Dec 19 23:36:08 2017

[isolate] Remove non-exparchive implementation of batcharchive.

Bug:  692940 
Change-Id: Ic538ecd2fca25e2306c750966dd8fb1511cd44bb
Reviewed-on: https://chromium-review.googlesource.com/832298
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>

[modify] https://crrev.com/629227beadf6f353994d9dee19cac8e0904d86c8/client/cmd/isolate/archive.go
[modify] https://crrev.com/629227beadf6f353994d9dee19cac8e0904d86c8/client/cmd/isolate/batch_archive.go
Project Member

Comment 51 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/727321325531a9db49a8d4a69cb5cfc9a66baf82

commit 727321325531a9db49a8d4a69cb5cfc9a66baf82
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Wed Dec 20 00:55:56 2017

Roll infra/go/src/go.chromium.org/luci (8 commits)

Created with:
  infra/roll-deps.py infra/go/src/go.chromium.org/luci

... snip ...

INFO:root:Rolling [infra/go/src/go.chromium.org/luci]: [9a5f23a0dbc5b43a8552fde85566918df725ed22] => [2de2bc8cd56658171af7cf072ef42d0f2abed1c9]

infra/go/src/go.chromium.org/luci:
2de2bc8c [milo] Remove unnecessary dispatch.yaml.
1ad55bf4 [prpc] log all errors
0000ed64 [milo] Simplify appengine services.
205c4605 [prpc] remove response.go
629227be [isolate] Remove non-exparchive implementation of batcharchive.
484ee2b5 [isolate] Remove old archive code path and exparchive subcommand
8ae12769 [Machine Database] Create operating systems config
a582360e [prpc] pass router.Context



Bug:  692940 
Change-Id: I9fa9a9f228c93885345dd1a358b3f4e22097ac84
Reviewed-on: https://chromium-review.googlesource.com/835448
Reviewed-by: Phil Wright <philwright@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>

[modify] https://crrev.com/727321325531a9db49a8d4a69cb5cfc9a66baf82/DEPS
Project Member

Comment 52 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c4b32dab8d35f022fc3bcf18940728cb0cdbed5a

commit c4b32dab8d35f022fc3bcf18940728cb0cdbed5a
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Wed Dec 20 05:16:55 2017

Roll infra/go/src/go.chromium.org/luci (3 commits)

Created with:
  infra/roll-deps.py infra/go/src/go.chromium.org/luci

... snip ...

INFO:root:Rolling [infra/go/src/go.chromium.org/luci]:
[2de2bc8cd56658171af7cf072ef42d0f2abed1c9] =>
[9375435d7aeacafdde6c0458fdb3652ea5f37f0b]

infra/go/src/go.chromium.org/luci:
9375435d Set the default for max-concurrent-uploads to 8, which has
performed well in prod.
2979c5bb [Machine Database] Create platforms config
fae82080 [Machine Database] Add command to retrieve switches

Roll infra/go/src/go.chromium.org/luci (8 commits)

Bug:  692940 
Change-Id: I457ee309f63adcb40edfc7bcf02ab1ace52eb020
Reviewed-on: https://chromium-review.googlesource.com/836027
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/c4b32dab8d35f022fc3bcf18940728cb0cdbed5a/DEPS
Project Member

Comment 53 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19e1245c649cb5ad35ec3d80c08e9d00c94514cf

commit 19e1245c649cb5ad35ec3d80c08e9d00c94514cf
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Wed Dec 20 16:56:25 2017

Roll isolate binaries generated at infra@c4b32da

Isolate sha1s were taken from the following builds:

https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-precise-64/10415
https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-mac-10.10-64/9839
https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-win-64/10696

This will pick up an isolate binary which the following changes:

* exparchive subcommand is removed,
* archive and batcharchive now ignore --exparchive (treating it as true). The
  old implementations for archive and batcharchive (i.e. those used
  when --exparchive=false) no longer exist.
* --max-concurrent-uploads defaults to 8.

Submitting this CL will have the effect of rolling out the exparchive-based
implementations everywhere.

Bug:  692940 
Change-Id: I01b57c4b00ec8f82c2b1c162782da497d40bb55c
Reviewed-on: https://chromium-review.googlesource.com/835769
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Michael McGreevy <mcgreevy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525352}
[modify] https://crrev.com/19e1245c649cb5ad35ec3d80c08e9d00c94514cf/tools/luci-go/linux64/isolate.sha1
[modify] https://crrev.com/19e1245c649cb5ad35ec3d80c08e9d00c94514cf/tools/luci-go/mac64/isolate.sha1
[modify] https://crrev.com/19e1245c649cb5ad35ec3d80c08e9d00c94514cf/tools/luci-go/win64/isolate.exe.sha1
Project Member

Comment 54 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf

commit 351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Wed Dec 20 21:06:41 2017

Remove exparchive flags from isolate recipe; they match the defaults.

The latest isolate binaries, being rolled out via https://crrev.com/c/835769,
contain only the "exparchive" codepath.  The legacy archive and batcharchive
implementations have been removed. The default for --max-concurrent-uploads has
also been set to 8 in the binary. Consequently, the recipe code that sets
exparchive-related flags is redundant. This CL removes that redunancy.

This CL should only submitted once
https://chromium-review.googlesource.com/c/chromium/src/+/835769 has landed.

Bug:  692940 
Change-Id: I8bbd0790c0463af3ff2a82f2c0c71c63c01a8537
Reviewed-on: https://chromium-review.googlesource.com/836230
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-miss.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-multi.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/always-use-exparchive.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build4.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build6.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build7.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build8.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-batch-bmiss.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build3.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/README.recipes.md
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build1.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build10.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-batch-emiss.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-multi-miss.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive-batch.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/exparchive.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build9.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/api.py
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build2.json
[modify] https://crrev.com/351ca5a7bed5325aeb49ea26f01d9eb2d5a746cf/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build5.json

Comment 55 by mcgreevy@chromium.org, May 4 2018

Status: Fixed (was: Assigned)
Closing because all of the infrastructural work here is done.

maruel has some followup performance work filed at https://crbug.com/799995 and https://crbug.com/800030 .

Comment 56 by machenb...@chromium.org, May 4 2018 

What about the layout test exparchive test target? Should it be cleaned up?
https://cs.chromium.org/search/?q=_exparchive&sq=package:chromium&type=cs

Comment 57 by dpranke@chromium.org, May 4 2018 

Yes, it should be, but mcgreevy@ is almost certainly not going to be the one to do that. We should file a new bug for the work.

Comment 58 by machenb...@chromium.org, May 7 2018 

Filed https://crbug.com/840252 for remaining clean-up.
►

Sign in to add a comment