New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692937 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.8%-9% regression in system_health.memory_mobile at 450326:450531

Project Member Reported by alexclarke@chromium.org, Feb 16 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 16 2017

Cc: yosin@chromium.org
Owner: yosin@chromium.org

=== Auto-CCing suspected CL author yosin@chromium.org ===

Hi yosin@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : yosin
  Commit : d892f9592860691ae9a782c12260c94ed6bd1a63
  Date   : Tue Feb 14 15:56:00 2017
  Subject: Make FrameSelection to hold non-canonicalized DOM positions

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/foreground/https_m_facebook_com_rihanna
  Change       : 8.98% | 282912.0 -> 308328.0

Revision             Result                 N
chromium@450325      282912 +- 0.0          6       good
chromium@450352      285736 +- 23962.4      9       good
chromium@450366      291989 +- 45566.9      14      good
chromium@450368      287148 +- 23201.5      6       good
chromium@450369      282912 +- 0.0          6       good
chromium@450370      308328 +- 0.0          9       bad       <--
chromium@450373      308328 +- 0.0          9       bad
chromium@450379      308328 +- 0.0          9       bad
chromium@450432      308328 +- 0.0          6       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987514922027241168

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5029424539369472


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 4 by yosin@chromium.org, Feb 17 2017

Status: Started (was: Untriaged)

Comment 5 by yosin@chromium.org, Feb 17 2017

Components: Blink>Editing>Selection

Comment 6 by yosin@chromium.org, Feb 17 2017

Labels: -Performance-Sheriff Performance-Memory
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Feb 18 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/browse_news/browse_news_reddit

Revision             Result                   N
chromium@451268      37819761 +- 1094119      21      good
chromium@451272      37871887 +- 850836       21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.reddit system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987322895952902368

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5287032785469440


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 9 by yosin@chromium.org, Mar 2 2017

Status: WontFix (was: Started)
Mark WontFix since r450370 is necessary change.

r450370 doesn't allocate memory but cache VisibleSelection. This cache may increase live nodes.

Sign in to add a comment