Issue metadata
Sign in to add a comment
|
23%-39.2% regression in page_cycler_v2.top_10_mobile at 450492:450544 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 16 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8987515104958081808
,
Feb 16 2017
=== Auto-CCing suspected CL author tbansal@chromium.org === Hi tbansal@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : tbansal Commit : 0be260cab40bb7162d01d99afb1144abdd2469c2 Date : Wed Feb 15 01:16:33 2017 Subject: NQE: Record the main frame metrics at transaction start Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : page_cycler_v2.top_10_mobile Metric : timeToFirstContentfulPaint_avg/pcv1-warm/http___m.intl.taobao.com_group-purchase.html Change : 42.86% | 149.437 -> 213.482666667 Revision Result N chromium@450491 149.437 +- 11.4836 6 good chromium@450518 143.391 +- 15.8056 6 good chromium@450531 152.796 +- 25.5314 9 good chromium@450535 143.585 +- 8.29484 6 good chromium@450536 209.46 +- 35.8453 6 bad <-- chromium@450537 220.268 +- 35.0917 6 bad chromium@450538 200.576 +- 75.7323 9 bad chromium@450544 213.483 +- 21.6972 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...m.intl.taobao.com.group.purchase.html page_cycler_v2.top_10_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8987515104958081808 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5826111981748224 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 16 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8987483542128938864
,
Feb 16 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : tbansal Commit : 0be260cab40bb7162d01d99afb1144abdd2469c2 Date : Wed Feb 15 01:16:33 2017 Subject: NQE: Record the main frame metrics at transaction start Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : page_cycler_v2.top_10_mobile Metric : timeToFirstContentfulPaint_avg/pcv1-warm/http___m.intl.taobao.com_group-purchase.html Change : 40.63% | 144.895833333 -> 203.7605 Revision Result N chromium@450491 144.896 +- 17.1899 6 good chromium@450518 157.67 +- 23.7266 6 good chromium@450531 142.297 +- 19.6971 6 good chromium@450535 153.675 +- 23.0925 6 good chromium@450536 206.418 +- 25.0452 6 bad <-- chromium@450537 215.803 +- 28.3821 6 bad chromium@450538 207.449 +- 14.4594 6 bad chromium@450544 203.76 +- 31.5393 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...m.intl.taobao.com.group.purchase.html page_cycler_v2.top_10_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8987483542128938864 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5275765341421568 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 16 2017
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c commit c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c Author: tbansal <tbansal@chromium.org> Date: Thu Feb 16 21:43:59 2017 Revert of NQE: Record the main frame metrics at transaction start (patchset #2 id:60001 of https://codereview.chromium.org/2695783003/ ) Reason for revert: Caused perf regression. See https://bugs.chromium.org/p/chromium/issues/detail?id=692933 Original issue's description: > NQE: Record the main frame metrics at transaction start > > In network quality estimator (NQE), record the main frame metrics at the > beginning of transaction start, instead of when the response headers have > been received for the main frame. > > BUG= 691798 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > Review-Url: https://codereview.chromium.org/2695783003 > Cr-Commit-Position: refs/heads/master@{#450536} > Committed: https://chromium.googlesource.com/chromium/src/+/0be260cab40bb7162d01d99afb1144abdd2469c2 TBR=ryansturm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 691798 , 692933 Review-Url: https://codereview.chromium.org/2690303011 Cr-Commit-Position: refs/heads/master@{#451106} [modify] https://crrev.com/c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c/net/nqe/network_quality_estimator.h [modify] https://crrev.com/c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c/net/nqe/network_quality_estimator_unittest.cc
,
Feb 17 2017
,
Feb 25 2017
,
Mar 14 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, Feb 16 2017