Issue metadata
Sign in to add a comment
|
13%-147.3% regression in page_cycler_v2.tough_layout_cases at 450530:450731 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 16 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8987515197310556912
,
Feb 16 2017
=== Auto-CCing suspected CL author perezju@chromium.org === Hi perezju@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : perezju Commit : fc25e6f948ca9973f27d812a8cc7086738b279a1 Date : Wed Feb 15 11:18:55 2017 Subject: Reland of [Telemetry] Switch clients to new JavaScript API (batch 5) (patchset #1 id:1 of https://codereview.chromium.org/2692763002/ ) Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : page_cycler_v2.intl_hi_ru Metric : timeToFirstContentfulPaint_avg/pcv1-warm/http___ru.wikipedia.org_ Change : 143.52% | 35.2106666667 -> 85.7465833333 Revision Result N chromium@450664 35.2107 +- 18.3099 6 good chromium@450670 30.3418 +- 5.68506 6 good chromium@450673 35.8035 +- 9.34391 6 good chromium@450673,catapult@fc25e6f948 85.1291 +- 9.98407 6 bad <-- chromium@450674 85.13 +- 8.84032 6 bad chromium@450675 80.1743 +- 9.92583 6 bad chromium@450676 83.6234 +- 13.6784 6 bad chromium@450688 85.7466 +- 15.3564 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...ru.wikipedia.org. page_cycler_v2.intl_hi_ru Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8987515197310556912 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5878559438012416 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 16 2017
Yep, confirmed this is me. I introduced a bug in that CL when placing the markers to find "warm" measurements. Uploading a fix now ...
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/820dcd54f703f06bb811f77d54797f645d7a3480 commit 820dcd54f703f06bb811f77d54797f645d7a3480 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu Feb 16 18:44:44 2017 Roll src/third_party/catapult/ 88e9135e3..d885da830 (2 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/88e9135e3e0a..d885da830d7a $ git log 88e9135e3..d885da830 --date=short --no-merges --format='%ad %ae %s' 2017-02-16 mythria Adds UE histograms as a diagnostics to the total histogram in runtimeStatsTotalMetric. 2017-02-16 perezju [Telemetry] Fix bug in markers for cache temperature Created with: roll-dep src/third_party/catapult BUG= 686250 , 692929 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2695713013 Cr-Commit-Position: refs/heads/master@{#451023} [modify] https://crrev.com/820dcd54f703f06bb811f77d54797f645d7a3480/DEPS
,
Feb 20 2017
Confirmed graphs returned to their baseline
,
Mar 14 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, Feb 16 2017