Make it easier to run http / wpt tests manually (run server commands should print port numbers) |
||||
Issue descriptionI've had a number of issues with running http / wtp tests that I think could be improved by adding an info block to the helper scripts. A few weeks ago, I was trying to debug a wpt test but had no idea how to run it manually. It turns out we have something called run-blink-wptserve, but since I've never used it before, I don't know how http urls map to actual test cases. Today, I was manually running a http test and trying to figure out why it wasn't failing. It turns out I was using the wrong port #, so all the accesses that should have been cross-origin ended up being same-origin... 1) run-blink-httpd should say what ports it is listening on, and provide an example command line (so people know how the http URL maps to the http/tests directory). 2) run-blink-wptserve should do the same.
,
Feb 22 2017
Hm, I just realized after looking at that link that the run-blink-* scripts actually do print port numbers when run with -v. So the main change to be made here (I think) is to add docstrings and provide example URLs to demonstrate how URLs map to the local directories.
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c3d3754fd0305eb1c9f092efc7ce49fa76d8630 commit 2c3d3754fd0305eb1c9f092efc7ce49fa76d8630 Author: qyearsley <qyearsley@chromium.org> Date: Mon Feb 27 15:37:17 2017 Add descriptions with examples to run-blink-* scripts. This change adds docstrings to these scripts, and prints out these docstrings as description messages when -h is passed. BUG= 692926 Review-Url: https://codereview.chromium.org/2719633002 Cr-Commit-Position: refs/heads/master@{#453217} [modify] https://crrev.com/2c3d3754fd0305eb1c9f092efc7ce49fa76d8630/third_party/WebKit/Tools/Scripts/run-blink-httpd [modify] https://crrev.com/2c3d3754fd0305eb1c9f092efc7ce49fa76d8630/third_party/WebKit/Tools/Scripts/run-blink-websocketserver [modify] https://crrev.com/2c3d3754fd0305eb1c9f092efc7ce49fa76d8630/third_party/WebKit/Tools/Scripts/run-blink-wptserve [modify] https://crrev.com/2c3d3754fd0305eb1c9f092efc7ce49fa76d8630/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper.py [modify] https://crrev.com/2c3d3754fd0305eb1c9f092efc7ce49fa76d8630/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper_unittest.py
,
Feb 27 2017
Should this be considered "fixed", or is there some other change that would make this easier? The run-blink-* scripts do print port numbers if -v is passed, but not by default. Maybe they should print port numbers by default?
,
Feb 27 2017
,
Aug 7 2017
I'm going to answer my question from February, and say that I'd prefer that they log out port numbers by default.
,
Aug 14 2017
Looked at it again, and saw that the same code used to start the servers in the run-blink-* commands is used in run-webkit-tests, where we don't necessarily care about port numbers. Currently status is: Those server commands take --help/-h and --verbose/-v which give you more help, but are still quiet if you don't pass any args.
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70b4bd35bef3a4d28feae1419d86908dfb079cdb commit 70b4bd35bef3a4d28feae1419d86908dfb079cdb Author: Takeshi Yoshino <tyoshino@chromium.org> Date: Thu Dec 07 05:24:45 2017 Fix the description argument in run-blink-websocketserver Bug: 692926 Change-Id: Iacd04725bfbc2f0beff5bd87b9061d4ba369d6e2 Reviewed-on: https://chromium-review.googlesource.com/807864 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#522348} [modify] https://crrev.com/70b4bd35bef3a4d28feae1419d86908dfb079cdb/third_party/WebKit/Tools/Scripts/run-blink-websocketserver |
||||
►
Sign in to add a comment |
||||
Comment 1 by qyears...@chromium.org
, Feb 20 2017Labels: Documentation
Status: Available (was: Untriaged)