New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692916 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary long name text gets wrapped after make it Default search engine

Reported by dmascare...@etouch.net, Feb 16 2017

Issue description

Chrome Version:58.0.3014.0 (Official Build) 6a7a139970ad3232c1efa03508df28b8a4883f1a-refs/heads/master@{#450840}
OS: Mac(10.11.6, 10.12.1, 10.12), Windows(7,8,8.1,10), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/searchEngines
2. Make ‘Yahoo India’ as default search engine and observe.

Actual: Unnecessary long name text gets wrapped after make it Default search engine
Expected: Text should not get wrapped.

This is regression issue, broken in ‘M 58’ and below is manual bisect:
Good build:58.0.3013.0 
Bad build: 58.0.3014.0 

 
Search.png
71.8 KB View Download
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build -- 58.0.3013.0 (revision : 450530)
Bad Build  -- 58.0.3014.0 (revision : 450840)

You are probably looking for a change made after 450799 (known good), but no later than 450800 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/c30cc0c6a478e9471680ab1218c2d2a649d6cb25..13ff49ec46586eb4aa206226dcf3bef5cf02d5b4

@dpapad -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/876cafa176fb331cd498c895d6ccbb15f206eb04

commit 876cafa176fb331cd498c895d6ccbb15f206eb04
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 17 02:29:47 2017

MD Settings: Increase content width from 640px to 680px.

BUG= 684153 , 692916 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2697193005
Cr-Commit-Position: refs/heads/master@{#451190}

[modify] https://crrev.com/876cafa176fb331cd498c895d6ccbb15f206eb04/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/876cafa176fb331cd498c895d6ccbb15f206eb04/chrome/browser/resources/settings/settings_vars_css.html

Comment 3 by dpa...@chromium.org, Feb 17 2017

Status: Fixed (was: Assigned)
Labels: TE-Verified-M58 TE-Verified-58.0.3018.0
Tested the issue on Windows-7, Mac 10.12.2 and Linux Ubuntu-14.04 using Chrome version 58.0.3018.0 as per the comment #0.

Observed that the fix is working as expected.

Attaching the screen cast for reference.

Hence, adding the verified labels.

Thanks.
692916.mp4
345 KB View Download

Sign in to add a comment