New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692908 link

Starred by 2 users
Status: Archived
Owner:
osh...@chromium.org
Closed: Feb 2017
Cc:
█ yorkelee@chromium.org
█ skuhne@chromium.org
█ lpique@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

WorkspaceMetrics change when exiting tablet mode is not atomic

Project Member Reported by osh...@chromium.org, Feb 16 2017 
I just noticed that we first update the display change then sends tablet mode change, which can confuse the android/arc++ side.

This is chrome side issue, and I will work on fix.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8144c4a6052a4709e78b52c777d5e79f5616a26a

commit 8144c4a6052a4709e78b52c777d5e79f5616a26a
Author: oshima <oshima@chromium.org>
Date: Wed Feb 22 01:31:25 2017

Update the layout mode first when exiting tablet mode so that
exo's wayland server can update the display and desktop mode atomically.

BUG= 692908 
TEST=Manual

Review-Url: https://codereview.chromium.org/2704173002
Cr-Commit-Position: refs/heads/master@{#451875}

[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/ash/common/shell_observer.h
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/ash/common/wm/maximize_mode/maximize_mode_controller.cc
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/ash/common/wm_shell.cc
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/ash/common/wm_shell.h
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/components/exo/keyboard.cc
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/components/exo/keyboard.h
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/components/exo/wayland/server.cc
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/components/exo/wm_helper.cc
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/components/exo/wm_helper.h
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/components/exo/wm_helper_ash.cc
[modify] https://crrev.com/8144c4a6052a4709e78b52c777d5e79f5616a26a/components/exo/wm_helper_ash.h

Comment 2 by osh...@chromium.org, Feb 22 2017

Labels: Merge-Request-57
we need this for N-ARC.

Comment 3 by osh...@chromium.org, Feb 22 2017

Labels: -ReleaseBlock-Stable -M-57 -Merge-Request-57 M-58
Status: Fixed (was: Started)
turns out it's punted. removing 57 labels.

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment