Caret stops blinking after typing character
Reported by
jshan...@etouch.net,
Feb 16 2017
|
|||||||
Issue descriptionChrome Version: 58.0.3014.0 (Official Build) 6a7a139970ad3232c1efa03508df28b8a4883f1a-refs/heads/master@{#450840}-32/64 bit OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) Steps: 1. Launch Chrome and sign in to fb.com with valid credentials 2. Write something in 'Status' text box,then clear it using Backspace key and observe the cursor Actual: Cursor gets stuck after hitting Backspace key i.e cursor does not blinks Expected: Cursor should not be stuck after hitting Backspace key This is regression issue, broken in ‘M 58’ and will soon update other info : Good build:58.0.3012.0 Bad build: 58.0.3013.0 Note: Above issue is seen for most of the textboxes e.g Description box of crbug.com
,
Feb 16 2017
Step to reproduce: 1. Visit http://textarea.org 2. See the page, caret is blinking 3. Type "x" or whatever key
,
Feb 16 2017
Issue 692989 has been merged into this issue.
,
Feb 22 2017
The root cause is we stop caret blink timer when last editing command is typing in FrameCaret::updateApperance(). Before patch[1], updateApperance() is called when selection is moved. But after patch[1], we call updateApperance() before painting caret.
,
Feb 27 2017
Able to reproduce this issue on Mac 10.12.3 with chrome dev #58.0.3024.0, yosin@ since it has a release block-stable label , could you please provide the latest update on this issue.
,
Feb 28 2017
,
Mar 1 2017
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/045a3dd143fabf6787774090a255dc0eda649c59 commit 045a3dd143fabf6787774090a255dc0eda649c59 Author: tkent <tkent@chromium.org> Date: Wed Mar 01 05:55:00 2017 Editing: Fix caret blinking after a typing. FrameCaret::updateAppearance() is called in updateStyleAndLayoutIfNeeded(). So if shouldStopBlinkingDueToTypingCommand() is true, we repeatedly stop and start the caret timer. Because FrameSelection::didSetSelectionDeprecated() calls stopCaretBlinkTimer(), we always restart the caret timer after every selection change. Checking shouldStopBlinkingDueToTypingCommand() is unnecessary. The core part of the CL is just to remove shouldStopBlinkingDueToTypingCommand(), however this CL adds a lot of code to make the code testable. - Add FrameCaret::recreateCaretBlinkTimerForTesting(RefPtr<WebTaskRunner>) - Add FrameSelection::frameCaretForTesting() - Add support of delayed task to FakeWebTaskRunner BUG= 692900 Review-Url: https://codereview.chromium.org/2723003002 Cr-Commit-Position: refs/heads/master@{#453858} [modify] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/core/editing/FrameCaret.cpp [modify] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/core/editing/FrameCaret.h [add] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/core/editing/FrameCaretTest.cpp [modify] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/core/editing/FrameSelection.h [modify] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h [modify] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/core/editing/commands/TypingCommand.h [modify] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/platform/WebTaskRunnerTest.cpp [modify] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/platform/scheduler/test/fake_web_task_runner.cc [modify] https://crrev.com/045a3dd143fabf6787774090a255dc0eda649c59/third_party/WebKit/Source/platform/scheduler/test/fake_web_task_runner.h
,
Mar 1 2017
,
Mar 2 2017
Issue 696018 has been merged into this issue.
,
Mar 7 2017
Tested the issue on Latest Dev# 58.0.3029.6 on Windows, Mac and Linux and found the issue to be Fixed. Blinking doesn't stop on hitting backspace. Hence adding TE-Verified Labels. Attaching Screencast for reference. Thank You. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by msrchandra@chromium.org
, Feb 16 2017Owner: yosin@chromium.org
Status: Assigned (was: Unconfirmed)