MacViews: Bubbles are not dismissed on a right-click
Reported by
rk...@etouch.net,
Feb 16 2017
|
|||||||||
Issue descriptionChrome Version: 58.0.3013.0 Revision 1645e63d771e2ee049d465ce70bca163fd9f5bcc-refs/heads/master@{#450530} OS: Mac OS X(10.10.5, 10.11.4) Precondition: Enable 'Material Design in the rest of the browser's native UI' flag from chrome://flags What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://flags, click on omnibox(URL get selected) (2) Then click on 'View site info' icon, right click on chrome://flags url and select 'Cut' option. (3) Observe. Actual: 'View site info' bubble stays even if Omnibox url get cleared. Expected: 'View site info' bubble should not stays after clearing Omnibox url. This is a regression issue, broken in 'M-57', will soon update the other info: Good Build: 57.0.2938.0 Bad Build: 57.0.2939.0 Note: Issue is not seen on Windows and Linux OS.
,
Feb 16 2017
Not a regression, since it needs an off-by-default flag, but there's a more general problem to address -- thanks for highlighting this!
,
Feb 16 2017
,
Feb 23 2017
Friendly ping!! Still we are able to reproduce the issue on latets Canary-58.0.3020.0. tapted@Could you please look into this and update the thread. Thank you.
,
Feb 24 2017
There's no need to ping. This is not a regression. The blocked bug - Issue 603386 has all the work items for this feature. There are a lot.
,
Apr 12 2017
tapted@: I'm throwing this back into the Available pool for now. Feel free to grab it back if you want it.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff2295245893a5d48639681a2e8c344fba17ce24 commit ff2295245893a5d48639681a2e8c344fba17ce24 Author: jongkwon.lee <jongkwon.lee@navercorp.com> Date: Tue Aug 29 20:53:47 2017 Dismiss bubbles on right mouse down BridgedNativeWidget monitors right mouse down events if it is of TYPE_BUBBLE and closes itself if necessary. The bubble is not closed if the events come from the bubble or its child window. Bug: 692896 Change-Id: I0d06cf2fb6f3c586a3943a7a60a3825cd48bb74e Reviewed-on: https://chromium-review.googlesource.com/627525 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#498221} [modify] https://crrev.com/ff2295245893a5d48639681a2e8c344fba17ce24/ui/views/cocoa/bridged_native_widget.h [modify] https://crrev.com/ff2295245893a5d48639681a2e8c344fba17ce24/ui/views/cocoa/bridged_native_widget.mm [modify] https://crrev.com/ff2295245893a5d48639681a2e8c344fba17ce24/ui/views/widget/native_widget_mac_interactive_uitest.mm
,
Aug 30 2017
Thanks for the patch! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by msrchandra@chromium.org
, Feb 16 2017Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)