New issue
Advanced search Search tips

Issue 692881 link

Starred by 4 users
Status: Fixed
Owner:
tkent@chromium.org
Closed: Feb 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 391673



Sign in to add a comment

Should add 'removeRange()' to Selection interface

Project Member Reported by tkent@chromium.org, Feb 16 2017 
Chrome Version: ToT
OS: All

What steps will reproduce the problem?
(1) Open any page, and open DevTools console
(2) Run the following code:

getSelection().selectAllChildren(document);
getSelection().removeRange(getSelection().getRangeAt(0));

What is the expected result?
It finishes without any exceptions.

What happens instead?
> Uncaught TypeError: getSelection(...).removeRange is not a function

Firefox and Edge have it.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 2 by yio...@gmail.com, Feb 17 2017 

Does Chrome intend to support multiple Selections?

Comment 3 by tkent@chromium.org, Feb 17 2017 

> Does Chrome intend to support multiple Selections?

yes, but it won't be available in one year.
Adding removeRange() is not much related to multiple selection support.

Comment 4 by tkent@chromium.org, Feb 24 2017

Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e54bc779bf060c6704d4a581ee7137bb268c6b7c

commit e54bc779bf060c6704d4a581ee7137bb268c6b7c
Author: tkent <tkent@chromium.org>
Date: Fri Feb 24 22:41:34 2017

Selection API: add removeRange().

Approved Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OnBuqLuHLeI

This CL adds selection/removeRange.html to web-platform-tests.

BUG= 692881 

Review-Url: https://codereview.chromium.org/2710593009
Cr-Commit-Position: refs/heads/master@{#452965}

[modify] https://crrev.com/e54bc779bf060c6704d4a581ee7137bb268c6b7c/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
[modify] https://crrev.com/e54bc779bf060c6704d4a581ee7137bb268c6b7c/third_party/WebKit/LayoutTests/external/wpt/selection/interfaces-expected.txt
[add] https://crrev.com/e54bc779bf060c6704d4a581ee7137bb268c6b7c/third_party/WebKit/LayoutTests/external/wpt/selection/removeRange.html
[modify] https://crrev.com/e54bc779bf060c6704d4a581ee7137bb268c6b7c/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e54bc779bf060c6704d4a581ee7137bb268c6b7c/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e54bc779bf060c6704d4a581ee7137bb268c6b7c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e54bc779bf060c6704d4a581ee7137bb268c6b7c/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/e54bc779bf060c6704d4a581ee7137bb268c6b7c/third_party/WebKit/Source/core/editing/DOMSelection.h
[modify] https://crrev.com/e54bc779bf060c6704d4a581ee7137bb268c6b7c/third_party/WebKit/Source/core/editing/Selection.idl

Comment 6 by tkent@chromium.org, Feb 26 2017

Labels: M-58
Status: Fixed (was: Started)
►

Sign in to add a comment