New issue
Advanced search Search tips

Issue 692864 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

"SitePerProcessBrowserTest.OriginReplication" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 16 2017

Issue description

"SitePerProcessBrowserTest.OriginReplication" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitTaXRlUGVyUHJvY2Vzc0Jyb3dzZXJUZXN0Lk9yaWdpblJlcGxpY2F0aW9uDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by mgiuca@chromium.org, Feb 16 2017

Cc: dtapu...@chromium.org
Components: Blink>Input
Labels: OS-Windows
Owner: nzolghadr@chromium.org
Status: Assigned (was: Untriaged)
I don't know SitePerProcessBrowserTest.OriginReplication test has to do with PointerEventFactory, but this looks like a problem with mouse pointer events (not origin replication).

From
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/383694/steps/content_browsertests%20%28with%20patch%29/logs/SitePerProcessBrowserTest.OriginReplication

[2884:4724:0215/172318.833:28433927:FATAL:pointereventfactory.cpp(276)] Check failed: mouseEvent.id == coalescedMouseEvent.id (2147483647 vs. 0)
Backtrace:
	base::debug::StackTrace::StackTrace [0x023E9907+55]
	base::debug::StackTrace::StackTrace [0x0240FFAA+10]
	blink::PointerEventFactory::create [0x0337CA69+552]
	blink::PointerEventManager::sendMousePointerEvent [0x034BF190+40]
	blink::EventHandler::updatePointerTargetAndDispatchEvents [0x034B71C8+143]
	blink::EventHandler::handleMouseMoveOrLeaveEvent [0x034B37D4+1013]
	blink::EventHandler::handleMouseMoveEvent [0x034B3363+129]
	blink::PageWidgetEventHandler::handleMouseMove [0x03035170+68]
	blink::PageWidgetDelegate::handleInputEvent [0x03034FEF+457]
	blink::WebFrameWidgetImpl::handleInputEvent [0x0301F7A0+879]
	content::RenderWidgetInputHandler::HandleInputEvent [0x02E57251+1023]
	content::RenderWidget::OnHandleInputEvent [0x02DEB8E1+48]
	base::DispatchToMethodImpl<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(blink::WebInputEvent const *,std::vector<blink::WebInputEvent const *,std::allocator<blink::WebInputEvent const *> > const &,ui::LatencyInfo const &,enum content [0x02DB975F+52]
	base::DispatchToMethod<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(blink::WebInputEvent const *,std::vector<blink::WebInputEvent const *,std::allocator<blink::WebInputEvent const *> > const &,ui::LatencyInfo const &,enum content::In [0x02DB937C+31]
	IPC::DispatchToMethod<content::RenderWidget,void (__thiscall content::RenderWidget::*)(blink::WebInputEvent const *,std::vector<blink::WebInputEvent const *,std::allocator<blink::WebInputEvent const *> > const &,ui::LatencyInfo const &,enum content::Input [0x02DB9563+28]
	IPC::MessageT<InputMsg_HandleInputEvent_Meta,std::tuple<blink::WebInputEvent const *,std::vector<blink::WebInputEvent const *,std::allocator<blink::WebInputEvent const *> >,ui::LatencyInfo,enum content::InputEventDispatchType>,void>::Dispatch<content::Ren [0x02DE7D64+227]
	content::RenderWidget::OnMessageReceived [0x02DEC1DB+1317]
	IPC::MessageRouter::OnMessageReceived [0x03ACB7B2+38]
	content::ChildThreadImpl::OnMessageReceived [0x02D3F1A5+181]

From
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/383690/steps/content_browsertests%20%28with%20patch%29/logs/SitePerProcessBrowserTest.OriginReplication


[4564:6484:0215/171949.191:35173810:FATAL:pointereventfactory.cpp(276)] Check failed: mouseEvent.id == coalescedMouseEvent.id (0 vs. 2147483647)
Backtrace:
	base::debug::StackTrace::StackTrace [0x013D9907+55]
	base::debug::StackTrace::StackTrace [0x013FFFAA+10]
	blink::PointerEventFactory::create [0x0236CA69+552]
	blink::PointerEventManager::sendMousePointerEvent [0x024AF190+40]
	blink::EventHandler::updatePointerTargetAndDispatchEvents [0x024A71C8+143]
	blink::EventHandler::handleMouseMoveOrLeaveEvent [0x024A37D4+1013]
	blink::EventHandler::handleMouseMoveEvent [0x024A3363+129]
	blink::PageWidgetEventHandler::handleMouseMove [0x02025170+68]
	blink::PageWidgetDelegate::handleInputEvent [0x02024FEF+457]
	blink::WebFrameWidgetImpl::handleInputEvent [0x0200F7A0+879]
	content::RenderWidgetInputHandler::HandleInputEvent [0x01E47251+1023]
	content::RenderWidget::OnHandleInputEvent [0x01DDB8E1+48]
	base::DispatchToMethodImpl<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(blink::WebInputEvent const *,std::vector<blink::WebInputEvent const *,std::allocator<blink::WebInputEvent const *> > const &,ui::LatencyInfo const &,enum content [0x01DA975F+52]
	base::DispatchToMethod<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(blink::WebInputEvent const *,std::vector<blink::WebInputEvent const *,std::allocator<blink::WebInputEvent const *> > const &,ui::LatencyInfo const &,enum content::In [0x01DA937C+31]
	IPC::DispatchToMethod<content::RenderWidget,void (__thiscall content::RenderWidget::*)(blink::WebInputEvent const *,std::vector<blink::WebInputEvent const *,std::allocator<blink::WebInputEvent const *> > const &,ui::LatencyInfo const &,enum content::Input [0x01DA9563+28]
	IPC::MessageT<InputMsg_HandleInputEvent_Meta,std::tuple<blink::WebInputEvent const *,std::vector<blink::WebInputEvent const *,std::allocator<blink::WebInputEvent const *> >,ui::LatencyInfo,enum content::InputEventDispatchType>,void>::Dispatch<content::Ren [0x01DD7D64+227]
	content::RenderWidget::OnMessageReceived [0x01DDC1DB+1317]
	IPC::MessageRouter::OnMessageReceived [0x02ABB7B2+38]
	content::ChildThreadImpl::OnMessageReceived [0x01D2F1A5+181]

The DCHECK on line pointereventfactory.cpp:276 is failing:
DCHECK_EQ(mouseEvent.id, coalescedMouseEvent.id);

Sometimes mouseEvent.id is static_cast<int32_t>(-1). Other times, coalescedMouseEvent.id is static_cast<int32_t>(-1).

I'm going to disable this flaky test for now but please look into it (assigning nzolghadr@ who worked on PointerEventFactory recently, and others).

Comment 2 by mgiuca@chromium.org, Feb 16 2017

Disable CL (may take awhile):
https://codereview.chromium.org/2698913002/

Comment 3 by mgiuca@chromium.org, Feb 16 2017

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8afa6f22e805940e3e846abc727c04f490b11bf

commit a8afa6f22e805940e3e846abc727c04f490b11bf
Author: mgiuca <mgiuca@chromium.org>
Date: Thu Feb 16 09:10:44 2017

Disable flaky test SitePerProcessBrowserTest.OriginReplication.

BUG= 692864 

TBR=mgiuca@chromium.org

Review-Url: https://codereview.chromium.org/2698913002
Cr-Commit-Position: refs/heads/master@{#450908}

[modify] https://crrev.com/a8afa6f22e805940e3e846abc727c04f490b11bf/content/browser/site_per_process_browsertest.cc

Were you able to somehow make that failure happen locally? I ran the test quite a few times locally and non of them seems to fail.
Labels: Hotlist-Input-Dev

Comment 7 by mgiuca@chromium.org, Feb 17 2017

No, I've only seen this on the bots.

FYI I've just seen the same failure happen in a different test:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/367389

ProcessManagerBrowserTest.FrameClassification (run #1):
[ RUN      ] ProcessManagerBrowserTest.FrameClassification
[4988:4668:0215/161310.980:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[4988:4668:0215/161310.980:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[6764:7548:0215/161311.520:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
[6764:5596:0215/161311.657:WARNING:render_frame_host_impl.cc(2234)] OnDidStopLoading was called twice.
[6764:5596:0215/161311.794:WARNING:render_frame_host_impl.cc(2234)] OnDidStopLoading was called twice.
[6764:5596:0215/161312.187:WARNING:render_frame_host_impl.cc(2234)] OnDidStopLoading was called twice.
e:\c\win\src\chromerowser\extensions\process_manager_browsertest.cc(498): error: Value of: pm->GetRenderFrameHostsForExtension(extension1->id()).size()
  Actual: 3
Expected: 2u
Which is: 2
e:\c\win\src\chromerowser\extensions\process_manager_browsertest.cc(499): error: Value of: pm->GetAllFrames().size()
  Actual: 3
Expected: 2u
Which is: 2
[6764:5596:0215/161312.402:WARNING:render_frame_host_impl.cc(2234)] OnDidStopLoading was called twice.
[6764:7408:0215/161312.520:ERROR:process_win.cc(140)] Unable to terminate process: Access is denied. (0x5)
[6764:5596:0215/161313.173:WARNING:render_frame_host_impl.cc(2234)] OnDidStopLoading was called twice.
[6764:5596:0215/161313.314:WARNING:render_frame_host_impl.cc(2234)] OnDidStopLoading was called twice.
[5420:8136:0215/161313.345:FATAL:pointereventfactory.cpp(276)] Check failed: mouseEvent.id == coalescedMouseEvent.id (2147483647 vs. 0)
Backtrace:
	base::debug::StackTrace::StackTrace [0x0000000141FD4145+69]
	base::debug::StackTrace::StackTrace [0x0000000141F96393+19]
	logging::LogMessage::~LogMessage [0x0000000141F3101A+74]
	blink::PointerEventFactory::create [0x000000014477ABCB+1007]
	blink::PointerEventManager::sendMousePointerEvent [0x0000000144933961+93]
	blink::EventHandler::handleMouseMoveOrLeaveEvent [0x00000001449232EC+1252]
	blink::EventHandler::handleMouseMoveEvent [0x0000000144922D45+189]
	blink::PageWidgetEventHandler::handleMouseMove [0x00000001442E185F+83]
	blink::PageWidgetDelegate::handleInputEvent [0x00000001442E164F+711]
	blink::WebFrameWidgetImpl::handleInputEvent [0x0000000145E2C228+1104]
	content::RenderWidgetInputHandler::HandleInputEvent [0x00000001451AFEAD+1093]
	content::RenderWidget::OnHandleInputEvent [0x00000001450FDB70+60]
	IPC::DispatchToMethod<content::RenderWidget,void (__cdecl content::RenderWidget::*)(blink::WebInputEvent const * __ptr64,std::vector<blink::WebInputEvent const * __ptr64,std::allocator<blink::WebInputEvent const * __ptr64> > const & __ptr64,ui::LatencyInf [0x00000001450FA280+88]
	IPC::MessageT<InputMsg_HandleInputEvent_Meta,std::tuple<blink::WebInputEvent const * __ptr64,std::vector<blink::WebInputEvent const * __ptr64,std::allocator<blink::WebInputEvent const * __ptr64> >,ui::LatencyInfo,enum content::InputEventDispatchType>,void [0x00000001450F8F89+261]
	content::RenderWidget::OnMessageReceived [0x00000001450FE680+1396]
	IPC::MessageRouter::RouteMessage [0x000000014579AE28+52]
	IPC::MessageRouter::OnMessageReceived [0x000000014579ADDA+50]
	content::ChildThreadImpl::OnMessageReceived [0x000000014402657C+212]
	base::internal::Invoker<base::internal::BindState<void (__cdecl VersionHandler::*)(std::vector<content::WebPluginInfo,std::allocator<content::WebPluginInfo> > const & __ptr64) __ptr64,base::WeakPtr<VersionHandler> >,void __cdecl(std::vector<content::WebPl [0x0000000143C13592+70]
	content::InputEventFilter::HandleEventOnMainThread [0x000000014517A961+277]
	content::MainThreadEventQueue::DispatchInFlightEvent [0x00000001451EA98E+754]
	content::MainThreadEventQueue::DispatchSingleEvent [0x00000001451EAC9B+195]
	base::debug::TaskAnnotator::RunTask [0x0000000141FDDB00+416]
	blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue [0x0000000144244805+1249]
	blink::scheduler::TaskQueueManager::DoWork [0x000000014424308F+811]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__cdecl content::WebMediaPlayerMS::*const & __ptr64)(bool) __ptr64,base::WeakPtr<content::WebMediaPlayerMS> const & __ptr64,bool const & __ptr64> [0x0000000143D4259D+93]
	base::debug::TaskAnnotator::RunTask [0x0000000141FDDB00+416]
	base::MessageLoop::RunTask [0x0000000141F4478E+1294]
	base::MessageLoop::DoWork [0x0000000141F43480+400]
	base::MessagePumpDefault::Run [0x0000000141FE0152+242]
	base::RunLoop::Run [0x0000000141F402F1+161]
	content::RendererMain [0x00000001450CA09E+670]
	content::RunNamedProcessTypeMain [0x0000000141F15411+265]
	content::ContentMainRunnerImpl::Run [0x0000000141F152AD+365]
	content::ContentMain [0x0000000141F14514+48]
	content::LaunchTests [0x0000000142563505+661]
	LaunchChromeTests [0x000000014557B4D2+94]
	main [0x000000014557B18F+83]
	__scrt_common_main_seh [0x000000014551B061+285] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x0000000077805A4D+13]
	RtlUserThreadStart [0x000000007793B831+33]


That test is flaking out a lot right now, and the other flakes I've seen are *different* issues, so I'm not really sure what's going on there.
 Issue 693408  has been merged into this issue.
Patch posted to be re-enabled https://codereview.chromium.org/2847243002/ since  issue 694742  actually removed the dcheck.
Owner: dtapu...@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbfc047fe24d71fe097e17badc5b35534caba593

commit bbfc047fe24d71fe097e17badc5b35534caba593
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Apr 28 21:20:32 2017

Re-enable SitePerProcessBrowserTest.OriginReplication

The test was originally disabled beacuse of a failing DCHECK in the
pointer event code. That is  issue 694742  which other tests were failing
as well. Since that DCHECK is removed there is no need for this test
to actually be disabled.

BUG= 692864 

Review-Url: https://codereview.chromium.org/2847243002
Cr-Commit-Position: refs/heads/master@{#468129}

[modify] https://crrev.com/bbfc047fe24d71fe097e17badc5b35534caba593/content/browser/site_per_process_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment