New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692844 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 658980



Sign in to add a comment

[MD Bookmarks] Add keyboard navigation

Project Member Reported by tsergeant@chromium.org, Feb 16 2017

Issue description

It should be possible to navigate through:

- the sidebar (up/down change selection, left-right change open status)
- the list (up/down changes selection, ctrl-shift modifiers work as expected, possible to use enter)

We should also add keyboard shortcuts for search.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5561b2dc4119384f07627fe976badda532d3fc5

commit a5561b2dc4119384f07627fe976badda532d3fc5
Author: calamity <calamity@chromium.org>
Date: Thu Apr 27 03:27:16 2017

[MD Bookmarks] Remove the bookmarks-sidebar element.

This CL removes the bookmarks-sidebar element in and replaces it with
a root bookmarks-folder-node. This serves to specify the recursive nature
of the sidebar, and will allow for neater recursive behaviors such as
keyboard navigation.

BUG= 692844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823053003
Cr-Commit-Position: refs/heads/master@{#467567}

[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/browser/browser_resources.grd
[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/browser/resources/md_bookmarks/app.js
[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/browser/resources/md_bookmarks/folder_node.js
[delete] https://crrev.com/6e5be9d31acb3b07114e88cc3d24c59e18f47be0/chrome/browser/resources/md_bookmarks/sidebar.html
[delete] https://crrev.com/6e5be9d31acb3b07114e88cc3d24c59e18f47be0/chrome/browser/resources/md_bookmarks/sidebar.js
[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/test/data/webui/md_bookmarks/app_test.js
[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
[rename] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/test/data/webui/md_bookmarks/folder_node_test.js
[modify] https://crrev.com/a5561b2dc4119384f07627fe976badda532d3fc5/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbd0203fc10fbaeae74d56a90f78bc9ec71809cd

commit dbd0203fc10fbaeae74d56a90f78bc9ec71809cd
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Apr 28 05:27:23 2017

MD Bookmarks: Fix sidebar min/max width and Add dialog text

* Fixes an issue from crrev.com/467567, where it was possible to resize the
  sidebar without any limits on minimum or maximum width.
* Fixes an issue from crrev.com/467582, where text was colored white
  incorrectly in the bookmark add dialog.

BUG= 692844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2850673003
Cr-Commit-Position: refs/heads/master@{#467900}

[modify] https://crrev.com/dbd0203fc10fbaeae74d56a90f78bc9ec71809cd/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/dbd0203fc10fbaeae74d56a90f78bc9ec71809cd/chrome/browser/resources/md_bookmarks/toolbar.html

Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00

commit 84f04dbf558f6c3391ef4115e45d7c0ddefc0f00
Author: calamity <calamity@chromium.org>
Date: Wed May 03 07:06:13 2017

[MD Bookmarks] Add keyboard navigation to sidebar.

This CL adds keyboard navigation to the bookmark manager sidebar by
making only a single focus target for the sidebar which is changed by
keypresses.

BUG= 692844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2820153003
Cr-Commit-Position: refs/heads/master@{#468913}

[modify] https://crrev.com/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00/chrome/browser/resources/md_bookmarks/folder_node.js
[modify] https://crrev.com/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
[modify] https://crrev.com/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00/chrome/test/data/webui/md_bookmarks/folder_node_test.js
[add] https://crrev.com/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js
[modify] https://crrev.com/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00/chrome/test/data/webui/md_bookmarks/test_store.js
[modify] https://crrev.com/84f04dbf558f6c3391ef4115e45d7c0ddefc0f00/chrome/test/data/webui/md_bookmarks/test_util.js

Project Member

Comment 4 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/872e2db0bbc390dc17223d85a48581549b8a0836

commit 872e2db0bbc390dc17223d85a48581549b8a0836
Author: calamity <calamity@chromium.org>
Date: Fri May 12 03:03:04 2017

[MD Bookmarks] Allow left/right keys to close/open folders in sidebar.

This CL makes the left and right arrows close and open folders in the
sidebar respectively. A closed folder will transfer selection to the
parent when left is pressed and an open folder will transfer selection
to its first child.

BUG= 692844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2857893002
Cr-Commit-Position: refs/heads/master@{#471199}

[modify] https://crrev.com/872e2db0bbc390dc17223d85a48581549b8a0836/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/872e2db0bbc390dc17223d85a48581549b8a0836/chrome/browser/resources/md_bookmarks/folder_node.js
[modify] https://crrev.com/872e2db0bbc390dc17223d85a48581549b8a0836/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js

Project Member

Comment 5 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4af9a035994eace456a72a30d90186479f15238

commit f4af9a035994eace456a72a30d90186479f15238
Author: calamity <calamity@chromium.org>
Date: Thu May 18 03:31:03 2017

[MD Bookmarks] Convert bookmark list to iron-list.

This CL makes the bookmark list an iron-list in order to deal with
excessively large folders and in preparation for implementing keyboard
navigation of the bookmark list.

As is, this patch will make a single item focusable in the bookmark list
which is then changed via the up and down arrows. The focus ring is only
shown for keyboard focus events.

BUG= 692844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2869273011
Cr-Commit-Position: refs/heads/master@{#472637}

[modify] https://crrev.com/f4af9a035994eace456a72a30d90186479f15238/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/f4af9a035994eace456a72a30d90186479f15238/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/f4af9a035994eace456a72a30d90186479f15238/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/f4af9a035994eace456a72a30d90186479f15238/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/f4af9a035994eace456a72a30d90186479f15238/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/f4af9a035994eace456a72a30d90186479f15238/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/f4af9a035994eace456a72a30d90186479f15238/chrome/browser/resources/md_bookmarks/types.js
[modify] https://crrev.com/f4af9a035994eace456a72a30d90186479f15238/chrome/test/data/webui/md_bookmarks/list_test.js

Project Member

Comment 6 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5

commit 8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5
Author: calamity <calamity@chromium.org>
Date: Mon May 22 05:42:42 2017

[MD Bookmarks] Refine mouse selection

This CL makes some changes to the way multiple selection works:
- single items can be selected/deselected via Ctrl+Click
- Shift-Clicking doesn't update the anchor

The changes made will also support keyboard navigation in a future patch.

BUG= 692844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2888863002
Cr-Commit-Position: refs/heads/master@{#473508}

[modify] https://crrev.com/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5/chrome/browser/resources/md_bookmarks/actions.js
[modify] https://crrev.com/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5/chrome/test/data/webui/md_bookmarks/actions_test.js
[modify] https://crrev.com/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5/chrome/test/data/webui/md_bookmarks/item_test.js
[modify] https://crrev.com/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5/chrome/test/data/webui/md_bookmarks/list_test.js
[modify] https://crrev.com/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5/chrome/test/data/webui/md_bookmarks/reducers_test.js

Project Member

Comment 7 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f959b2ddad3703105af2a3caf02944b58eabd260

commit f959b2ddad3703105af2a3caf02944b58eabd260
Author: calamity <calamity@chromium.org>
Date: Thu May 25 10:10:24 2017

[MD Bookmarks] Add keyboard navigation and selection to bookmark list.

This CL adds keyboard navigation to the bookmarks list via the Up and
Down arrow keys, Shift for range select, and Ctrl for adding individual
items.

This CL adds a method to iron-list which will eventually be added
upstream as stated in
https://github.com/PolymerElements/iron-list/pull/427#issuecomment-300020315.

BUG= 692844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2885723002
Cr-Commit-Position: refs/heads/master@{#474618}

[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/chrome/browser/resources/md_bookmarks/actions.js
[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/chrome/test/data/webui/md_bookmarks/item_test.js
[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js
[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/chrome/test/data/webui/md_bookmarks/reducers_test.js
[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/third_party/polymer/v1_0/chromium.patch
[modify] https://crrev.com/f959b2ddad3703105af2a3caf02944b58eabd260/third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dacd834a9f5bd10f3de9e4780b4d48064370f95

commit 6dacd834a9f5bd10f3de9e4780b4d48064370f95
Author: calamity <calamity@chromium.org>
Date: Wed Jun 07 05:41:59 2017

[MD Bookmarks] Make shift-selection behave well with no anchor.

This CL makes shift-selection use the old focused index as an anchor
which makes shift selecting with the keyboard on page load work as
expected.

BUG= 692844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2924673003
Cr-Commit-Position: refs/heads/master@{#477557}

[modify] https://crrev.com/6dacd834a9f5bd10f3de9e4780b4d48064370f95/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/6dacd834a9f5bd10f3de9e4780b4d48064370f95/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c550cc85921ba59fdb1ef2655a8bd861f351174

commit 3c550cc85921ba59fdb1ef2655a8bd861f351174
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jun 08 06:42:58 2017

MD Bookmarks: Focus sidebar nodes on click without showing an outline

Previously, clicking on a node in the MD Bookmarks sidebar would select
that folder without actually focusing the element. It was necessary to
click a second time to actually give focus and allow keyboard navigation.

This CL fixes this by pulling out the code from <bookmarks-item> that
prevents outlines from showing on click into a shared behavior.
Implementing this behavior improves keyboard navigation in the sidebar
without affecting mouse-only users.

BUG= 692844 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2920413002
Cr-Commit-Position: refs/heads/master@{#477916}

[modify] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/browser_resources.grd
[modify] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/resources/md_bookmarks/folder_node.js
[modify] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/resources/md_bookmarks/item.js
[add] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/resources/md_bookmarks/mouse_focus_behavior.html
[add] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/resources/md_bookmarks/mouse_focus_behavior.js
[modify] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/resources/md_bookmarks/shared_style.html
[modify] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/3c550cc85921ba59fdb1ef2655a8bd861f351174/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js

Owner: calamity@chromium.org
Status: Started (was: Available)
Chris, can this be marked fixed?
Status: Fixed (was: Started)
Indeed.

Sign in to add a comment