New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692843 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 729860

Blocking:
issue 658980



Sign in to add a comment

[MD Bookmarks] Add drag-and-drop

Project Member Reported by tsergeant@chromium.org, Feb 16 2017

Issue description

It should be possible to drag things from the bookmarks bar, BMM sidebar and BMM list into any of those places.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dedb4c1fcf7a1f1b9d43c3ca4f5b73c10d04c5a5

commit dedb4c1fcf7a1f1b9d43c3ca4f5b73c10d04c5a5
Author: calamity <calamity@chromium.org>
Date: Mon Mar 13 05:57:41 2017

[MD Bookmarks] Make folder nodes extend their whole width.

This CL makes the folder nodes in the bookmarks sidebar fill the whole
width of the sidebar so that they can be highlighted and rippled on in
the future.

BUG= 692843 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2733123003
Cr-Commit-Position: refs/heads/master@{#456328}

[modify] https://crrev.com/dedb4c1fcf7a1f1b9d43c3ca4f5b73c10d04c5a5/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/dedb4c1fcf7a1f1b9d43c3ca4f5b73c10d04c5a5/chrome/browser/resources/md_bookmarks/folder_node.js
[modify] https://crrev.com/dedb4c1fcf7a1f1b9d43c3ca4f5b73c10d04c5a5/chrome/browser/resources/md_bookmarks/sidebar.html
[modify] https://crrev.com/dedb4c1fcf7a1f1b9d43c3ca4f5b73c10d04c5a5/chrome/test/data/webui/md_bookmarks/sidebar_test.js

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc543e614e2362ae0e6881fbf5601c415e07c672

commit cc543e614e2362ae0e6881fbf5601c415e07c672
Author: calamity <calamity@chromium.org>
Date: Thu Mar 30 02:15:01 2017

[MD Bookmarks] Add a drag and drop indicator to bookmarks.

This CL adds an indicator for dragging and dropping bookmarks. This
indicator will highlight folders that can be dragged onto and add a line
above/below items for dragging between items. This affects both the list
and the sidebar, and bookmark elements in both are now draggable.

BUG= 692843 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2746363013
Cr-Commit-Position: refs/heads/master@{#460626}

[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/browser_resources.grd
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/app.js
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[add] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/dnd_manager.html
[add] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/folder_node.js
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/shared_style.html
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/shared_vars.html
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/sidebar.html
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/types.js
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/resources/md_bookmarks/util.js
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[add] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[modify] https://crrev.com/cc543e614e2362ae0e6881fbf5601c415e07c672/chrome/test/data/webui/md_bookmarks/test_store.js

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efa6e8b4bbc62a8f983a1be01415ae911338d293

commit efa6e8b4bbc62a8f983a1be01415ae911338d293
Author: calamity <calamity@chromium.org>
Date: Mon Apr 03 05:35:57 2017

[MD Bookmarks] Make drag and drop update data model.

This CL makes the bookmark manager drag and drop actually send a message
to Chrome to update the bookmarks model.

BUG= 692843 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2772003002
Cr-Commit-Position: refs/heads/master@{#461373}

[modify] https://crrev.com/efa6e8b4bbc62a8f983a1be01415ae911338d293/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/efa6e8b4bbc62a8f983a1be01415ae911338d293/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Cc: -calamity@chromium.org
Owner: calamity@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7e2f44b15e8b8e23ce1d96cadf0174f707aa74a

commit c7e2f44b15e8b8e23ce1d96cadf0174f707aa74a
Author: calamity <calamity@chromium.org>
Date: Mon Apr 10 07:06:44 2017

[MD Bookmarks] Auto expand folders on drag hover.

BUG= 692843 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2790353002
Cr-Commit-Position: refs/heads/master@{#463182}

[modify] https://crrev.com/c7e2f44b15e8b8e23ce1d96cadf0174f707aa74a/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/c7e2f44b15e8b8e23ce1d96cadf0174f707aa74a/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Project Member

Comment 9 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8cc19e2ca0b494668eb91df0eb054f3d94b639e

commit b8cc19e2ca0b494668eb91df0eb054f3d94b639e
Author: calamity <calamity@chromium.org>
Date: Mon May 15 04:06:59 2017

[MD Bookmarks] Make dragging update selected items.

This CL makes the bookmark list select the item that's being dragged if
it isn't already selected and deselects the existing set if it doesn't
include the drag item.

BUG= 692843 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2871573004
Cr-Commit-Position: refs/heads/master@{#471657}

[modify] https://crrev.com/b8cc19e2ca0b494668eb91df0eb054f3d94b639e/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/b8cc19e2ca0b494668eb91df0eb054f3d94b639e/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Project Member

Comment 10 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c7e4324cc1c6e37212c0e8ac667c7d79b3947c5

commit 1c7e4324cc1c6e37212c0e8ac667c7d79b3947c5
Author: calamity <calamity@chromium.org>
Date: Fri May 19 04:14:11 2017

[MD Bookmarks] Clear drop indicator when dragging over invalid target.

This CL fixes an issue where dragging an item onto itself wouldn't
clear the drop indicator.

BUG= 692843 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2884233003
Cr-Commit-Position: refs/heads/master@{#473083}

[modify] https://crrev.com/1c7e4324cc1c6e37212c0e8ac667c7d79b3947c5/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/1c7e4324cc1c6e37212c0e8ac667c7d79b3947c5/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Blockedon: 729860
Blockedon: 729861
Blockedon: -729861
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7d1ff77eb9e305fc8d15e9ad5016e3806e0ecbe

commit c7d1ff77eb9e305fc8d15e9ad5016e3806e0ecbe
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Sep 04 05:37:38 2017

[MD Bookmarks] Use debouncer to auto-expand folders on drag.

This CL makes the autoexpander in the bookmarks manager use a
setTimeout based delay rather than relying on the next mousemove. This
is more robust and feels more correct (the folder expands when the mouse
is held still over a folder for 400ms, rather than after 400ms after
first movement).

Bug:  692843 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0cfe3756c69eeccab3517335b67011215c5a11e0
Reviewed-on: https://chromium-review.googlesource.com/637285
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499439}
[modify] https://crrev.com/c7d1ff77eb9e305fc8d15e9ad5016e3806e0ecbe/chrome/browser/resources/md_bookmarks/api_listener.js
[modify] https://crrev.com/c7d1ff77eb9e305fc8d15e9ad5016e3806e0ecbe/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/c7d1ff77eb9e305fc8d15e9ad5016e3806e0ecbe/chrome/browser/resources/md_bookmarks/timer_proxy.js
[modify] https://crrev.com/c7d1ff77eb9e305fc8d15e9ad5016e3806e0ecbe/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Status: Fixed (was: Started)

Sign in to add a comment