It should be possible to open multiple items at once: * By selecting multiple items and then pressing enter (or shift-double clicking!?!) * By using Open All from a folder context menu See previous work: https://codereview.chromium.org/2668693007/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3693ae6f5653c20d845aae55fb2b734b46c337a8 commit 3693ae6f5653c20d845aae55fb2b734b46c337a8 Author: calamity <calamity@chromium.org> Date: Thu May 04 03:12:43 2017 [cr-action-menu] Allow configurable anchors. This CL adds showAtPosition to cr-action-menu which allows a client to specify a rect or point to anchor to and which side of the menu to align. This will be used in MD Bookmarks for right click context menus which require more flexible alignment. BUG= 692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2814743007 Cr-Commit-Position: refs/heads/master@{#469257} [modify] https://crrev.com/3693ae6f5653c20d845aae55fb2b734b46c337a8/chrome/test/data/webui/cr_elements/cr_action_menu_test.js [modify] https://crrev.com/3693ae6f5653c20d845aae55fb2b734b46c337a8/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a32022824f01698ab161130a96c2832a8226bb46 commit a32022824f01698ab161130a96c2832a8226bb46 Author: calamity <calamity@chromium.org> Date: Thu May 04 06:00:02 2017 [MD Bookmarks] Right click on bookmark items open context menu. This CL makes the context menu for bookmark items appear when an item is clicked. BUG= 692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2814023004 Cr-Commit-Position: refs/heads/master@{#469281} [modify] https://crrev.com/a32022824f01698ab161130a96c2832a8226bb46/chrome/browser/resources/md_bookmarks/item.js [modify] https://crrev.com/a32022824f01698ab161130a96c2832a8226bb46/chrome/browser/resources/md_bookmarks/list.html [modify] https://crrev.com/a32022824f01698ab161130a96c2832a8226bb46/chrome/browser/resources/md_bookmarks/list.js [modify] https://crrev.com/a32022824f01698ab161130a96c2832a8226bb46/chrome/test/data/webui/md_bookmarks/item_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fad224fbb037adf1a6f37633708732f758f39497 commit fad224fbb037adf1a6f37633708732f758f39497 Author: tsergeant <tsergeant@chromium.org> Date: Fri May 05 04:42:09 2017 MD Bookmarks: Add keyboard shortcut support to bookmarks-command-manager This adds keyboard shortcuts for Edit, Copy and Delete. BUG= 692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2843903002 Cr-Commit-Position: refs/heads/master@{#469595} [modify] https://crrev.com/fad224fbb037adf1a6f37633708732f758f39497/chrome/browser/resources/md_bookmarks/command_manager.html [modify] https://crrev.com/fad224fbb037adf1a6f37633708732f758f39497/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/fad224fbb037adf1a6f37633708732f758f39497/chrome/test/data/webui/md_bookmarks/command_manager_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13a46646f69af7604810223dc4be9903d5644873 commit 13a46646f69af7604810223dc4be9903d5644873 Author: tsergeant <tsergeant@chromium.org> Date: Mon May 15 01:21:03 2017 MD Bookmarks: Add commands for 'Open in <x>' menu items This adds 'Open in new tab', 'Open in new window' and 'Open in incognito window' to the context menu in MD Bookmarks, along with keyboard shortcuts for the first two commands. BUG= 692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2864993002 Cr-Commit-Position: refs/heads/master@{#471646} [modify] https://crrev.com/13a46646f69af7604810223dc4be9903d5644873/chrome/browser/resources/md_bookmarks/command_manager.html [modify] https://crrev.com/13a46646f69af7604810223dc4be9903d5644873/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/13a46646f69af7604810223dc4be9903d5644873/chrome/browser/resources/md_bookmarks/constants.js [modify] https://crrev.com/13a46646f69af7604810223dc4be9903d5644873/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/13a46646f69af7604810223dc4be9903d5644873/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/13a46646f69af7604810223dc4be9903d5644873/chrome/test/data/webui/md_bookmarks/command_manager_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2db36268c223640a0ed5cfb98de3ca949a8a9b94 commit 2db36268c223640a0ed5cfb98de3ca949a8a9b94 Author: tsergeant <tsergeant@chromium.org> Date: Mon May 15 02:47:53 2017 MD Bookmarks: Make CommandManager available as a singleton This makes the command manager globally available, which is necessary to allow <bookmark-item>s to execute commands. This CL is split apart from other changes as the diff from reformatting the entire file is very large. BUG= 692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2868383004 Cr-Commit-Position: refs/heads/master@{#471651} [modify] https://crrev.com/2db36268c223640a0ed5cfb98de3ca949a8a9b94/chrome/browser/resources/md_bookmarks/command_manager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e commit 6c5ad90a8e6c3d841df6b7fb01c935879aedf64e Author: tsergeant <tsergeant@chromium.org> Date: Fri May 19 14:12:34 2017 MD Bookmarks: Add 'Open' command, to open in either the BMM or in new tabs This command is triggered by double clicking selected items, or by pressing Enter (non-Mac) or Meta-Down (Mac). If a single folder is selected, the command will open that folder in the bookmark manager. Otherwise, it will open all selected bookmarks in foreground tabs. BUG= 692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2872163002 Cr-Commit-Position: refs/heads/master@{#473180} [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/browser/resources/md_bookmarks/actions.js [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/browser/resources/md_bookmarks/constants.js [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/browser/resources/md_bookmarks/item.html [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/browser/resources/md_bookmarks/item.js [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/test/data/webui/md_bookmarks/actions_test.js [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/test/data/webui/md_bookmarks/command_manager_test.js [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/test/data/webui/md_bookmarks/item_test.js [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/test/data/webui/md_bookmarks/list_test.js [modify] https://crrev.com/6c5ad90a8e6c3d841df6b7fb01c935879aedf64e/chrome/test/data/webui/md_bookmarks/test_util.js
Still TODO: - Add back in middle-click behavior - Add count of bookmarks to menu labels
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a274e041953915ac3c48d4bbb1c6d360253bffba commit a274e041953915ac3c48d4bbb1c6d360253bffba Author: tsergeant <tsergeant@chromium.org> Date: Fri Jun 16 05:22:28 2017 MD Bookmarks: Add right-click context menu to sidebar folders Right clicking a folder in the sidebar will select that folder and show the menu of edit/open commands for that folder. BUG= 692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2926233002 Cr-Commit-Position: refs/heads/master@{#479957} [modify] https://crrev.com/a274e041953915ac3c48d4bbb1c6d360253bffba/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/a274e041953915ac3c48d4bbb1c6d360253bffba/chrome/browser/resources/md_bookmarks/folder_node.html [modify] https://crrev.com/a274e041953915ac3c48d4bbb1c6d360253bffba/chrome/browser/resources/md_bookmarks/folder_node.js [modify] https://crrev.com/a274e041953915ac3c48d4bbb1c6d360253bffba/chrome/test/data/webui/md_bookmarks/folder_node_test.js [modify] https://crrev.com/a274e041953915ac3c48d4bbb1c6d360253bffba/chrome/test/data/webui/md_bookmarks/test_command_manager.js
Comment 1 by bugdroid1@chromium.org
, May 4 2017