Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 692827 [MD Bookmarks] Add ability to delete multiple items
Starred by 1 user Project Member Reported by tsergeant@chromium.org, Feb 16 Back to list
Status: Fixed
Owner:
Closed: May 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 658980



Sign in to add a comment
It should be possible to select multiple items and then delete them from a toolbar button or keyboard shortcuts.

In-progress CL from jiaxi@: https://codereview.chromium.org/2675503002/
 
Project Member Comment 1 by bugdroid1@chromium.org, Apr 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32875f8b059b68f17b1766f3df508c56b22911c4

commit 32875f8b059b68f17b1766f3df508c56b22911c4
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Apr 11 04:14:31 2017

MD WebUI: Pull 'X selected' toolbar overlay from History into shared element

The overlay is designed for use with cr-toolbar, providing an overlay
with the number of items selected, and a 'cancel' and 'delete' button.
This new shared element will be used by MD Bookmarks.

BUG= 692827 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2800603002
Cr-Commit-Position: refs/heads/master@{#463530}

[modify] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/chrome/browser/resources/md_history/history_toolbar.js
[modify] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/chrome/browser/resources/md_history/lazy_load.html
[modify] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/chrome/test/data/webui/md_history/history_metrics_test.js
[modify] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/chrome/test/data/webui/md_history/history_supervised_user_test.js
[modify] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/ui/webui/resources/cr_elements/cr_toolbar/compiled_resources2.gyp
[add] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
[add] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.js
[modify] https://crrev.com/32875f8b059b68f17b1766f3df508c56b22911c4/ui/webui/resources/cr_elements_resources.grdp

Project Member Comment 2 by bugdroid1@chromium.org, Apr 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92e0de602a4ca4b47313fc4095298755cdfd3cfb

commit 92e0de602a4ca4b47313fc4095298755cdfd3cfb
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Apr 27 04:46:16 2017

MD Bookmarks: Show toolbar overlay when multiple items are selected

This shows the same toolbar overlay as MD History, with 'Cancel'/'Delete'
options. In MD Bookmarks, the overlay is only shown when more than one
item is selected, to avoid flickering when double clicking items.

BUG= 692827 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2827573002
Cr-Commit-Position: refs/heads/master@{#467582}

[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/browser/resources/md_bookmarks/shared_vars.html
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[add] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/test/data/webui/md_bookmarks/toolbar_test.js
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/chrome/test/data/webui/md_history/md_history_focus_test.js
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/92e0de602a4ca4b47313fc4095298755cdfd3cfb/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

Project Member Comment 3 by bugdroid1@chromium.org, May 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77365188782303a17f15571a0f253dcb5cc0e0b9

commit 77365188782303a17f15571a0f253dcb5cc0e0b9
Author: tsergeant <tsergeant@chromium.org>
Date: Fri May 05 04:02:33 2017

MD Bookmarks: Pull context menu into separate element

This creates a new element, <bookmarks-command-manager>, which is
responsible for showing the context menu, hiding commands which are
unavailable and responding to command clicks. Pulling out the context
menu like this will make it easier to reuse in multiple places, and
make it simpler to add keyboard shortcuts for menu items.

BUG= 692827 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2834493006
Cr-Commit-Position: refs/heads/master@{#469592}

[modify] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/browser_resources.grd
[modify] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/resources/md_bookmarks/app.html
[add] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/resources/md_bookmarks/command_manager.html
[add] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/resources/md_bookmarks/constants.js
[modify] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[add] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/test/data/webui/md_bookmarks/command_manager_test.js
[modify] https://crrev.com/77365188782303a17f15571a0f253dcb5cc0e0b9/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js

Project Member Comment 4 by bugdroid1@chromium.org, May 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1ffc8932b93b6dca10055638cb08460f4752fed

commit f1ffc8932b93b6dca10055638cb08460f4752fed
Author: tsergeant <tsergeant@chromium.org>
Date: Fri May 05 07:43:43 2017

MD Bookmarks: Update Delete command to only delete the minimal set of nodes

This adds a filter so that when asking to delete a node at the same time
as one of its children, only the parent node will be explicitly deleted
(the child node will be implicitly deleted).

BUG= 692827 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2850763002
Cr-Commit-Position: refs/heads/master@{#469612}

[modify] https://crrev.com/f1ffc8932b93b6dca10055638cb08460f4752fed/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/f1ffc8932b93b6dca10055638cb08460f4752fed/chrome/test/data/webui/md_bookmarks/command_manager_test.js

Project Member Comment 5 by bugdroid1@chromium.org, May 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62eb5de09e830c95b1d27688d2bac91a6390f0e7

commit 62eb5de09e830c95b1d27688d2bac91a6390f0e7
Author: tsergeant <tsergeant@chromium.org>
Date: Tue May 23 08:16:56 2017

MD Bookmarks: Enable the delete button in the toolbar overlay

The Delete button in the overlay which appears when selecting more than
one item will now delete all selected items when clicked.

BUG= 692827 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2893833002
Cr-Commit-Position: refs/heads/master@{#473835}

[modify] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/chrome/test/data/webui/md_bookmarks/command_manager_test.js
[modify] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[add] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/chrome/test/data/webui/md_bookmarks/test_command_manager.js
[modify] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/chrome/test/data/webui/md_bookmarks/toolbar_test.js
[modify] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/ui/webui/resources/cr_elements/cr_toolbar/compiled_resources2.gyp
[modify] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
[modify] https://crrev.com/62eb5de09e830c95b1d27688d2bac91a6390f0e7/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.js

Owner: tsergeant@chromium.org
Status: Fixed
I think we can now call this fixed. You can delete multiple items with keyboard shortcuts, the context menu, or the toolbar overlay.
Sign in to add a comment