New issue
Advanced search Search tips

Issue 692826 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Autofill table does not allow custom cryptography to be used.

Reported by devar...@amazon.com, Feb 16 2017 
What went wrong?
Autofill table encrypts sensitive data using a hard coded password, salt and encryption algorithm with a fixed size key.

What is the expected behavior?
Autofill table encrypts sensitive data according to an encryptor passed in as dependency.

Did this work before? N/A 

Chrome version: master  Channel: stable
OS Version: Any
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0483e6b832ff9e9117c86fdf2641b389d9c2992

commit c0483e6b832ff9e9117c86fdf2641b389d9c2992
Author: devarajn <devarajn@amazon.com>
Date: Fri Feb 24 05:15:35 2017

Allow embedder to use custom cryptography in Autofill table.

As of today, Autofill table makes static calls to OSCrypt
component for cyptography needs and does not allow embedders
to inject custom crytography. This change fixes it by
allowing Autofill table to take encryptor as dependency.

BUG= 692826 
TEST=components_unittests

Review-Url: https://codereview.chromium.org/2698103002
Cr-Commit-Position: refs/heads/master@{#452757}

[modify] https://crrev.com/c0483e6b832ff9e9117c86fdf2641b389d9c2992/AUTHORS
[modify] https://crrev.com/c0483e6b832ff9e9117c86fdf2641b389d9c2992/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/c0483e6b832ff9e9117c86fdf2641b389d9c2992/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/c0483e6b832ff9e9117c86fdf2641b389d9c2992/components/autofill/core/browser/webdata/autofill_table.h
[add] https://crrev.com/c0483e6b832ff9e9117c86fdf2641b389d9c2992/components/autofill/core/browser/webdata/autofill_table_encryptor.h
[add] https://crrev.com/c0483e6b832ff9e9117c86fdf2641b389d9c2992/components/autofill/core/browser/webdata/autofill_table_encryptor_factory.cc
[add] https://crrev.com/c0483e6b832ff9e9117c86fdf2641b389d9c2992/components/autofill/core/browser/webdata/autofill_table_encryptor_factory.h
[add] https://crrev.com/c0483e6b832ff9e9117c86fdf2641b389d9c2992/components/autofill/core/browser/webdata/system_encryptor.cc
[add] https://crrev.com/c0483e6b832ff9e9117c86fdf2641b389d9c2992/components/autofill/core/browser/webdata/system_encryptor.h

Comment 3 by devar...@amazon.com, Mar 20 2017 

Hi,
  Code already landed. Please resolve this bug.

Thank you

Comment 4 by ligim...@chromium.org, Mar 9 2018

Status: WontFix (was: Unconfirmed)
Closing due to inactivity, please reopen if needed.
►

Sign in to add a comment