WebGL tests aren't run on trivial WebGL rolls |
||
Issue descriptionIn recent WebGL roll https://codereview.chromium.org/2693063006 it was discovered that the roll actually didn't run any tests. The analyze step claimed (correctly) that no compile was needed, but it didn't realize that tests needed to be run. There are already exclusions in src/testing/buildbot/trybot_analyze_config.json for some of the GPU-related directories, like src/content/test/gpu. Changes underneath these directories bypass the analyze step and force all related test targets on the bot to be built and run. It's not feasible to watch changes under src/third_party/webgl/src, since that directory's versioned via DEPS. The fix will be to modify src/tools/roll_webgl_conformance.py to make a change to a simple text file under src/content/test/gpu/gpu_tests/ so that a roll triggers all of the GPU tests.
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ea13b4c100dbc93be076c72923be1f03272bfb8 commit 0ea13b4c100dbc93be076c72923be1f03272bfb8 Author: kbr <kbr@chromium.org> Date: Thu Feb 16 20:01:50 2017 Make roll_webgl_conformance.py force all GPU tests. This is done by triggering an "analyze" exclusion already in trybot_analyze_config.json. BUG= 692823 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel R=zmo@chromium.org Review-Url: https://codereview.chromium.org/2698833002 Cr-Commit-Position: refs/heads/master@{#451070} [add] https://crrev.com/0ea13b4c100dbc93be076c72923be1f03272bfb8/content/test/gpu/gpu_tests/webgl_conformance_revision.txt [modify] https://crrev.com/0ea13b4c100dbc93be076c72923be1f03272bfb8/tools/roll_webgl_conformance.py
,
Feb 16 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by kbr@chromium.org
, Feb 16 2017