New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692821 link

Starred by 1 user
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 658980



Sign in to add a comment

[MD Bookmarks] Support adding/editing bookmarks and folders

Project Member Reported by tsergeant@chromium.org, Feb 16 2017 
We need to be able to add new folders/bookmarks from the main toolbar menu,
and edit folders/bookmarks from menus on individual items.

We should add something like <bookmarks-edit-dialog> to avoid duplicating this behavior.

In-progress CL from angelayang@: https://codereview.chromium.org/2670473002/

Comment 1 by tsergeant@chromium.org, Mar 9 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93582461cb4310f9ae81bd7fd3727917065f42c5

commit 93582461cb4310f9ae81bd7fd3727917065f42c5
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Mar 22 07:15:14 2017

MD Bookmarks: Extract bookmark editing into a <bookmarks-edit-dialog> element

This element will allow us to reuse editing markup/logic for adding new
bookmarks. The change also makes it easy to defer rendering of the dialog
until it is needed (using cr-lazy-render), which makes a small impact on
page load time.

BUG= 692821 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2742583003
Cr-Commit-Position: refs/heads/master@{#458658}

[modify] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/browser/browser_resources.grd
[modify] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[add] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/browser/resources/md_bookmarks/edit_dialog.html
[add] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/browser/resources/md_bookmarks/edit_dialog.js
[modify] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[add] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/test/data/webui/md_bookmarks/edit_dialog_test.js
[modify] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/test/data/webui/md_bookmarks/list_test.js
[modify] https://crrev.com/93582461cb4310f9ae81bd7fd3727917065f42c5/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3

commit b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Apr 05 07:31:18 2017

MD Bookmarks: Handle bookmark creation

This makes the MD Bookmarks UI update when a bookmark is created from
elsewhere in the browser (eg, from the bookmarks bar). A follow-up CL
will make it possible to create new bookmarks from the MD Bookmarks UI.

BUG= 692821 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2795623002
Cr-Commit-Position: refs/heads/master@{#462002}

[modify] https://crrev.com/b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3/chrome/browser/resources/md_bookmarks/actions.js
[modify] https://crrev.com/b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3/chrome/browser/resources/md_bookmarks/api_listener.js
[modify] https://crrev.com/b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3/chrome/browser/resources/md_bookmarks/util.js
[modify] https://crrev.com/b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3/chrome/test/data/webui/md_bookmarks/reducers_test.js
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85e49faca65081cad27e7c8ed43b02261afcaa96

commit 85e49faca65081cad27e7c8ed43b02261afcaa96
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Apr 05 07:40:08 2017

MD Bookmarks: Implement dialog to add new folders/bookmarks

The dialog can be accessed from the menu in the toolbar, and will add
new items to the end of the selected folder.

BUG= 692821 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2780223004
Cr-Commit-Position: refs/heads/master@{#462005}

[modify] https://crrev.com/85e49faca65081cad27e7c8ed43b02261afcaa96/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/85e49faca65081cad27e7c8ed43b02261afcaa96/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/85e49faca65081cad27e7c8ed43b02261afcaa96/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/85e49faca65081cad27e7c8ed43b02261afcaa96/chrome/browser/resources/md_bookmarks/edit_dialog.js
[modify] https://crrev.com/85e49faca65081cad27e7c8ed43b02261afcaa96/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/85e49faca65081cad27e7c8ed43b02261afcaa96/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/85e49faca65081cad27e7c8ed43b02261afcaa96/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/85e49faca65081cad27e7c8ed43b02261afcaa96/chrome/test/data/webui/md_bookmarks/edit_dialog_test.js
[modify] https://crrev.com/85e49faca65081cad27e7c8ed43b02261afcaa96/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html

Comment 7 by tsergeant@chromium.org, Apr 5 2017

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15cf6391043873e64d75e9b40b549cbe5314aea5

commit 15cf6391043873e64d75e9b40b549cbe5314aea5
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Apr 06 10:37:26 2017

MD Bookmarks: Remove 'enter' handler from Add/Edit dialog

Following https://crrev.com/461814, cr-dialog now automatically accepts
when enter is pressed with a paper-input focused. This CL reverts
https://crrev.com/459706, removing the now duplicated event handler.

BUG= 692821 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2802723003
Cr-Commit-Position: refs/heads/master@{#462415}

[modify] https://crrev.com/15cf6391043873e64d75e9b40b549cbe5314aea5/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/15cf6391043873e64d75e9b40b549cbe5314aea5/chrome/browser/resources/md_bookmarks/edit_dialog.js
[modify] https://crrev.com/15cf6391043873e64d75e9b40b549cbe5314aea5/chrome/test/data/webui/md_bookmarks/edit_dialog_test.js
►

Sign in to add a comment