Fix screenshot test to impose min size limit |
|||
Issue descriptionAs per partner bug (https://code.google.com/p/chrome-os-partner/issues/detail?id=55971), we should also check the screenshot is above a certain size in platfrom_InputScreenshot.
,
Feb 22 2017
I checked cyan and squawks, screenshot size is so different. cyan: 644K while squawks 20K. How can we determine it's indeed the image screenshot taking ?
,
Feb 22 2017
In the bug, the "empty" screenshot was 78 bytes. We could impose a very minimal floor, maybe 1k to make sure the file size is non-negligible.
,
Feb 22 2017
May be you can run the file command and it should return the file type.
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/894d25c3bac46b35ace26822d9da6203c5828733 commit 894d25c3bac46b35ace26822d9da6203c5828733 Author: Helen Zhang <helenzhang@chromium.org> Date: Fri Mar 03 02:34:11 2017 Add file size check BUG= chromium:692820 TEST=None Change-Id: Idc6675c50abc7929fc0ddd6484766491d5da2f8a Reviewed-on: https://chromium-review.googlesource.com/448762 Commit-Ready: Helen Zhang <helenzhang@chromium.org> Tested-by: Helen Zhang <helenzhang@chromium.org> Reviewed-by: Kalin Stoyanov <kalin@chromium.org> [modify] https://crrev.com/894d25c3bac46b35ace26822d9da6203c5828733/client/site_tests/platform_InputScreenshot/control [modify] https://crrev.com/894d25c3bac46b35ace26822d9da6203c5828733/client/site_tests/platform_InputScreenshot/platform_InputScreenshot.py
,
Mar 6 2017
,
Mar 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ka...@chromium.org
, Feb 16 2017