New issue
Advanced search Search tips

Issue 692818 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Clearing TPM Attestation Keys should not depend on BUILDFLAG(ENABLE_PLUGINS)

Project Member Reported by jrumm...@chromium.org, Feb 15 2017

Issue description

The code that clears the TpmAttestationKeys for Clear Browsing Data [1] should not depend on BUILDFLAG(ENABLE_PLUGINS).

[1] https://cs.chromium.org/chromium/src/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc?l=876
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/521d60812176375b2a0f196c7ccd31f38d524efa

commit 521d60812176375b2a0f196c7ccd31f38d524efa
Author: jrummell <jrummell@chromium.org>
Date: Fri Mar 03 02:25:03 2017

Always clear TPM attestation keys on ChromeOS when removing media licenses

Clearing the TPM attestation keys is not dependent on plugins being enabled,
(or Flash), so cleanup the #if ... #endif blocks to make this clear.

BUG= 692818 
TEST=compiles

Review-Url: https://codereview.chromium.org/2730803002
Cr-Commit-Position: refs/heads/master@{#454472}

[modify] https://crrev.com/521d60812176375b2a0f196c7ccd31f38d524efa/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

Status: Fixed (was: Assigned)

Comment 3 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment