New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692817 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Indirect-leak in xmlNewReference

Project Member Reported by ClusterFuzz, Feb 15 2017

Issue description

Components: Blink>XML
Labels: Test-Predator-Wrong M-58
Cc: msrchandra@chromium.org
Owner: dominicc@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "xmlstring.c" assigning to the concern owner.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/3c53598f981660671a93f9f71e52e5bb58a2b64e

@dominicc -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Labels: -Pri-1 Pri-3
I maintain the integration of this third party library so I am a good person to assign these to.

Leaks in this component aren't a high priority right now; I'm worried that working on fixing them takes time away from, and may even exacerbate, problems where memory isn't being held onto long enough.
Cc: aizatsky@chromium.org mmoroz@chromium.org ddkil...@apple.com kcc@chromium.org dominicc@chromium.org
 Issue 698330  has been merged into this issue.
I think what's happening here is entities cache their children, but some (all?) memory associated with that is not freed. So maybe debugging xmlFreeEntity to see if entity->children is even attempting to be freed, and if so, why xmlFreeNodeList isn't reaching these pointers.
Labels: -M-58 M-60
Can we have the latest update on this issue? Looks like its not yest fixed from the report- https://clusterfuzz.com/v2/testcase-detail/4565597116694528?noredirect=1.

Punting to M60.
Here's how I prioritize libxml2, etc. bugs:

(most important)
UAF/double free; OOB access
overflows
null deref; other undefined behavior
leaks
(least important)

At the moment I'm working on more important things, so I haven't made any serious progress on this one sorry. HTH!

Comment 8 by ddkil...@apple.com, May 30 2017

I think this is probably related to:

libxml2: Indirect-leak in xmlBufResize
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=735

Project Member

Comment 10 by ClusterFuzz, Jun 21 2017

ClusterFuzz has detected this issue as fixed in range 480737:480767.

Detailed report: https://clusterfuzz.com/testcase?key=4565597116694528

Fuzzer: libFuzzer_libxml_xml_read_memory_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Indirect-leak
Crash Address: 
Crash State:
  xmlNewReference
  xmlStringGetNodeList
  xmlStringGetNodeList
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=450688:450717
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=480737:480767

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4565597116694528


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Jun 21 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6692732333719552 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment