Once webkit-patch rebaseline-cl is "ready" (probably when bug 671684 and bug 673966 are resolved), we want to gently phase out use of rebaseline-o-matic.
This will probably be best accomplished by an announcement to blink-dev, combined with new warnings whenever adding NeedsRebaseline expectations.
I'd like to deprecate this in July if possible, if there are no more issues that people feel should block this.
I think that now seems like a good time to officially deprecate and turn down rebaseline-o-matic because I believe some (albeit minor) changes are required for it to work with Gerrit. Specifically, it currently assumes we're using Rietveld when getting the CL issue number. Since the change required to switch to Gerrit is small, this is not a hard cut-off.
The real reasons for wanting to deprecate rebaseline-o-matic are:
- Removing rebaseline-o-matic and `webkit-patch auto-rebaseline` will decrease maintenance burden in the future.
- Removing these also makes some related bugs (e.g. 693352) obsolete.
- Making rebaselining from try jobs the normal way of rebaselining has advantages in general.
- Even if rebaselining from try jobs weren't applicable to all cases, it's still possible to rebaseline from continuous builder results with other webkit-patch rebaseline commands.
I'd like to reference this bug in the deprecation message and message to blink-dev.
Started a CL to add a deprecation warning message at https://chromium-review.googlesource.com/539136.
Update: After removing support for NeedsRebaseline lines, the rebaseline-o-matic bot has now not made any changes for more than two weeks:
https://codereview.chromium.org/search?closed=1&owner=blink-rebaseline-bot%40chromium.org
Next steps:
1. Remove the rebaseline_o_matic builder from the master config.
2. Remove the recipe.
3. Remove the puppet config.
4. Remove the auto-rebaseline command.
Alright, I think everything that I planned to do here is now done.
There's one more comment somewhere that refers to rebaseline-o-matic; I'll be sure to remove that later.
Comment 1 by qyears...@chromium.org
, Jun 18 2017Labels: -Pri-3 Pri-2
Owner: qyears...@chromium.org
Status: Assigned (was: Available)