New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692803 link

Starred by 1 user
Status: Fixed
Owner:
█ mge...@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

HostCache can evict non-stale entries before stale entries

Project Member Reported by mge...@chromium.org, Feb 15 2017 
HostCache::EvictOneEntry() only looks at expiration times, not network changes. If entry A with a long TTL is inserted, then the network changes, then entry B with a short TTL is inserted, so entry B expires before entry A originally would have expired, B will be evicted before A even though A is stale and B is not.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cdf01f7131fa57830221af1156b1a3ca1e11578

commit 9cdf01f7131fa57830221af1156b1a3ca1e11578
Author: mgersh <mgersh@chromium.org>
Date: Fri Feb 17 23:24:54 2017

HostCache: always evict stale entries before valid entries

Previously, HostCache would always evict the entry with the earliest
expiration time. Because entries can also become stale due to network
changes, this could potentially evict a valid entry when stale
entries are present in the cache.

BUG= 692803 

Review-Url: https://codereview.chromium.org/2701673003
Cr-Commit-Position: refs/heads/master@{#451395}

[modify] https://crrev.com/9cdf01f7131fa57830221af1156b1a3ca1e11578/net/dns/host_cache.cc
[modify] https://crrev.com/9cdf01f7131fa57830221af1156b1a3ca1e11578/net/dns/host_cache_unittest.cc

Comment 2 by mge...@chromium.org, Feb 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment