chromeos oobe: onNetworkConnected_ is not a function |
|||||||
Issue descriptionIn chromeos on gubuntu with command line flags: -auth-no-local-webserver --enable-logging=stderr --log-severity=info --user-data-dir=/tmp/chrome --login-profile=user --login-manager 1. click next on the language selection page. 2. try to click/connect to a wifi and move on from the network connection page. Problem: the page won't advance. The click on the next button is acknowledge with a ripple effect, but the page stays on the network connection. The log output says that onNetworkConnected_ is not a function, which sounds related [39616:39616:0215/150404.390527:ERROR:device_event_log_impl.cc(137)] [15:04:04.390] Network: network_connection_handler.cc:789 Connect Failure: connected: /service/wifi1 [39616:39616:0215/150404.390622:ERROR:device_event_log_impl.cc(137)] [15:04:04.390] Network: network_connect.cc:197 Connect Failed: connected: wifi1_guid [39616:39616:0215/150404.402453:ERROR:CONSOLE(0)] "Error in response to networkingPrivate.startConnect: TypeError: self.onNetworkConnected_ is not a function", source: chrome://oobe/oobe (0)
,
Feb 15 2017
So, that's definitely a bug that we should fix, it should just call onSelectedNetworkConnected_() instead of onNetworkConnected_, but it is not the underlying problem. ->alemate@
,
Feb 18 2017
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/896435ba0b632e5e04c0fa83158ca275f09feb1b commit 896435ba0b632e5e04c0fa83158ca275f09feb1b Author: alemate <alemate@chromium.org> Date: Wed Feb 22 08:26:52 2017 chromeos oobe: onNetworkConnected_ is not a function Remove onNetworkConnected_ call as network item will trigger "connected" event itself. BUG= 692797 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2705803002 Cr-Commit-Position: refs/heads/master@{#451927} [modify] https://crrev.com/896435ba0b632e5e04c0fa83158ca275f09feb1b/chrome/browser/resources/chromeos/login/oobe_welcome.js
,
Mar 30 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by steve...@chromium.org
, Feb 15 2017Labels: OS-Chrome