Gtk3: Menuitem accelerator color is always enabled |
||
Issue descriptionSee the attached image. "Back" and "Forward" are disabled, but the accelerators look enabled. This makes it seem like the accelerators will still work, so they should be the same color as the disabled entries.
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e218d087a65e901c83276329540765ebd087c13 commit 0e218d087a65e901c83276329540765ebd087c13 Author: thomasanderson <thomasanderson@google.com> Date: Thu Feb 16 19:47:56 2017 MenuItemView: use disabled text color for subtitles too Previously, the subtitle text color was * SelectedMenuItemForegroundColor, if the menuitem is selected * MenuItemSubtitleColor, otherwise This CL changes the rule to be * SelectedMenuItemForegroundColor, if the menuitem is selected * DisabledMenuItemForegroundColor, if the menuitem is disabled * MenuItemSubtitleColor, otherwise Linux Aura, CrOS, and Windows all have MenuItemSubtitleColor == DisabledMenuItemForegroundColor and so should be unaffected. BUG= 692745 R=sky@chromium.org,erg@chromium.org Review-Url: https://codereview.chromium.org/2700473002 Cr-Commit-Position: refs/heads/master@{#451061} [modify] https://crrev.com/0e218d087a65e901c83276329540765ebd087c13/chrome/browser/ui/libgtkui/native_theme_gtk3.cc [modify] https://crrev.com/0e218d087a65e901c83276329540765ebd087c13/ui/views/controls/menu/menu_item_view.cc [modify] https://crrev.com/0e218d087a65e901c83276329540765ebd087c13/ui/views/controls/menu/menu_item_view.h
,
Feb 16 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by thomasanderson@chromium.org
, Feb 15 2017